Commit Graph
23667 Commits
Author SHA1 Message Date
Treehugger Robot becba58cff Merge "Use expressive dismiss for clear all." into main 2025-05-23 13:43:53 -07:00
Sebastián Franco b80423b1b7 Merge "Moving DeviceProfile properties into DeviceProperties data class" into main 2025-05-23 13:17:32 -07:00
Saumya Prakash 7adea11bfa Report lower insets for SUW if expressive theme enabled
This change addresses the desire to lower the footer for SUW content if
the expressive theme is enabled in SUW. This would remove the extra gap
at the bottom of the screen.

Fix: 409897759
Test: Enable expressive theme and relaunch SUW. Check that the bottom
buttons are closer to the bottom edge of the screen.
Flag: EXEMPT bugfix

Change-Id: I7a4961549ec888e57c89a564028843f1e8c0000b
2025-05-23 20:06:14 +00:00
Bill Yi 9d1a068925 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-05-23 11:29:13 -07:00
Li Lin 9f40588951 Merge "Add a auto hide flag for Growth Framework nudge." into main 2025-05-23 10:44:24 -07:00
Sebastian Franco e1111e28c2 Moving DeviceProfile properties into DeviceProperties data class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: I638f88cd76b926917965dbf9e70b5bdfff5971e0
2025-05-23 10:42:26 -07:00
Toni Barzic bfe4503e9e Fix a crash on home with autostashed taskbar
Check whether autostash is disabled after init due to dependency on
destkop mode controller when taskbar is shown on home with
enable_desktop_taskbar_on_freeform_displays flag disabled.

Bug: 419824639
Test: see repro steps in the linked bug
Flag: EXEMPT bugfix
Change-Id: I53a1f00cef705f291c5e79c32d6508c5d832d45e
2025-05-23 16:50:00 +00:00
Sebastián Franco 48e7365190 Merge "Removing getOnceNotNull from BaseLauncherActivityTest to launcherActivity" into main 2025-05-23 09:16:49 -07:00
Treehugger Robot 2a4ad7f8a1 Merge "Share buttons change" into main 2025-05-23 08:47:09 -07:00
Treehugger Robot f8b3677c45 Merge "Don't launch a coroutine job if no jobs to cancel" into main 2025-05-23 06:44:33 -07:00
Helen Cheuk 73661fda2e Merge "[Action Corner] Add padding between action corner and taskbar" into main 2025-05-23 06:35:28 -07:00
Pat Manning 8cb1be9873 Use expressive dismiss for clear all.
Fix: 416446763
Test: TaplTestsQuickstep
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I6781e54901aa33d5f206fcb601cac76e99eee84f
2025-05-23 14:17:23 +01:00
Jordan Silva f21e4b8023 Merge changes from topics "app-chip-compose", "launcher-compose-tests" into main
* changes:
  Add AppChip in Compose
  Update build to support Compose tests custom directory
2025-05-23 05:18:32 -07:00
Uwais Ashraf 7d640afaba Don't launch a coroutine job if no jobs to cancel
Flag: com.android.launcher3.enable_coroutine_threading_improvements
Bug: 417598777
Test: Presubmits
Change-Id: I474e3e12faf2886b593571e9625a1d16df742c0d
2025-05-23 10:50:38 +00:00
Jordan Silva 98795242eb Add AppChip in Compose
- Add a new app chip in composable.
- Implement the app chip expansion animations and styles.

Bug: 400436593
Bug: 366172565
Fix: 366387927
Flag: EXEMPT build flag: release_enable_compose_in_launcher.
Test: AppChipTest
Test: AppChipScreenshotTest
Change-Id: I05ca14354ab7702026343c4e636538d507336f6a
2025-05-23 02:37:30 -07:00
Sergey Pinkevich 6e0ace619f Merge "Convert DesktopVisibilityControllerTest to multivalent" into main 2025-05-23 01:56:12 -07:00
Vinay Joglekar 0b87a41376 Share buttons change
Update Share Button and Share Targets to support Blur background

Fix: 408439461
Test: Open chrome with a webpage, tap on smart chip
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: If9290676377a3a48a94800ac3084c52146b0c9ae
2025-05-23 09:48:40 +01:00
Treehugger Robot 1521df031c Merge "Remove RenderEffect on blur targets when no blur is desired." into main 2025-05-22 17:37:27 -07:00
Sebastián Franco 957fac9f54 Merge "Prevent recents rotation animation if we are in Fixed Landscape" into main 2025-05-22 15:08:11 -07:00
Bill Yi 57135a8525 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I0bb238bbdc8fd0695d3bdbabd24403f471bf310a
2025-05-22 22:02:34 +00:00
Pierre Barbier de Reuille 06ed9c93d4 Merge "Use the developer-option flag for pin to taskbar" into main 2025-05-22 15:01:03 -07:00
Rob Mickle 56ddb0a6ac Merge "Update test to use fake repository instead of mock." into main 2025-05-22 14:58:46 -07:00
Sebastian Franco 1fcb21621b Removing getOnceNotNull from BaseLauncherActivityTest to launcherActivity
This is to make tests by composition instead of inheritance.

Bug: 324261526
Flag: EXEMPT test only
Test: All test using BaseLauncherActivityTest
Change-Id: I616207da890e1979480d1b748f69a9c27c53f9db
2025-05-22 12:06:25 -07:00
Sebastian Franco 376d628859 Prevent recents rotation animation if we are in Fixed Landscape
When in this mode we can let the system rotate the device. In other
cases we have a fake rotation and so we need to manually rotate.

Fix: 401484242
Flag: com.android.launcher3.one_grid_specs
Test: Manual testing
Change-Id: I74e5cb0363a34edb69b39f9a387b9020116d5632
2025-05-22 11:46:57 -07:00
Pat Manning 270da9a1f1 Merge "Speed up dismiss springs on subsequent touches while blocking touch." into main 2025-05-22 11:37:18 -07:00
Treehugger Robot e5b641dde1 Merge "Update TestLauncherActivity to send TAPL launcher stopped message" into main 2025-05-22 11:36:54 -07:00
Eghosa Ewansiha-Vlachavas 7501057588 Use desktop specific launch from taskbar in external displays
Flag: com.android.window.flags.enable_freeform_display_launch_params
Bug: 416336612
Test: manual
Change-Id: I6e28b2cfd6c008d522d1f02b234007bfd83a1f2a
2025-05-22 17:18:16 +00:00
Sebastián Franco b01c488915 Merge "launcher: Add e2e quickstep tests to NexusLauncherE2ETests" into main 2025-05-22 10:08:04 -07:00
Schneider Victor-Tulias 9705f8fefa Update TestLauncherActivity to send TAPL launcher stopped message
This removes the need for a workaround in LauncherInstrumentation.executeAndWaitForLauncherStop for FallbackRecentsTests with recents window enabled

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: FallbackRecentsTest
Change-Id: I1b974cb2bfff4c14e99abb96c35dcdff04ed0be7
2025-05-22 09:01:14 -07:00
Pat Manning 7207047000 Speed up dismiss springs on subsequent touches while blocking touch.
- This allows users to dimiss multiple apps as quickly as they want.
- Do not reset task dismiss translation if it is actively being dragged.

Fix: 409485085
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I939ef402ee23b3b1e8df1ae214c5ac60386a7772
2025-05-22 16:54:20 +01:00
Rob Mickle 61aab4893b Update test to use fake repository instead of mock.
Bug: 378443899
Test: OverviewCommandHelperTest
Flag: EXEMPT test cleanup up
Change-Id: Ie449a659bf6b1b33acbb6f9f6f45b800e31cf447
2025-05-22 07:42:34 -07:00
helen cheuk 6e5225bd77 [Action Corner] Add padding between action corner and taskbar
This is to avoid triggering unstashing taskbar and action corner at the same time.
A padding is added between the two areas.

Bug: 411091884
Test: TaplTestsTransientTaskbar
Flag: com.android.systemui.shared.cursor_hot_corner

Change-Id: I4e380a3d004977c96502af23f6126f22749e0a8f
2025-05-22 12:23:34 +00:00
Pierre Barbier de Reuille b8c5350c07 Use the developer-option flag for pin to taskbar
Test: Manual
Flag: com.android.window.flags.enable_pinning_app_with_context_menu
Bug: 375648361
Change-Id: I2c26ae6a5f42fd01860d7534b86ff5ca11e7f7fc
2025-05-22 03:29:34 -07:00
Lucas Dupin 66923a912c Merge "Add recents position callback to SystemUiProxy" into main 2025-05-21 23:11:59 -07:00
Treehugger Robot 51291ec848 Merge "Create the RemoteTargetGluer based on the GroupedTaskInfo" into main 2025-05-21 22:57:56 -07:00
Treehugger Robot 091890adbc Merge "Support workspace cells with two-line labels" into main 2025-05-21 18:25:15 -07:00
Tony Wickham e9ef7ad43c Migrate some logs to OverviewCommandHelperProtoLogProxy
This will allow us to see the logs in Winscope, including frame by
frame to make debugging easier.

Also added a log for Launcher#onNewIntent to help with Home button.

Test: EXEMPT log only update
Bug: 417248321
Bug: 384423890
Flag: NONE log only update
Change-Id: Ib24aeb78e44ff29542eb25411c51f77dba299a2e
2025-05-21 15:32:03 -07:00
Andy Wickham 492a170aaf Remove RenderEffect on blur targets when no blur is desired.
This change replaces 0 blur radius RenderEffect with null RenderEffect
when no blur is needed. This is because even a 0 radius RenderEffect
forces the targets to be rendered on a separate layer, which clips to
the view bounds (overriding clipChildren="false") and likely creates
a hit to performance.

Demo: https://drive.google.com/file/d/1fuFP_yaqU2KSd28aUhpuopQg6KlMKv_w/view?usp=sharing&resourcekey=0-GWMy5kKhYVo-5u69XTzihQ

Fix: 413784556
Bug: 413359333
Bug: 416815515
Test: enable all apps blur, enter spring loaded from All Apps and home
Flag: com.android.launcher3.all_apps_blur
Change-Id: I85b0ef6c8556866821679f2f02adb4938c6431d1
2025-05-21 15:27:44 -07:00
Toni Barzic 83b8cc19ca Support workspace cells with two-line labels
Adds `maxLineCount` attribute to CellSpec. The attribute indicates the max
number of lines of text the cell was speced to support. It's used to:
*   enable two-line labels in `BubbleTextViews` for workspace (including
    folder children) items
*   Update cell dimension calculation to inform cell vertical padding

When calculating cell content size the icon text size will be included
`maxLineCount` times, so the cell content gets centered as if it
contains `maxLineCount` lines of text. That way the icon position will
be consistent between cells with text that fits into one line, and cells
that contain two lines of text.

Adds `maxLineCountMatchesWorkspace` attribute to specify that the cell
should inherit `maxLineCount` from workspace cell spec.

Bug: 30153091
Flag: com.android.launcher3.enable_scalability_for_desktop_experience
Test: Manual

Change-Id: I150a62f427a0ad755a4746a736d9846d3bea4d2e
2025-05-21 22:04:33 +00:00
Jordan Silva 3d348a0d27 Add focus border animation to IconAppChipView
Fix: 366177160
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual using Keyboard. Access the app chip via TAB and navigate through the task menu.
Test: Manual using Mouse. Hover over the Chip and the Task Menu.
Change-Id: I785ad8723e5255186d744a20992ac0cd0968b380
2025-05-21 14:20:49 -07:00
Lucas Dupin 02c6fd6604 Add recents position callback to SystemUiProxy
Flag: com.android.systemui.enable_underlay
Test: atest AmbientCueRepositoryTest
Test: atest AmbientCueInteractorTest
Test: atest AmbientCueViewModelTest
Test: atest TaskbarNavButtonControllerTest
Bug: 415914274
Bug: 415914083
Change-Id: Ie6c7412d3bbc9cd64e4c9993db47821962e1b1fc
2025-05-21 14:04:18 -07:00
minch ded5807543 Create the RemoteTargetGluer based on the GroupedTaskInfo
Determine whether a `RemoteTargetGluer` for desktop should be
created based on GroupedTaskInfo instead of
`RecentsAnimationTargets.hasDesktopTasks`. The latter one is
inaccurate to assume that a desk may only have FREEFORM tasks.

Bug: 400866688
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: m
Change-Id: I6f35f41204790ada59317e0b4bd0a8965c9718eb
2025-05-21 13:42:08 -07:00
Xiaoqian (Daisy) Dai 7e21181997 desktop-exploded-view: truncate the task header app title if it overflows
A long app title can cause the close button to be covered.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 413387821
Change-Id: Id66cabb271ac6f4772969335232e3e9638828571
2025-05-21 20:13:53 +00:00
Schneider Victor-Tulias 124b010ea9 Add recents animation start timeout handling to TaskAnimationManager
In cases where a recents aniamtion transition was successfully requested but failed to start, we should clean up the gesture state to recover.

Flag: EXEMPT bug fix
Fixes: 415930274
Test: TaskAnimationManagerTest.testRecentsAnimationStartTimeout_cleansUpRecentsAnimation
Change-Id: If1a24d6c7baac7338c49056531bc01665f082ddf
2025-05-21 15:55:44 -04:00
Sergey Pinkevich d0fccf8773 Convert DesktopVisibilityControllerTest to multivalent
Bug: 397902030
Flag: NONE test fix, not actual code editing
Test: atest NexusLauncherTests:DesktopVisibilityControllerTest

Change-Id: Ie6ae4abb2a894d4f7403e77cf797cdce924fd9e3
2025-05-21 18:50:43 +00:00
Simon (Qiong) Sun 00063bcf2f Support multiple tasks per split screen via SplitRemoteTargetHandles
It enables support for assigning SplitRemoteTargetHandles to multiple tasks within a split-screen.

The changes include:

- Retrieving the list of split-screen tasks directly from `SplitBounds`.
- Iterating through the task list and setting the remoteTargetHandle for each individual task.
- General code refactoring to set the remoteTargetHandle.

Bug: 346295292
Bug: 360782849
Flag: com.android.wm.shell.enable_flexible_two_app_split
Test: manual test.
Video: Before: http://recall/-/gvQq7Z7JECwxnxKrBmr3wt/fnHVbaVwMWfvrOaez5eO6L
Video: After: http://recall/-/gvQq7Z7JECwxnxKrBmr3wt/dzv6tZMlAYG1bBBtYdsWxF

Change-Id: I1e8c8316947b0d4fd72c9cf36dff8ecd99d2f170
2025-05-21 17:51:09 +00:00
Schneider Victor-Tulias 6d532fe59d Fix broken state when tapping nav handle from running app.
When tapping the nav handle from running app, OtherActivityInputConsumer will start the recents window through TaskAnimationManager. The recents window would then typically be closed through the StateManager, however since the state isn't changing, then RecentsWindowManger never actually gets any signal to close the recents window. Added a new callback to fix this flow.

Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/post submit tests. tapped nev handle from a runnign app
Change-Id: If1fe7de195a9a8a98c72629c7904d469a5768d7f
2025-05-21 10:35:11 -07:00
Jordan Silva e14014cc88 Merge "Fix task icons sometimes not appearing in recents view" into main 2025-05-21 10:09:00 -07:00
Treehugger Robot 57de0ebf21 Merge "Make sure RecentsWindowManager is created for TaskbarUIController" into main 2025-05-21 09:56:04 -07:00
Liran Binyamin 328bf4ab1c Fix bar state when overflow is selected initially
Fix the state of the bubble bar when the initial state received
from sysui has the overflow selected, which can happen after
unfolding. This ensures that the arrow position is set correctly,
and that when tapping on the overflow in this state the bar
collapses.

Bug: 392893178
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual
       - have floating bubble and expand
       - selecte overflow
       - unfold
       - observe overflow is expanded and bubble bar arrow position
         is correct
       - tap on the overflow bubble
       - observe bar collapses
Change-Id: I4a3d217ce951c7c7f2d17da89b0cd5905faf0eff
2025-05-21 12:49:02 -04:00