Commit Graph
23667 Commits
Author SHA1 Message Date
Treehugger Robot 423178c71e Merge "Match taskbar edge padding to nav button end insets" into main 2024-10-26 03:19:14 +00:00
Stefan Andonian bb85110a0d Delete Unused Flag related to Altering how the workspace is loaded.
This flagged feature was never released, and instead was thought to be too
complicated compared to the benefits in decreased latency.

Bug: 251502424
Test: Verified that this launcher still loads properly when this flag is removed.
Flag: EXEMPT flag removal
Change-Id: I672708e26cb37d1e2b22c4510f9c3500edd4f959
2024-10-25 22:28:55 +00:00
Toni Barzic befd6bb1ea Prevent tap in swipe up zone from closing KQS
Tap down action in swipe up start zone may or may not be start of a
navigation gesture - for example, it may be start of a tab on an icon in
the task bar. If the user taps on the taskbar overflow button, closing
the KQS on tap down produces unintended behavior (KQS is closed on tap
down, and reopened on tap up). Additionally, this produces inconsistent
behavior in response to app icon taps depending on whether gesture
navigation is enabled or not.
Instead, close KQS as part of `hideOverlayWindow()`, which gets called
when a swipe gesture actually starts (note that KQS is added to the
overlay's drag layer).
Additionally, make sure that KeyboardQuickSwitchController state is
reset if KeyboardQuickSwitchView gets detached from UI due to the
taskbar overlay getting hidden (e.g. in response to home button).
Without this, in certain situations, KQS may get hidden with the
controller thinking the UI is still shown - in case the user releases
the Alt + Tab key combination in this state, the shortcut would end up
getting handled, and switch to the next task.

Bug: 368119679

Test: Press and hold Alt+Tab (while an app is open). After KQS is open,
Swipe up to transition to overflow, or home screen - KQS gets hidden.
Releasing Alt+Tab is no-op.
Test: Press and hold Alt+Tab (while an app is open) with three button
navigation enabled. Press home button. KQS gets hidden. Releasting
Alt+Tab is no-op.
Test: Press and hold Alt+Tab. After KQS is open, open an app from task
bar (either transient or persistent), or all apps list. KQS gets closed,
Releasing Alt+Tab is no-op.

Flag: EXEMPT bugfix

Change-Id: I8b561db3c6ec8a9c7de93e330faf8e3e4d3c8f4e
2024-10-25 21:43:56 +00:00
Toni Barzic ce6d32199b Mark TaskbarOverlayProxyView closed sooner
Marks TaskbarOverlayProxyView closed earlier in handleClose, before
removing it as a view from the drag layer. BaseDragLayer expects that a
floating view is closed by the time it gets removed, and asynchronously
issues another close call if this is not the case as a workaround.

Marking the proxy view closed sooner also reduces chances of reentrant
close call while handling current close.

Bug: 368119679
Test: Opening/closing all apps, folders, KQS
Flag: com.android.launcher3.taskbar_overflow

Change-Id: I33ccb82ebd7e967f2e47f38db3e41527dad9d573
2024-10-25 21:06:27 +00:00
Toni Barzic 20e420ca40 Match taskbar edge padding to nav button end insets
When calculating max number of items to show in a taskbar with overflow,
reserve space for taskbar end/start margins that matches inline nav
buttons end spacing.

Bug: 368119679
Test: None
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I1205663ed4455ae1e7807f8d4edf5aaf2beba7d4
2024-10-25 20:49:04 +00:00
Mykola Podolian ddf212523f Merge changes Ibdecabd1,If330dc9e into main
* changes:
  Added scale animation for taskbar pinning transition.
  Animate the bubble bar Y for task bar pinned/unpinned switches.
2024-10-25 19:48:55 +00:00
Mykola Podolian f871e64f3c Merge "Set proper interpolators and durations for the bubble bar animations" into main 2024-10-25 19:48:08 +00:00
Anushree Ganjam ba8c0a8fbd Merge "Make ApiWrapper to be injected by dagger (12/n)" into main 2024-10-25 19:27:50 +00:00
Uwais Ashraf 821bcaade5 Merge changes I65e6ad57,I0335e4d0 into main
* changes:
  Remove listener in destroy() that caused a memory leak.
  Reuse TTV, recreating deps to get faster load times, lower mem usage
2024-10-25 17:11:37 +00:00
Uwais Ashraf b80f90bc0d Remove listener in destroy() that caused a memory leak.
Fix: 370916189
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manually looking at heap dumps. Verify leaked obj no longer there
Change-Id: I65e6ad57d1ac6873946d836d8221b67deef548b1
2024-10-25 15:18:23 +00:00
Uwais Ashraf 6f61228a6b Reuse TTV, recreating deps to get faster load times, lower mem usage
Use a ViewPool for DesktopTaskView for same reason.

Fix: 369590189
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manually looking at slow-mo videos of home to overview
Change-Id: I0335e4d0eea4841145815244bbbec19541f31c73
2024-10-25 15:18:08 +00:00
Cosmin Băieș 879cbb1ff4 Cleanup ENABLE_HIDE_IME_CAPTION_BAR flag
This flag has already been enabled for a while, and is included in
releases, so we can clean it up now.

Flag: EXEMPT cleanup
Bug: 375571655
Test: atest InputMethodServiceTest#testRequestHideImeCaptionBar
  InputMethodServiceTest#testRequestHideThenShowImeCaptionBar
  InsetsSourceTest#testCalculateInsets_imeCaptionBar
  InsetsSourceTest#testCalculateInsets_imeCaptionBar
  InsetsSourceTest#testCalculateBoundingRects_imeCaptionBar
  InsetsSourceTesttestCalculateBoundingRects_imeCaptionBarFrameMisaligned_rectsFixedToBottom
Change-Id: I809c69156c06ff5c06ca43ef4dd248f90d54f6d8
2024-10-25 12:07:46 +02:00
vinayjoglekar d5d51e51d7 Fix flickering of tasks in desktop window when opened as static tile.
This for loop was added to fix animation glitch if there is scenario of showing splash screen(on config change). Live tiles don't have this issue because we don't create RemoteTargetHandles.

Fix is to set Z-Index as per correct order since current value is same for all tasks.

Test: Manual, Add multiple apps to desktop task, Make it static tile and launch.
Fix: 370731110
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I9e3f1fd1333b6113423f51309917317febc1805b
2024-10-25 10:30:38 +01:00
Toni Barzic 143edac127 Tapping overflow button toggles KQS
Updates the taskbar overflow button handler to toggle the KQS instead of
merely showing it. The toggle action will open KQS view if it's not
visible, or close it if it's visible and has been shown from the
taskbar. If the view is shown, but in response to Alt+Tab, the view will
be closed, and reshown above the task bar.

Requires CL:30016166 for tapping to work as expected, and CL:30074037
for tapping overflow button reopen KQS over shelf if KQS is already
active for Alt+Tab

Bug: 368119679
Test: Enter task bar overflow. Tap overflow button to show KQS, tap
overlow button to hide KQS. Press Alt+Tab, tap overflow button to
reshow KQS over taskbar, and with filtered set of tasks.
Flag: com.android.launcher3.taskbar_overflow

Change-Id: Id598f9cad649aa174aaf1c5802bf6b6837413d1e
2024-10-25 03:28:17 +00:00
Treehugger Robot 38c94afefc Merge "Actually merge the colors for recent indicators." into main 2024-10-24 23:26:18 +00:00
Jagrut Desai 9aa005b657 Fix Taskbar Touchable Region when overview is in split select mode
The problem: when Overview is in split slect mode second split app pick from taskbar take you back home. Why, because upon touch the taskbar touch region get
 set to empty and then we later don't meet any conditions to set default touch region to something.

The solution: change the condition of checking overview in onTaskbarOrBubblebarWindowHeightOrInsetsChanged so that we check that taskbar is in any overview s
tate and we don't rely on the stash controller flag alone. we follow similar logic in updateInsetsTouchability, but we gate that only behind transient taskba
r hence this was not an issue for transient taskbar.

Test: Manual
Bug: 373559050
Flag: EXEMPT bugfix
Change-Id: Ia507354f42959ce9d320114a313bfc533186b524
2024-10-24 15:31:02 -07:00
mpodolian 92d25cd21d Added scale animation for taskbar pinning transition.
Animate the bubble bar icons size and padding for taskbar change mode
animation.

Bug: 345698412
Test: TaskbarPinningControllerTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Ibdecabd1310203dc956f69673dc446a0e7e556a6
2024-10-24 13:45:11 -07:00
Mykola Podolian f85a484a9d Merge "Removed stashing hotseat calls." into main 2024-10-24 20:36:06 +00:00
mpodolian ed7ef84782 Set proper interpolators and durations for the bubble bar animations
Set proper interpolator and duration for bubble bar expansion and
collapsing animation. Also set animation properties for the taskbar
fade in and out animations.

Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Expand / collapse bubble bar when taskbar is pinned and
expanded bubble bar would intersect the task bar.
Fixes: 360821863

Change-Id: Ia83d6aecdae921721a31b45f22400f878040f3d6
2024-10-24 13:14:54 -07:00
Brandon Dayauon 838a5e9d23 Merge "Add trace logs in Launcher for perfetto to investigate two line issue" into main 2024-10-24 19:35:15 +00:00
Anushree Ganjam ef2c5c0e49 Make ApiWrapper to be injected by dagger (12/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I53ec78999085b3e0ad6df69e177806e0cb1b52d1
2024-10-24 12:14:40 -07:00
Saumya Prakash 747c6b4427 Merge "Prevent Search taskbar edu from showing on home screen." into main 2024-10-24 18:00:24 +00:00
Wen-chien Wang 94fb42cef9 Merge "Add margins to KQS view that is triggered from taskbar" into main 2024-10-24 17:47:37 +00:00
Schneider Victor-Tulias 8b88177fb7 Fix launcher crash on configuration changed
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 375398042
Test: rotated device
Change-Id: Ib57a7c43a664b5ba73284b9265c04cba16e4d4d2
2024-10-24 11:13:33 -04:00
Vinit Nayak 14e43ef0de Disable OrientationEventListener in RotationTouchHelper#destroy()
* Also cleared the list of runnables to run on destroy after
they are all executed

Bug: 361850561
Flag: EXEMPT bugfix
Test: QS works as expected in different rotations
Change-Id: If0dfbb7d538b24fe7aad0b4ed427d779b5a86bfd
2024-10-24 10:25:14 -04:00
Liran Binyamin abc4b6a137 Merge "Handle taps on bubble bar flyout" into main 2024-10-24 13:26:50 +00:00
Brandon Dayauon 51db65ee49 Add trace logs in Launcher for perfetto to investigate two line issue
bug:375267130
Test manually screenshot:
onIdpChange: https://screenshot.googleplex.com/ASbyGFoAhTXgnWK
statefulActivityOnConfigChange: https://screenshot.googleplex.com/gLqxeJN7TzUURCy
Flag: NONE adding traces to perfetto

Change-Id: Ib2ac49fb8668fdfc91c8e38b91a4afd10127a4c5
2024-10-23 22:59:58 -07:00
Treehugger Robot 388701a031 Merge "Add debugging logs to transition animation" into main 2024-10-24 05:51:18 +00:00
Mykola Podolian 4dc6617988 Merge "Updated bubble bar position to be center aligned with the hotseat" into main 2024-10-24 02:10:43 +00:00
Sihua Ma aa921fa3eb Add debugging logs to transition animation
Test: N/A
Bug: 364465567
Flag: EXEMPT logs only
Change-Id: I8275c43ac44cd4b027fa8ad3d94fe0e84063b8d1
2024-10-24 00:58:58 +00:00
Treehugger Robot 1e4f42ff7f Merge "Account for all apps offset during taskbar layout" into main 2024-10-24 00:10:08 +00:00
Liran Binyamin aa3f772622 Handle taps on bubble bar flyout
Expand the bubble bar when the user taps on the flyout view.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarViewAnimatorTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: I156acfa663d6a00bc70dd7bbfc35642643902d83
2024-10-23 19:46:14 -04:00
Treehugger Robot 46a98e1827 Merge "Update taskbar overflow button" into main 2024-10-23 22:49:37 +00:00
mpodolian f230eee2ff Updated bubble bar position to be center aligned with the hotseat
Added a method to the device profile to calculate the vertical center of
the hotseat icons. Simplified the logic for positioning the bubble bar.

Test: TransientBubbleStashControllerTest
Test: PersistentBubbleStashControllerTest
Test: Visual. Go to home page, check that bubble bar is vertically
center aligned with the hotseat
Bug: 345491493
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I52f1b94de79f6c912f43a88fcc5c884e20e56310
2024-10-23 14:44:40 -07:00
Saumya Prakash 9b60028f99 Prevent Search taskbar edu from showing on home screen.
If a user pins the taskbar and immediately swipes to home, this would
show the taskbar edu tooltip on the home screen. This change checks that
taskbar isn't transitioning to home to prevent that scenario.

Fix: 369061563
Test: Reset Search Taskbar edu, pin taskbar, then swipe to home
immediately. Ensure that the edu doesn't show up on home
Flag: EXEMPT bugfix

Change-Id: I9948189df880b3ed318c4952a8f715cf9a7fa708
2024-10-23 21:38:58 +00:00
Brian Isganitis c0a18d57e8 Actually merge the colors for recent indicators.
Forgot to do a git add :)

Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 356394053
Test: go/testedequals
Change-Id: I42f85f5850152f498db8a399835b19a5e493c68d
2024-10-23 14:45:49 -04:00
Treehugger Robot debda9cdd9 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-23 17:34:58 +00:00
Toni Barzic a5b6c155b6 Update taskbar overflow button
Creates a new view for the taskbar overflow button that draws up to 4
recent item previews. The items are stacked on top of each other in
counter clockwise order, with overlapping bounds, recent items closer
to the top. The item icons have a 2 dip ring around them, of the taskbar
background color.

Adjusts logic to calculate which items become part of the overflow
button, so more recent items get shown in the taskbar.

Initial consideration was to usse FolderIcon to represent the overflow
button, but decided against it because:
*    FolderIcon is fairly entangled with the associated folder view
*    item information uses different data structure (ItemInfo) than
     recent items (GroupTasks)
*    item preview layout within the main icon is similar, but
     sufficiently different that using clipped folder layout rules felt
     like hacking around assumptions made for folder icon UI

Bug: 368119679
Test: Keep opening apps until the task bar enters overflow - verify that
overview button shows up, and contains least recent task
representations. Keep adding items, then closing windows, and verify
the icon gets updated accordingly. Done in landscape and portrait, and
ltr and rtl layout.
Flag: com.android.launcher3.taskbar_overflow

Change-Id: I2824cb0db1f7516ebd74361ce00fb8887857325d
2024-10-23 17:05:58 +00:00
Wen-Chien Wang 69ed08ef86 Add margins to KQS view that is triggered from taskbar
Bug: 368119679
Test: open KQS via taskbar and observe the bounds change
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I5060a339cf0cdf70a2a11b57a325767405772ef8
2024-10-23 04:03:50 +00:00
mpodolian f679ba942f Removed stashing hotseat calls.
Removed calls that were stashing and unstashing the hotseat bar.

Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Be on Launcher home, have some bubbles. Expand / collapse
bubble bar. Hotseat remains behind the scream view.
Fixes: 373429249

Change-Id: I1a9ba39c8ca11d49340f217f095d5e872b06105b
2024-10-22 15:25:26 -07:00
Treehugger Robot 08007068d4 Merge "Generalize ActivityTracker to support RecentsWindowManager" into main 2024-10-22 21:26:58 +00:00
Bill Yi 451a5e395f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie3164382c2b9dbf6623f91721a88a2347b9fdde1
2024-10-22 13:45:15 -07:00
Brian Isganitis 8018dcad35 Merge "Update recent indicators to match spec." into main 2024-10-22 19:31:48 +00:00
Schneider Victor-Tulias 8463dc47eb Generalize ActivityTracker to support RecentsWindowManager
Continued quick switch couldn't work using existing infrastructure until RecentsWindowManager could be properly tracked by ActivityTracker. Refactored ActivityTracker into ContextTracker to support this.

Also refactored ActivityInitListener into ContextInitListener to fit the updated pattern.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 366023051
Test: RecentsWindowSwipeHandlerTestCase; Attempted continued quick switch from home and launched app
Change-Id: Ic38ebf3611ef22fbfd1ddeb79d72d8a3621940a0
2024-10-22 15:29:59 -04:00
mpodolian eedc7ab8fd Animate the bubble bar Y for task bar pinned/unpinned switches.
Animate the horizontal position of the bubble bar on taskbar pinned /
unpinned switches.

Bug: 345698412
Test: TaskbarPinningControllerTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: If330dc9e5f7b16a588973ad6043a5dc6709e13ab
2024-10-22 11:19:17 -07:00
Treehugger Robot 08f950245e Merge "Fix swipe up from Desktop Tasks is updated does not show focused task" into main 2024-10-22 16:40:34 +00:00
Jordan Silva a48efb33f2 Fix swipe up from Desktop Tasks is updated does not show focused task
Fixes the condition that defines which task should be the focused task when grid-only is enabled and desktop windowing is the running task.

In some cases, when the user adds or removes a task from Desktop Window, the DesktopTaskView does not get updated with the new list of tasks. This causes a mismatch of tasks that are inside the DesktopTaskView and the actual Desktop Windowing. So, RecentsView can't match the previous DesktopTaskView with the current running tasks, entering a specific condition to update the runningTaskViewId. The method called in this condition (showCurrentTask) also updates the focusedTaskViewId for some situations. This CL fixes the conditions which focusedTaskViewId is set to prevent it to replace the focused task id when it's not needed.

Fix: 370736395
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: Manual
Change-Id: I25f5bd67ee0486f6754673eec404832779fc0498
2024-10-22 15:38:49 +01:00
Marcelo Arteiro 2d7b004842 Fix home screen briefly flashes after setup.
Bug: 368521393
Change-Id: I5ef6a6332bb54f058fefe56cdada13952341bb22
Flag: EXEMPT bugfix
Test: Manual
2024-10-22 13:22:18 +00:00
Mykola Podolian 18b3171980 Merge "Revert "Made the taskbar touchable during animation to home."" into main 2024-10-22 03:59:13 +00:00
Mykola Podolian 164b832ec4 Revert "Made the taskbar touchable during animation to home."
This reverts commit d89732ef85.

Reason for revert: b/374080485
Flag: NONE
Change-Id: I56236f539957efaaa4caa30a4b887d017037709f
2024-10-21 17:36:49 -07:00