Commit Graph
23667 Commits
Author SHA1 Message Date
Vinay Joglekar 595f88c8e7 Merge "Fix live tile blur when overview blur flag is off" into main 2025-05-12 10:52:28 -07:00
Jagrut Desai bc28b98b8f Fix TaskbarAllApps Icon
Test: Manual, UX
Bug: 415836854
Flag: EXEMPT bugfix
Change-Id: I8b305ce35e0a6b73559f73083a0ca9b025043e8c
2025-05-12 10:46:57 -07:00
Brandon Dayauon bfa3f776fd Null check during filtering itemInfo by itemType.
Java crash says theres NPE on an itemType on null object reference implying itemInfo is null.

bug: 416662647
Test: presubmit
Flag: EXEMPT crash fix
Change-Id: I3c9724964442435148a720e96f208bd7c2a19ad5
2025-05-12 10:09:20 -07:00
mpodolian a4d2e5aa19 Restore taskbar stashed state on the overview screen.
Added logic to preserve overview screen state on the taskbar.

Fixes: 416418164
Test: Manual. Go to overview with the bubble bar. Expand bubble bar.
Rotate device. Observe the taskbar remains stashed.
Flag: EXEMPT bug-fix

Change-Id: I197c1b7f20b23a6b2a343b18b4da0aa45beb8c52
2025-05-12 10:01:23 -07:00
Uwais Ashraf a9f5aa5016 Merge "Do not take an additional screenshot during Overview transitions as it uses memory unnecessarily and adds load to system server" into main 2025-05-12 10:01:10 -07:00
Uwais Ashraf 16a6b28e1a Do not take an additional screenshot during Overview transitions as it uses memory unnecessarily and adds load to system server
Flag: com.android.launcher3.enable_coroutine_threading_improvements
Bug: 416206104
Test: Temporary local logging check
Change-Id: Ib8226ea238749097fdb160619b126a843b509529
2025-05-12 09:56:16 -07:00
Artsiom Mitrokhin 57db1826c9 Merge "Fix a crash when changing the observer list while iterating through it" into main 2025-05-12 09:37:25 -07:00
Uwais Ashraf 038c62f14d Merge "Cancel jobs on exit from Overview. Also cleanup Views to prevent leaks." into main 2025-05-12 09:36:48 -07:00
Hyunyoung Song e48deacbd4 Revert "Prevent CtS invocation in fake landscape mode"
This reverts commit 299576a777.

Reason for revert: b/402037577

Change-Id: I240ffd68ccf3536d80eda1c63395c64c8e48de22
2025-05-12 08:47:50 -07:00
Ajinkya Chalke 36a811aa57 Use RecentsWindowFlags in DisplayController
- Instead of using enableOverviewOnConnectedDisplays from aconfig
  directly, use WindowManagerProxy to use RecentsWindowFlags so that we
  can use DesktopExperiencesFlags version for dev option.

Bug: 413609179
Test: m
Flag: EXEMPT flag infra
Change-Id: Iaacf068be13282017f94360acce1eea9aa1b0e84
2025-05-12 15:44:08 +00:00
Johannes Gallmann 76621e0972 Remove haptics for long presses in 3-button-nav
This CL removes haptics for long presses on 3-button-nav buttons, except
when the long press triggers a user visible action.

This means that for example the haptics for long pressing the recents
button are removed, whereas haptics for long pressing the home button
remain active since that launches circle-to-search.

Bug: 408968370
Test: Manual, i.e. verified that no haptic feedback is played when
      long pressing the recents button
Flag: EXEMPT bugfix
Change-Id: Icfeade8a659a8aa4882ef139696c66f410980303
2025-05-12 15:35:57 +00:00
Schneider Victor-Tulias 0f5f5b4fc9 Fix missing tapl key events in TaplTestsQuickstep
Because we were closing the recents window too quickly, the final ACTION_UP was never getting received. This change also cleans up the exit flow with the correct animation. Also posting touchModeChanged in OverviewCommandHelper to better support recents window, since the recents window may not be attached to window yet

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: TaplTestsQuickstep.testDismissOverviewWithEscKey, TaplTestsQuickstep.testDismissModalTaskAndOverviewWithEscKey, TaplTestsQuickstep.testOpenOverviewWithActionPlusTabKeys
Change-Id: I89e6c5716c0399857722114a243ed23c20a5c43d
2025-05-12 10:31:09 -04:00
Schneider Victor-Tulias b6a3b5d624 Add support for save app pairs to recents in window
Save app pairs does not support 3P launchers, however the way we were checking for that case was incorrect. Updated the checks to support recents in window.

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: TaplTestsSplitscreen.testSaveAppPairMenuItemOrActionExistsOnSplitPair
Change-Id: I6c91e0ed2aa5bc16e828f71def422d5a721c1aa1
2025-05-12 10:29:17 -04:00
Schneider Victor-Tulias db74f177a6 Update RecentsView to allow re-apply load plan
If the recents view is not attached to window when reloadIfNeeded is called, then mTaskListChangeId will be set, but applyLoadPlan will exit early without actually applying the loaded tasks. This is an issue since the recents list will remain outdated until the task stack changes. This has been causing issues in tapl tests with recents window enabled. Delaying the setting of mAppliedTaskListChangeId until the end of applyLoadPlan to fix this.

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: TaplTestsQuickstep.testDismissLastGridRow
Change-Id: Iaa8441a74b54f86167a7963b0005c044f355d94e
2025-05-12 10:29:06 -04:00
Schneider Victor-Tulias e4c3faa138 Update AbstractQuickStepTest to check non-recents states correctly
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/post submit
Change-Id: I7a4381bbc8214beea2e354df2851f0ba1aaddd5c
2025-05-12 10:28:53 -04:00
Schneider Victor-Tulias 82050b85fa Fix FallbackRecentsTest with recents in window enabled
- Added a workaround to listen to onNewIntent without RecentsActivity in TouchInteractionService, allowing us to clean up the recents window appropriately
- Updated LauncherInstrumentation.executeAndWaitForLauncherStop to expect a state change instead of activity stop in 3P + recents window

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I3756e268626d778a13be1f2c68f9d3157602534e
2025-05-12 10:27:41 -04:00
vinayjoglekar 50d27b353a Fix blur jank when app -> overview and app -> home.
This cl fixes conditions of when to skip the blur. While setting any  new surface, we should always apply the blur.

Fix: 417131537
Fix: 416689392
Test: Go to overview from app. Go to home from app
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I16ff00cf0be554eaf9aa4f48adc23b5cec4ae3da
2025-05-12 14:28:07 +01:00
Uwais Ashraf da860e3d46 Reduce combine() usage as it is expensive
Flag: com.android.launcher3.enable_coroutine_threading_improvements
Bug: 416206104
Test: Perfetto trace comparison shows fewer continuations
Test: TaskViewModelTest
Change-Id: Id5c645afff9850453139b85dbcda907cd12c5d26
2025-05-12 12:54:11 +00:00
Uwais Ashraf b817ec3735 Cancel jobs on exit from Overview. Also cleanup Views to prevent leaks.
Flag: com.android.launcher3.enable_coroutine_threading_improvements
Bug: 416206104
Test: Presubmits
Test: ABTD run checking memory usage
Change-Id: I5634a5912d5d7c069586c42559f45cc2ef132123
2025-05-12 12:15:26 +00:00
vinayjoglekar abeae4241b Fix live tile blur when overview blur flag is off
"applyDepthAndBlur" should be directly called when Opaqueness changes. When scrim is not opaque, blur should be applied to overview background and when scrimview is fully opaque, blur should be removed and set to 0.

Fix: 416686314
Test: Go to overview (live tile) when flag is off.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Iaad158ddb2f6dc89afefcd89a569a202a712ad47
2025-05-12 12:04:33 +01:00
Treehugger Robot 247d720fec Merge "Revert "Use custom height for all apps for CD"" into main 2025-05-12 02:23:03 -07:00
Toshiki Kikuchi c0da168637 Prevent unnecessary DisplayInfo refreshment
This CL avoids refreshing DisplayInfo when the display is not freeform.
As notifyConfigChange() is expensive, we want to minimize the call.

Note: enterDesktopByDefaultOnFreeformDisplay only checks the flag state
but showLockedTaskbarOnHome can check if the display is freeform in
addition to the flag state.

Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: TaplTestsLockedTaskbar
Bug: 416253799

Change-Id: Ief298c05c8ce46ed70055139e5e817b41f6a572d
2025-05-12 11:22:17 +09:00
Ajinkya Chalke 3f651657f7 Revert "Use custom height for all apps for CD"
This reverts commit 0c32760b3c.

Reason for revert: Issue on smaller screen b/416220478#comment7

Bug: 416220478
Change-Id: I8b1063a1ebc8b250e41d2587399647a589ef05b8
2025-05-10 13:50:33 -07:00
Andy Wickham 58fd27a0cb Fix All Apps fallback colors.
Spec is linked in the bug.

Test: Manual
Fix: 415847439
Flag: com.android.launcher3.all_apps_blur
Change-Id: I805aff19bb3d15d479b7c2c026f041c35585efd2
2025-05-10 01:21:54 +00:00
Andy Wickham 359280ef2c Split BlurStyle and BlurFallbackStyle for All Apps and Overview.
Problem: We don't want to apply the blur style to All Apps if the
all_apps_blur flags are disabled. However, we want to still apply
the relevant colors for Overview when the Overview blur is enabled.

Solution: Split the styles into All Apps and Overview variants.
Unfortunately this creates quite a bit of extra code, but such is
the nature of flag permutations.

This is a more comprehensive color fix compared to ag/33356345,
which is reverted as part of this CL.

Note: enable_overview_background_wallpaper_blur is already broken
when disabled without this change (the live tile gets blurred),
presumably because it's already in nextfood and hasn't been tested
disabled. As such, I focused on testing All Apps blur flags both
enabled and both disabled, with the Overview flag always enabled.

Demo with All Apps flags disabled:
 - Blurs enabled (Overview should blur; All Apps unaffected):
   https://drive.google.com/file/d/1eb882JKSMF-Irc7Ls-iAClYfJIASzzXs/view?usp=drive_link&resourcekey=0-j5EafBfVHIh5oOSFzsYE4g
 - Blurs disabled (Overview should not blur; All Apps unaffected):
   https://drive.google.com/file/d/1toVHYUTj9FjpXCD7m8waeuFIwBbdy_Am/view?usp=drive_link&resourcekey=0-drqPVsELmgJVxhpgxLc-aQ

Demo with All Apps flags enabled:
 - Blurs enabled (Overview and All Apps should blur):
   https://drive.google.com/file/d/1se5yaPDYdDKcoBjZSjDSlqCiSfX0bmHv/view?usp=drive_link&resourcekey=0-U9fBJSVYY9na9r8J5xHXMw
 - Blurs disabled (Overview and All Apps should not blur):
   https://drive.google.com/file/d/1YmqlCdSJDZXGSgpeO5hk16V8Y-6tVpeW/view?usp=drive_link&resourcekey=0-rK4Zy7D8fFyPMA_1XXxwCQ
   (Note: All Apps fallback colors will change with ag/33405653)

Test: Above videos
Fix: 416248709
Flag: com.android.launcher3.all_apps_blur
Flag: com.android.launcher3.all_apps_sheet_for_handheld
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I9b5cf6b0dce4014053b27ea95a91d047262427b2
2025-05-10 01:21:43 +00:00
Treehugger Robot d03c7e64e2 Merge "Start SurfaceFlinger early wakeup sooner for blur." into main 2025-05-09 17:37:52 -07:00
Treehugger Robot d506f0154b Merge "Adding support for generating a preview bitmap with an optional delay to allow widgets to be rendered" into main 2025-05-09 17:16:29 -07:00
Wen-chien Wang 495fb1e9b4 Merge "pin-shortcut: Check desktop state for the feature" into main 2025-05-09 17:06:48 -07:00
Treehugger Robot ae69c409bd Merge "Clean up taskLaunch and taskLaunchCancel runnables more consistently" into main 2025-05-09 16:44:52 -07:00
Liran Binyamin a0dcefc714 Mark a BubbleBarViewScreenshotTest test flaky
Bug: 416207075
Flag: EXEMPT test only
Test: treehugger
Change-Id: Ib3c5878e554be19aa0580450f46c63365c622771
2025-05-09 14:02:06 -07:00
Treehugger Robot c9eb3511d2 Merge "Separate blur/fallback styles for all apps and overview" into main 2025-05-09 13:34:51 -07:00
Alex Chau f472991f88 Merge "Revert "Add debug log for RecentsView touch down"" into main 2025-05-09 10:50:55 -07:00
Sunny Goyal 63fe0c779e Adding support for generating a preview bitmap with an optional delay to allow widgets to be rendered
> Adding a completionSignal when preview is generated so that callers can wait on it
> Also adding support for proving an optional screen-id for preview

Bug: 400403115
Test: atest GridPreviewTest
Flag: EXEMPT refactor and unused new API

Change-Id: I569e0ab318ad101e4f6dd808f2e1cfc39ba50bda
2025-05-09 10:42:39 -07:00
Artsiom Mitrokhin 6bafdd6170 Fix a crash when changing the observer list while iterating through it
Bug: 414928917
Flag: NONE bugfix
Test: none
Change-Id: I07ab4bb4b57e95b02e66d27b286f922b6691f69c
2025-05-09 13:04:27 -04:00
Alex Chau eefa935e5a Merge "Add temp logging to select task" into main 2025-05-09 09:46:48 -07:00
Uwais Ashraf 1ae9814920 Merge "Create separate worker threads for IO work and lighter BG work" into main 2025-05-09 09:45:40 -07:00
Treehugger Robot 71438c16d8 Merge "Use custom height for all apps for CD" into main 2025-05-09 09:27:34 -07:00
Ebru Kurnaz 09d7cf1014 Update PerDisplayModule to provide IWindowManager to displayLib.
Bug: 412580790
Test: N/A
Flag: EXEMPT dagger binding change
Change-Id: Ia252e2a358706d1aeef1d586a7c125e61802cc58
2025-05-09 15:44:59 +00:00
Treehugger Robot 2ad54144f0 Merge "Fix Select mode transalte in wrong direction in RTL" into main 2025-05-09 08:32:44 -07:00
Alex Chau 61853619c0 Remove debug logs on a closed bug
Bug: 246283207
Test: presubmit
Flag: EXEMPT clean up
Change-Id: I54aa8ffe929494c4c0ea97c016f9d53f7e27024c
2025-05-09 16:17:07 +01:00
Alex Chau 3db085d650 Revert "Add debug log for RecentsView touch down"
This reverts commit 45162f9cf0.

Reason for revert: bug is closed

Bug: 318590728
Change-Id: Id4c91298e90170ac49f948a8fe3aa197cd3dc88d
2025-05-09 08:14:00 -07:00
Treehugger Robot 0dddfe6aae Merge "Account for magnetic detach when dismissing tasks in TAPL tests." into main 2025-05-09 08:12:58 -07:00
Alex Chau 7ea16a5408 Add temp logging to select task
Bug: 407815700
Test: presubmit
Flag: EXEMPT logging
Change-Id: I8eec794763c4e1619c35ff1bf26d64c287a6bd27
2025-05-09 14:44:05 +01:00
Alex Chau 0595b9c38a Fix Select mode transalte in wrong direction in RTL
- It's simply missing a +/- flip when it's RTL

Fix: 406241212
Test: manual
Flag: EXEMPT bug fix
Change-Id: I0a82bf5dfbe7bd15cf1eacd27c330801bc585452
2025-05-09 14:08:55 +01:00
vinayjoglekar 3997f6ce4a Separate blur/fallback styles for all apps and overview
Fix: 415233763
Test: Manual. go to overview/all apps enable/disable battery saver mode.
Flag: com.android.launcher3.all_apps_blur
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I4fdb672feb34d4b4da74f430eb8ef9a86ec3adf2
2025-05-09 10:17:11 +01:00
Uwais Ashraf c1102750dd Create separate worker threads for IO work and lighter BG work
Documentation largely pulled from Kotlin coroutines docs.

Flag: com.android.launcher3.enable_coroutine_threading_improvements
Bug: 416206104
Test: Presubmits
Change-Id: I89b7222e31680619e311fa9e9986da5c12d80ed4
2025-05-09 06:49:48 +00:00
Yunfan Chen 71d8ca3896 Merge "Update Insets API call due to signature change" into main 2025-05-08 20:42:57 -07:00
Ajinkya Chalke 0c32760b3c Use custom height for all apps for CD
Bug: 416220478
Flag: com.android.window.flags.enable_taskbar_connected_displays
Test: m
Change-Id: I772c43cec98e5a2679324603bee128482c614e26
2025-05-09 01:14:15 +00:00
Wen-Chien Wang e6816545b6 pin-shortcut: Check desktop state for the feature
This feature aims to work only for desktop mode. Add a check to
the desktop state when checking the aconfig feature flag.

Bug: 375648361
Test: EXEMPT flag update
Flag: com.android.window.flags.enable_pinning_app_with_context_menu
Change-Id: I19eb17d756f17892637bd303464748b505c89190
2025-05-09 00:31:27 +00:00
Andy Wickham a1e2662bc8 Start SurfaceFlinger early wakeup sooner for blur.
Now early wakeup is controlled by BaseDepthController (with the
exception of Taskbar which uses TaskbarOverlayController). It does
all of the following:
 - Increase GPU clock
 - Increase CPU clock (notifyRendererOfExpensiveFrame)
 - Tell SurfaceFlinger to wake up early

By default these happen the first time we render a non-0 blur, but
in some cases we can proactively activate it even earlier:
 - Swipe up to All Apps begins
 - Home screen QSB is tapped

These early cases were already handled for CPU and GPU, but now SF
is also in the loop.

In addition, SF early wakeup is disabled when Launcher is no longer
in the foreground.

Bug: 410973453
Test: Log manually to see early wakeup start/end
Flag: com.android.launcher3.all_apps_blur

Change-Id: I39ac0baf8c706b20f0818d31dbc8165b798ea54a
2025-05-08 16:52:28 -07:00