Commit Graph
17499 Commits
Author SHA1 Message Date
Will Leshner 531fc4985b Handle widget taps in WidgetPickerActivity.
Bug: 307306823
Test: atest Launcher3Tests
Flag: NA
Change-Id: I05cd42eae91447cfe99165096a735f6e04257203
2023-12-07 13:53:45 -08:00
Brian Isganitis 23ef0eda05 Merge "Remove types PIN_IME_POPUP and TASKBAR_ALL_APPS from TYPE_ACCESSIBILE." into main 2023-12-07 20:09:05 +00:00
William Leshner 5836cec7ec Merge "Show Launcher's widget picker in an activity." into main 2023-12-07 19:23:58 +00:00
Tony Wickham 1482ec384c Merge "Remove ENABLE_TRANSIENT_TASKBAR and long-press stash support" into main 2023-12-07 19:11:07 +00:00
Anna Zhuravleva 63d9cee7b8 Merge "Log taps on PS container buttons" into main 2023-12-07 09:56:10 +00:00
Brandon Dayauon b23612c2c0 Merge "Null check activityContext because the activityContext can be null when called from SearchDelegateView." into main 2023-12-06 23:23:42 +00:00
Federico Baron e3a6033704 Merge "Update widget picker two pane to support foldables" into main 2023-12-06 23:11:58 +00:00
Tony Wickham 18551f29fe Remove ENABLE_TRANSIENT_TASKBAR and long-press stash support
Flag: NA
Test: manual, TaplTestsTaskbar, TaplTestsPersistent, TaplTestsTransient
Fixes: 270395798
Change-Id: I4ecf5ddcd1206e846538175c684043c5e065fd5d
2023-12-06 22:13:10 +00:00
fbaron eee16c7ac5 Update widget picker two pane to support foldables
Bug: 301918659
Test: WidgetPickerImageTest
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT
Change-Id: I5beecf4f8c46235f3e89c7bd8aed65fd292883ce
2023-12-06 12:48:24 -08:00
Holly Jiuyu Sun a568183f55 Merge "[cleanup] Clean up LayoutType.PEOPLE_TILE." into main 2023-12-06 18:32:30 +00:00
Tony Wickham 5a26b1ce0f Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-12-06 18:06:44 +00:00
Brian Isganitis a2b3295892 Remove types PIN_IME_POPUP and TASKBAR_ALL_APPS from TYPE_ACCESSIBILE.
Users should be able to focus on content below the popup (i.e. the
search results). TYPE_ACCESSIBLE forces focus to only be on the
AbstractFloatingView.

Test: Talkback
Fix: 308361666
Flag: N/A
Change-Id: I84bb2680463b6294d463aa25f7a3bec8e676d660
2023-12-06 17:39:31 +00:00
Sebastián Franco 7ce518743a Merge "Moving startBinding and clearPendingBinds to ModelCallbacks" into main 2023-12-06 17:09:56 +00:00
Sunny Goyal 0d152a5bf6 Merge "Revert "Revert "Removing unnecessary iconFactory class when gene..."" into main 2023-12-06 16:11:43 +00:00
Will Leshner 9dce65e05a Show Launcher's widget picker in an activity.
Bug: 307306823
Test: atest Launcher3Tests
Flag: NA

Change-Id: I28ef731abcdf1bd44c66366d42a135912dbcc5be
2023-12-05 13:12:05 -08:00
Tony Wickham d546564f3e Change TAPL to swipe to stash taskbar (instead of deprecated long press)
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.

Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798

Change-Id: Ie7b8fcedb94e33742b7bf18cb829dab55af74b7d
2023-12-05 20:38:41 +00:00
Priyanka Advani f796ae1c2a Merge "Revert "Update isLauncherInitialized check to wait until Launcher has stopped binding items"" into main 2023-12-05 19:08:41 +00:00
Sebastian Franco e4965124ad Moving startBinding and clearPendingBinds to ModelCallbacks
Changes are part of go/launcher_SoR .

Flag: NA
Bug: 301108526
Test: This is a no-op change, compiling should be the test
Change-Id: I49eb6f88bb680c289f4e73cc108671b37b18fae7
2023-12-05 13:04:42 -06:00
Sebastián Franco 8d07e2f80a Merge "Adding ReorderParameters to ReorderAlgorithm" into main 2023-12-05 19:03:05 +00:00
Priyanka Advani 99d2b4827d Revert "Update isLauncherInitialized check to wait until Launcher has stopped binding items"
This reverts commit 7ab2c874c9.

Reason for revert: Likely culprit for b/311366267

Change-Id: I52a2c7527a90698866aef44217230ef7ae5064ee
2023-12-05 17:07:38 +00:00
Anna Zhuravleva 2ef6704e61 Log taps on PS container buttons
Log taps on space locked/unlocked, settings
buttons

PDD: https://eldar.corp.google.com/assessments/873128385/revisions/1

Test: logcat StatsLog, output
https://paste.googleplex.com/6250774946906112
Bug: 314933661
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space TEAMFOOD
Change-Id: I528443ba56a0db144ce613ea8d41426b6ede434d
2023-12-05 13:40:00 +00:00
Andreas Agvard 52b5113e8d Merge "Adds supportsCommitHaptic" into main 2023-12-05 12:48:15 +00:00
Satish Yalla b85266aef2 Merge "Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."" into main 2023-12-05 10:21:18 +00:00
Satish Yalla de82f8f44f Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."
Revert submission 25532044-tapl-transient-taskbar-default

Reason for revert: <test revert (b/314873201)>

Reverted changes: /q/submissionid:25532044-tapl-transient-taskbar-default

Change-Id: I51e78699f588a8fe8506c96398de921448e0ab6a
2023-12-05 06:48:25 +00:00
Tony Wickham 2f334e9ca7 Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-12-05 02:40:02 +00:00
Sukesh Ram ea6f544f7d Merge "Fix 3-Button Color w/ Widget Sheet post-Rotation" into main 2023-12-04 23:39:13 +00:00
Schneider Victor-tulias a74612611d Merge "Update isLauncherInitialized check to wait until Launcher has stopped binding items" into main 2023-12-04 20:02:10 +00:00
Holly Sun b226257c17 [cleanup] Clean up LayoutType.PEOPLE_TILE.
Bug: 313696037
Test: manual
Flag: LEGACY ENABLE_PEOPLE_TILE_PREVIEW DISABLED
Change-Id: Iae66c86357ef50a97083c79d6a94d038ad83dcf1
2023-12-04 11:14:00 -08:00
Sunny Goyal 3de59f24a0 Revert "Revert "Removing unnecessary iconFactory class when gene..."
Revert submission 25518508-revert-25483550-themed-badge-GJNKEECDMN

Reason for revert: Fixed badging bug

Reverted changes: /q/submissionid:25518508-revert-25483550-themed-badge-GJNKEECDMN

Change-Id: I0f378eaabcb7bdea855b80a33bdec007c9b11436
2023-12-04 18:53:50 +00:00
Pat Manning 5004d4dd3b Merge "Update focus indicator radius to match workspace drag indicator radius." into main 2023-12-04 11:06:00 +00:00
Sebastian Franco 25f8e406a7 Adding ReorderParameters to ReorderAlgorithm
No logic change made.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: Iababd2fba688a482cffe6d2243c987b0c022c6a5
2023-12-03 22:39:50 -06:00
Himanshu Gupta b6ebbb019c Fixing dangling PS container on profile addition.
When Work profile state is changed, the all apps container is redrawn
Eventually `PrivateProfileManager.reset()` is also called but PS decorator
is not added as there is no change in PS state.
https://photos.app.goo.gl/V2bmZWfzBzcRP97C8
To fix this, we allow decorator addition on reset, but only
apply the same when its not already present in the recycler view.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 313498792
Test: PrivateProfileManagerTest
Change-Id: I4c9a89d84e670ed45bf53a2d2e2c4922b165463e
2023-12-03 23:34:19 +00:00
Himanshu Gupta f63c645d8c Merge "Fixing work widgets tab in WidgetsFullSheet." into main 2023-12-03 23:33:42 +00:00
Himanshu Gupta c2a2b86e76 Fixing work widgets tab in WidgetsFullSheet.
Currently the work widget matcher matches against all
non-foreground user profiles, due to which the work
tab is incorrectly shown in widgets full screen, when
PS is present.
This was missed in ag/25129268 where a bunch of work
matcher fixes were done.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 312900122
Test: Launcher3 tests
Change-Id: I80d33e851ea3366dc3897bb1f5cc17fcd6b34520
2023-12-03 21:23:44 +00:00
Andreas Agvard 973c049fe0 Adds supportsCommitHaptic
Test: Manual
Bug: 314408519
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT ENABLED
Change-Id: Ia8f90489c2b8d82f6c63b4b363f9be5de6b2598b
2023-12-02 11:04:51 +01:00
Andreas Agvard 4b9a14cd8b Merge changes I9c92d3cb,I98e2dea9 into main
* changes:
  Increase slider for haptic hint iterations
  Enables ENABLE_SEARCH_HAPTIC_COMMIT
2023-12-02 08:55:57 +00:00
Sukesh Ram b8ddc944ff Fix 3-Button Color w/ Widget Sheet post-Rotation
Fixed issue where upon opening the widgets menu in the home screen in landscape, then rotating screen to portrait, then back to landscape (whilst keeping widget sheet open), the buttons are dim colored rather than white.

Flag: NONE
Test: Manually tested in pixel 7 in light mode and dark mode (with home screen rotation enabled).
Bug: 284801356
Change-Id: I0ed59373eb3af5f1b5ab695b43b850777042d2eb
2023-12-01 22:53:09 +00:00
Sebastián Franco b70b7fde7a Merge "Moving the remainder of reorder logic to ReorderAlgorithm" into main 2023-12-01 21:32:50 +00:00
Federico Baron 5f46067417 Merge "Fix flicker for widget picker" into main 2023-12-01 21:01:38 +00:00
Andreas Agvard fd7f192a0a Enables ENABLE_SEARCH_HAPTIC_COMMIT
ENABLE_SEARCH_HAPTIC_COMMIT should be enabled for now to keep consistency in
behavior.

Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT ENABLED
Bug: 314005577
Change-Id: I98e2dea91fe58b6abaeeb63f6c92a5ee130b5204
2023-12-01 21:16:14 +01:00
Andreas Agvard ffa44902d4 Merge "Adds support for shrinking nav handle on press" into main 2023-12-01 20:14:03 +00:00
fbaron eca18c0bd1 Fix flicker for widget picker
Fix: 312159033
Flag: NONE
Test: verified on device
Change-Id: I69e39c9041ff2d0a2ac3a6459a4c85c131a1b785
2023-12-01 10:52:39 -08:00
Sebastian Franco dcf6bf2311 Moving the remainder of reorder logic to ReorderAlgorithm
This is a no-op thoroughly tested by ReorderAlgorithmUnitTest.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I7203444df289cd3b67794fc570a2cd46e64549a2
2023-12-01 12:50:13 -06:00
Vadim Tryshev 6edb70f749 Merge "Waiting for Launcher to stop after quick-starting test apps" into main 2023-12-01 18:47:33 +00:00
Vadim Tryshev 0ad6d9bcee Waiting for Launcher to stop after quick-starting test apps
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I795571ec191b01929bb871fd021d8653449bb608
2023-12-01 18:22:04 +00:00
Sebastián Franco f601447877 Merge "Moving bindAppsAdded and setIsFirstPagePinnedItemEnabled to ModelCallbacks" into main 2023-12-01 17:58:11 +00:00
Andreas Agvard 1ea0746e1c Adds support for shrinking nav handle on press
Fix: 314158312
Flag: LEGACY SHRINK_NAV_HANDLE_ON_PRESS DISABLED
Test: Manual

Change-Id: Icd46467939ae9a38592ee67ee0d2a521eb8e0b6c
2023-12-01 17:54:41 +01:00
Pat Manning e06a23ed29 Update focus indicator radius to match workspace drag indicator radius.
Also decouple focus indicator radius from ENABLE_DEVICE_SEARCH feature flag, as it is used on home screen as well as all apps.

Bug: 313665319
Test: Manual.
Flag: N/A.
Change-Id: I629c1180b1b1b6797e2c3ba6ca13da04e8fa392b
2023-12-01 14:24:05 +00:00
Treehugger Robot 0cfbca60ab Merge "Move logic only used on the reorder from the cellLayout to ReorderAlgorithm" into main 2023-12-01 00:57:37 +00:00
Sunny Goyal 6f04a32b21 Merge "Revert "Removing unnecessary iconFactory class when generating b..."" into main 2023-11-30 23:55:59 +00:00