Commit Graph
18735 Commits
Author SHA1 Message Date
Sunny Goyal 4f9ba255a4 Cleaning up some enabled features
Bug: 270394468
Bug: 270393900
Bug: 270390907
Bug: 270390930
Bug: 270390937
Bug: 270391693
Bug: 270391638
Bug: 270395177
Bug: 270395269
Flag: EXEMPT legacy flags cleanup
        ENABLE_SHOW_KEYBOARD_OPTION_IN_ALL_APPS
        ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
        ENABLE_DEVICE_SEARCH
        ENABLE_HIDE_HEADER
        ENABLE_TWOLINE_ALLAPPS
        IME_STICKY_SNACKBAR_EDU
        FOLDER_NAME_MAJORITY_RANKING
        SCROLL_TOP_TO_RESET
        ENABLE_SEARCH_UNINSTALLED_APPS
        ENABLE_HOME_TRANSITION_LISTENER

Test: Presubmit
Change-Id: Ia392c10fc65616405cc4d4a2b8ed566e3bb7d386
2024-09-13 14:24:27 -07:00
Anushree Ganjam b41def0366 Merge "Add LauncherAppSingleton & LauncherActivityScope to dagger graph (3/n)" into main 2024-09-13 00:45:28 +00:00
Sunny Goyal 5ee3d98641 Cleaning up some enabled features
Flag: EXEMPT LEGACY
		CONTINUOUS_VIEW_TREE_CAPTURE
		ALL_APPS_GONE_VISIBILITY
		ENABLE_BACK_SWIPE_HOME_ANIMATION
		ENABLE_DYNAMIC_TASKBAR_THRESHOLDS
		PREEMPTIVE_UNFOLD_ANIMATION_START
		ENABLE_NEW_GESTURE_NAV_TUTORIAL
		ENABLE_ENFORCED_ROUNDED_CORNERS
		ENABLE_TRACKPAD_GESTURE
		ENABLE_KEYBOARD_QUICK_SWITCH
		ENABLE_KEYBOARD_TASKBAR_TOGGLE
		ENABLE_ALL_APPS_RV_PREINFLATION
Test: Presubmit
Bug: 270395171, 291651514, 270393426, 294252473,
     270397209, 270396257, 270393258, 271010401,
     270396844, 281726846, 288161355

Change-Id: I6ef1e12dfc2203a4cca8e91aa291485f1ff24c42
2024-09-12 15:12:08 -07:00
Treehugger Robot f60ebdfa9d Merge "Add logs for 4x4 to 4x5 missing row bug" into main 2024-09-12 06:34:37 +00:00
Treehugger Robot 206e15b286 Merge "Move DesktopVisibilityController to TouchInteractionService" into main 2024-09-12 02:32:00 +00:00
fbaron 3c4c975d74 Add logs for 4x4 to 4x5 missing row bug
Flag: EXEMPT adding logs
Test: EXEMPT adding logs
Bug: 360462379
Change-Id: Icb56209a4a12c935dd97bd01d53b8fb6e4371c34
2024-09-11 15:52:01 -07:00
Anushree Ganjam fbc0f97410 Add LauncherAppSingleton & LauncherActivityScope to dagger graph (3/n)
* Add ApplicationContext qualifier and binding the application context instance so
that this context is available across dagger graph.

* Add QuickStepModule and LoggingModule
* Provide SettingsChangeLogger in dagger way. We are depending on
  MainThreadInitializedObject for cleanup. We need to define a way
  explicitly see how we can destroy singleton objects.

Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration
Change-Id: Ia10cc500edb1d88adcca540119651f59b9bc8dc8
2024-09-11 13:56:23 -07:00
Sunny Goyal 8f8932b0f8 Merge "Adding open/close animartion when launching app-info target" into main 2024-09-11 20:31:34 +00:00
Schneider Victor-Tulias 2b46c945a7 Move DesktopVisibilityController to TouchInteractionService
Moved DesktopVisibilityController to TIS for 3P launcher support.

Flag: EXEMPT bug fix
Fixes: 338063030
Fixes: 357859025
Test: Launched overview and resumed desktop task from desktop mode on 1P and 3P launchers
Change-Id: I64e99a32ed13bcb6e4a81a18c29df2643373dc35
2024-09-11 09:56:35 -07:00
Sunny Goyal 65342edc89 Removing obsolete flags
Flag: EXEMPT legacy ENABLE_PARAMETRIZE_REORDER, KEYGUARD_ANIMATION, ENABLE_SCRIM_FOR_APP_LAUNCH
Bug: 289420844
Bug: 270390904
Bug: 270393276
Test: Verified manually
Change-Id: I0eb166168100419fdf4d264f7ccddeeba86524b7
2024-09-10 21:24:47 +00:00
Sunny Goyal cb98fb26b8 Adding open/close animartion when launching app-info target
Bug: 356914468
Test: Verified manually
Flag: EXEMPT bugfix
Change-Id: I3a4e48363728153a96c75466824fb03de44c0ad9
2024-09-10 13:35:46 -07:00
Fengjiang Li 97db09dbd8 Merge "[-1] Show toast when user trys to swipe to -1 on extreme battery saver mode" into main 2024-09-10 16:41:21 +00:00
Treehugger Robot a926663c46 Merge "Removing obsolete flags" into main 2024-09-10 09:25:51 +00:00
Sunny Goyal b60b5bd594 Merge "Adding more properties in LaunchCookie, instead of just itemId This allows better matching of items who do not have a fixed id" into main 2024-09-10 07:33:41 +00:00
Fengjiang Li a7e357e339 [-1] Show toast when user trys to swipe to -1 on extreme battery saver mode
Fix: 355485335
Flag: com.android.launcher3.use_activity_overlay
Test: manual - record a video
Change-Id: I79a3ece2fb2c0d1eddac0e4f91274ffe222e317f
2024-09-09 19:06:17 -07:00
Sunny Goyal f2e2532e62 Merge "Remove obsolete features" into main 2024-09-09 22:43:14 +00:00
Sunny Goyal f158286c34 Adding more properties in LaunchCookie, instead of just itemId
This allows better matching of items who do not have a fixed id

Bug: 364363493
Flag: EXEMPT bug fix
Test: Manual- Verified app launch and back animation
Change-Id: I4f9deba89399b89974686b64226b99f91a3d46be
2024-09-09 12:11:36 -07:00
Treehugger Robot 359fb55a26 Merge "Send message to launcher renderer to update grid (3/3)" into main 2024-09-05 21:45:44 +00:00
George Lin de4d7457a8 Send message to launcher renderer to update grid (3/3)
This CL supports external surface view callbacks to send messages to
update the launcher's preview grid.

Bug: 348664593
Test: Manually tested. See bug.
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: I8108ae2c49af6b4fc1a207c6ece23e82616baa61
2024-09-05 16:49:15 +00:00
Treehugger Robot 40de6c4c12 Merge "Fix Overview crash with 3 button navigation when animation is disabled" into main 2024-09-05 16:41:00 +00:00
Jordan Silva 64ad4e34ab Fix Overview crash with 3 button navigation when animation is disabled
The OverviewCommandHelper conversion to kotlin introduced a bug when using 3-button-navigation to go to Overview when the animation is disabled. A NullPointerException happens in the AnimatorListenerAdapter implementation in OverviewCommandHelper when StateManager.goToState calls onAnimationEnd providing a null argument to a function that shouldn't allow a null value.

The abstract class AnimatorListenerAdapter implements AnimatorListener functions containing @NonNull Animator. However, AnimatorListenerAdapter overrides the interface functions without adding a @NonNull annotation in the arguments. In Java, this is allowed, causing only a warning. In Kotlin, due to the null safety nature, the compiler forces a null check for nullable types and doesn't allow the implementation of a @NonNull argument to become nullable.

To fix this issue we created a empty AnimatorSet to provide to onAnimationEnd instead of null.

For more context when @NonNull was added:
- The @NonNull annotation was added to fix b/206801689, however it was never updated for AnimatorListenerAdapterImproved Commit Message

Fix: 364860731
Bug: 352046797
Flag: EXEMPT bugfix
Test: Manual. Instructions in the bug.
Change-Id: I120af3d75e614581d6ac0f867a8c6f9419ee1bd3
2024-09-05 15:19:32 +01:00
Treehugger Robot 9982cf96d0 Merge "Fixing UI leaks when using inline-subclass" into main 2024-09-05 00:21:36 +00:00
Sunny Goyal 46d2cc6edf Fixing UI leaks when using inline-subclass
Bug: 364363493
Flag: EXEMPT bug fix
Test: Presubmit
Change-Id: I8881569b021ab3737130d6d07ff3383dfab8df35
2024-09-04 20:47:14 +00:00
Marcelo Arteiro 13d9588f88 Merge "Updates many launcher color to new dynamic tokens" into main 2024-09-04 11:27:16 +00:00
Sebastián Franco 6d508c702a Merge "Remove event signaling logic from Launcher to the tests" into main 2024-09-03 20:43:55 +00:00
Sebastian Franco 899656a2a7 Remove event signaling logic from Launcher to the tests
Instead of throwing the event on the Launcher, now the test listens
to changes in the view tree and when the condition is meet it stops the
waiter.

Bug: 352569050
Bug: 324261526
Test: IntegrationReorderWidgetsTest
Flag: TEST_ONLY
Change-Id: I94596429cb79af6b298281bd5cd4558e919736e2
2024-08-30 22:46:45 +00:00
Schneider Victor-tulias a4ce092bea Merge "Add a test base for AbsSwipeUpHandler and its subclasses" into main 2024-08-30 20:48:09 +00:00
Sunny Goyal 7a548377eb Remove obsolete features
Flag: EXEMPT legacy ENABLE_TWOLINE_DEVICESEARCH, ENABLE_ICON_IN_TEXT_HEADER, ENABLE_PREMIUM_HAPTICS_ALL_APPS
Bug: 270396358
Bug: 201388851
Bug: 270395143
Test: Verified manually
Change-Id: I88ca7b255d2ae4eba393c1aee52153ef0a459140
2024-08-30 13:04:08 -07:00
Sunny Goyal 35dc8758fb Removing obsolete flags
Flag: EXEMPT legacy ENABLE_ALL_APPS_FROM_OVERVIEW and ENABLE_MULTI_DISPLAY_PARTIAL_DEPTH
Test: Verified manually
Bug: 270395073
Bug: 275132633
Change-Id: Ifa1db64dc037183faaef9e014d7c56275d61ed60
2024-08-30 12:34:55 -07:00
Schneider Victor-tulias f5035847b1 Add a test base for AbsSwipeUpHandler and its subclasses
- Added a few basic tests for scenarios that should be contant across subclasses. These tests will not run on their own, they will only run when a subclass' test suite is run.
- Added test suites for LauncherSwipeHandlerV2 and FallbackSwipeHandler

Flag: EXEMPT adding tests
Bug: 353763639
Test: LauncherSwipeHandlerV2Test, FallbackSwipeHandlerTest
Change-Id: Ib44199f5d5281a544b433649d6ed49ae2a65ed70
2024-08-30 14:14:03 -04:00
Sebastián Franco f24aea0f64 Merge "Add waiting to test to wait for the Workspace to be in Edit mode" into main 2024-08-30 17:31:15 +00:00
Winson Chung 380f11e9d5 Merge "5/ Remove unused recents code" into main 2024-08-30 03:00:49 +00:00
Treehugger Robot 5cfb887b68 Merge "Fix bug where PredictedIcon circle/dot flicker." into main 2024-08-30 01:02:19 +00:00
Winson Chung d159e61166 5/ Remove unused recents code
- The shell transit flag is already hardcoded to true in Launcher
  so we can remove the non-shell transit paths
- The minimized split was from legacy splitscreen where launcher would
  show in a minimized state, which is no longer the case

Flag: EXEMPT bugfix
Bug: 359608026
Test: atest NexusLauncherTests
Change-Id: Idea46fc065485233b9e508dae3ebc4ee87c29ba6
Signed-off-by: Winson Chung <winsonc@google.com>
2024-08-29 23:17:23 +00:00
Mark Fasheh 4baa30d151 Update launcher cold startup trace
Bug: 341061764
Flag: EXEMPT bugfix
Test: Boot phone, take trace
Change-Id: I29b5be5525206ac83bc36596395a1f71b43715c6
2024-08-29 00:03:00 +00:00
Anushree Ganjam 7310809645 Merge "Setup Dagger for Launcher (1/n)" into main 2024-08-28 23:38:33 +00:00
Sebastian Franco ef0b042f5c Add waiting to test to wait for the Workspace to be in Edit mode
I thought I wouldn't need to wait for the Edit mode to start but
sometimes the test goes too fast and drops the item before we get
to the edit mode and the drop doesn't have the correct coordinates
or get's cancelled.

Fix: 352569050
Test: IntegrationReorderWidgetsTest
Flag: TEST_ONLY
Change-Id: I744579c28267189f85b9ca297e1d170d6120bb64
2024-08-28 22:06:36 +00:00
Anushree Ganjam bd8633133f Setup Dagger for Launcher (1/n)
Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration
Change-Id: Idbe19f1aa747f519417e21fe8a23a41c52ececc1
2024-08-28 12:11:47 -07:00
Jon Miranda 9bcdb1cbe9 Fix bug where PredictedIcon circle/dot flicker.
The issue is that the PredictedIcon in the Taskbar would draw
right before we swap to the matching icon in the Hotseat.

Fixes: 362677520
Test: launch predicted app icon from hotseat, swipe to go home
Flag: EXEMPT bugfix
Change-Id: Iab8b707edf846b257c7fb7cacc9008e5c66353a7
2024-08-28 08:35:14 -07:00
Charlie Anderson 5e319c2a11 Merge "Add logging for onPackageAdded callback to see if installed packages are added to Launcher." into main 2024-08-28 11:23:09 +00:00
Sunny Goyal 3aa9668bef Merge "Cleanup unused workspacePageIndicator" into main 2024-08-27 23:03:20 +00:00
Sunny Goyal 42becd041b Cleanup unused workspacePageIndicator
Fix: 270395278
Flag: NONE removing dead code
Test: verify everything still works the same
Change-Id: Id0eda5c5994c3323a8d16900678fbd7b39911b62
2024-08-27 12:23:21 -07:00
Charlie Anderson 70ac7a055e Add logging for onPackageAdded callback to see if installed packages are added to Launcher.
Bug: 350144057
Flag: NONE just logs
Test: locally
Change-Id: Iba08aea3e370ce1a992f3d680790470d9ab193fd
2024-08-27 13:38:23 -04:00
Sebastián Franco dd981d78b5 Merge "Adding logs to find which call is responsible for the animation error" into main 2024-08-27 16:28:09 +00:00
Sebastian Franco 7f9518145a Adding logs to find which call is responsible for the animation error
Bug: 311077782
Test: not aplicable
FLag: EXEMPT bugfix
Change-Id: I2d5a28a8244819a795402fdcf599009ad1abd0dc
2024-08-26 17:08:01 -07:00
Charlie Anderson e745aa87fc Add logging around InstallSessionTracker to verify PackageInstaller is communicating with Launcher.
Bug: 350144057
Flag: NONE just logs
Test: Locally
Change-Id: I600cac50d7202458abf968fc0707eba58ffc0e65
2024-08-26 19:15:58 -04:00
Brandon Dayauon 412821fadf Merge "Create an alpha letter scroller" into main 2024-08-26 20:21:17 +00:00
Brandon Dayauon 1f8f88696b Create an alpha letter scroller
- The function used is a raised cosine function to determine the sections to animate.

Tested flag: adb shell device_config put launcher com.android.launcher3.letter_fast_scroller true
Based on recent figmaspec, size of selected letter is 28dp and regular is 20dp. That means scaling should be 28/20.
Colors are:
onSurface for letter
surfaceContainer for background.
Figma shows selected colors are materialColorOnSecondary

bug:358673724
Test manually: https://drive.google.com/file/d/1gvJd5KoK8X_Sv8jXg1cZ65R4AuqHuvcd/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller

Change-Id: Ia86eb0e8c41bc043fda3c44aeaf59e204429f337
2024-08-26 11:21:26 -07:00
Charlie Anderson 4c159412de Use bugfix flag for archived broadcast extras
Bug: 322314760
Test: locally
Flag: com.android.launcher3.enable_first_screen_broadcast_archiving_extras
Change-Id: I9e3944d35a1cf2a17d1b5fcbf249ecf488265a93
2024-08-23 18:08:15 +00:00
Charlie Anderson cbbba7609c Merge "Fix cropped pre-archived app icons by converting to a fixed Adaptive Icon" into main 2024-08-23 14:22:56 +00:00