Commit Graph
60459 Commits
Author SHA1 Message Date
Pierre Barbier de Reuille d1bde5e6f3 Merge "Stop trying to draw a view not attached to the view tree" into sc-dev 2021-04-07 20:40:10 +00:00
Alex Johnston a538ffe2a4 resolve merge conflicts of 8786016e85 to rvc-qpr-dev
Bug: 168802517
Change-Id: I84db4b2328ecdd40991f661f23f635f4dd1a42ab
Merged-In: I3e6ba1d8645335785e8e26cdc895ea9c0017a0fd
2021-04-07 18:01:43 +00:00
Alex Johnston 18217e7f94 Block recent work profile apps content capture am: 8786016e85
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13989187

Change-Id: I0e39d019e358dd8e0016927a9c9b50717cf6eb93
2021-04-07 17:00:40 +00:00
Samuel Fufa 9245773737 [Search] Update specs per UX
- Moves search related resources go NexusLauncher

Test: Visual
Bug: 184369338
Change-Id: Ic466395192d1fd891aeebec93b491d453edf84aa
2021-04-07 11:54:34 -05:00
Pierre Barbier de Reuille ad41a56166 Stop trying to draw a view not attached to the view tree
The behavior of the framework when we try to do so is undefined. In our
case, it almost work, but no clipping is applied, which is a problem for
Android S (before that, widget couldn't use clipping in the first
place).

Instead of drawing the view through a drawable, this really add the view
and adds also a badge ImageView for badges instead of drawing them
indirectly.

Note that, temporarily, we have to re-allow drawing the view after it
has been attached, but the underlying framework bug being fixed, this
should be fine (I tested it and it really seems to be).

Bug: 183609936
Test: Using hand designed app (see bug)
Change-Id: I929ef8fc81c98c49406f2d940cd5efc28319886d
2021-04-07 15:51:43 +01:00
android-build-team Robot c865e3a825 Snap for 7263567 from 327d9b89c2 to tm-release
Change-Id: Ib62ef2f69482861618827e330d355cc2e453e568
2021-04-07 03:07:33 +00:00
android-build-team Robot 939bb2cab4 Snap for 7263361 from 4f7d8fc3fb to sc-v2-release
Change-Id: I39ed030995c4189cbe77f279378f61ac61454c2e
2021-04-07 01:08:45 +00:00
android-build-team Robot f2ee2a093d Snap for 7263361 from 4f7d8fc3fb to sc-release
Change-Id: I65e01da8d73c3e9b8f13f67f56fa18ac5f4128ff
2021-04-07 01:08:08 +00:00
Schneider Victor-tulias c33ca110e1 Merge "Add logging for adding pending icons to the workspace." into sc-dev am: adfbdcf8fe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13989020

Change-Id: I891e54b0af9b4e4611ddbaa284652d373344cc5c
2021-04-07 00:32:28 +00:00
Schneider Victor-tulias e06877601f Merge "Add logging for adding pending icons to the workspace." into sc-dev am: adfbdcf8fe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13989020

Change-Id: Id2f2375d270db285909645f12255ca4a51337ee9
2021-04-07 00:32:19 +00:00
Schneider Victor-tulias adfbdcf8fe Merge "Add logging for adding pending icons to the workspace." into sc-dev 2021-04-06 23:45:53 +00:00
TreeHugger Robot 327d9b89c2 Merge "Simplifying widget search pipeline" into sc-dev am: 47fe0d14f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14040011

Change-Id: I5d6e5d00012985e64b9d7065f5f222db0014baba
2021-04-06 23:28:16 +00:00
TreeHugger Robot 27bdd56e9d Merge "Simplifying widget search pipeline" into sc-dev am: 47fe0d14f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14040011

Change-Id: Ic6c462b48b0002199a8a851e4f6382fe25f16dba
2021-04-06 23:27:35 +00:00
TreeHugger Robot 47fe0d14f0 Merge "Simplifying widget search pipeline" into sc-dev 2021-04-06 23:12:32 +00:00
Samuel Fufa f73fc80718 Merge "[Search] make AbstractSlideinView#createColorScrim overridable" into sc-dev am: 4f7d8fc3fb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14101075

Change-Id: I3e9ca28c14f370b7a0661223ab6467f5234dd583
2021-04-06 23:07:05 +00:00
Samuel Fufa 035567f641 Merge "[Search] make AbstractSlideinView#createColorScrim overridable" into sc-dev am: 4f7d8fc3fb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14101075

Change-Id: I44fd7b791c47dacba64c61ad5423a4e5bea9b951
2021-04-06 23:06:37 +00:00
Sunny Goyal c82916fecb Some cleanup in RecentsView
> Merging overview and all-apps scrims into a single View
> Decoupling TaskMenuView from taskView

Bug: 184676497
Test: Manual

Change-Id: I49f7249eaa2a800054385ab8e73a441d6a1b5e16
2021-04-06 15:47:33 -07:00
Samuel Fufa 4f7d8fc3fb Merge "[Search] make AbstractSlideinView#createColorScrim overridable" into sc-dev 2021-04-06 22:36:28 +00:00
Winson Chung 28a0ba13f2 Merge "Fix noisy log from sysui flag changes" into sc-dev am: 7cf7c31e46
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14098021

Change-Id: I0e0d167ed4a6e1dd79a632cfae41428c3bad1654
2021-04-06 22:26:36 +00:00
Winson Chung fc540e8be1 Merge "Fix noisy log from sysui flag changes" into sc-dev am: 7cf7c31e46
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14098021

Change-Id: I67ff6c8c39d6ba579e7b3c7186ebde4f92950a39
2021-04-06 22:23:43 +00:00
Tony Wickham 61d9edf810 Merge "Consolidate two different onTransitionCancelled implementations" into sc-dev am: 029e930751
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14103181

Change-Id: I2c383f800a4904741103095ea2ab8c805764453a
2021-04-06 22:23:43 +00:00
Tony Wickham 0fa98f86fb Merge "Consolidate two different onTransitionCancelled implementations" into sc-dev am: 029e930751
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14103181

Change-Id: I6d871e1715644325455c5e6a4a635c17ca21d44e
2021-04-06 22:23:37 +00:00
Winson Chung 7cf7c31e46 Merge "Fix noisy log from sysui flag changes" into sc-dev 2021-04-06 21:48:43 +00:00
Tony Wickham 029e930751 Merge "Consolidate two different onTransitionCancelled implementations" into sc-dev 2021-04-06 21:44:53 +00:00
TreeHugger Robot 3ac5f45e05 Merge "Fix HINT_STATE not tracking the entire height of the screen" into sc-dev am: c07ad47255
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14104581

Change-Id: I3ee661bee2a263d078217035f4e1cce35e1d2572
2021-04-06 21:30:24 +00:00
TreeHugger Robot e3f96639fc Merge "Fix HINT_STATE not tracking the entire height of the screen" into sc-dev am: c07ad47255
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14104581

Change-Id: Idee949dd793e04b5b9416e52ba00151ac0281e56
2021-04-06 21:30:10 +00:00
TreeHugger Robot c07ad47255 Merge "Fix HINT_STATE not tracking the entire height of the screen" into sc-dev 2021-04-06 20:58:26 +00:00
Tony Wickham b6a26a846f Merge "Explicitly set which taskbar view is visible at each caller" into sc-dev am: fc3bc6098f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14094841

Change-Id: I728494cd1a8ae4c63be04c5d7d317d021c247bc5
2021-04-06 20:37:27 +00:00
Tony Wickham d6d2cda7e0 Merge "Ensure taskbar animation ends when running window animation does" into sc-dev am: 0b0c173ec0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096849

Change-Id: I341b7ec1f47002be7090c4e38548ee33cf4d8377
2021-04-06 20:37:04 +00:00
Tony Wickham 655bf5ade9 Merge "Explicitly set which taskbar view is visible at each caller" into sc-dev am: fc3bc6098f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14094841

Change-Id: I216a2a826d6d6d2ddc1c2bfebf4e764bd43d2981
2021-04-06 20:34:02 +00:00
Tony Wickham d054d06099 Merge "Ensure taskbar animation ends when running window animation does" into sc-dev am: 0b0c173ec0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096849

Change-Id: Icf9a904ddc34a8a474fdaad94de9b247ce16f3c5
2021-04-06 20:32:24 +00:00
Tony Wickham fc3bc6098f Merge "Explicitly set which taskbar view is visible at each caller" into sc-dev 2021-04-06 19:37:18 +00:00
Tony Wickham 0b0c173ec0 Merge "Ensure taskbar animation ends when running window animation does" into sc-dev 2021-04-06 19:35:38 +00:00
Tony Wickham b77fa8da52 Consolidate two different onTransitionCancelled implementations
There was previously two different onTransitionCancelled(), one in
BaseActivityInterface and one in AnimationFactory. They are pretty
similar and the differences seem subtle and not necessary. In this
bug, the AnimationFactory version was going to mStartState instead
of StateManager#getRestState() (which is the same, unless mStartState
disables restore). Instead, always use the mActivityInterface
implemenation, which seems more robust.

Test: Open app A, open app B, quick switch from B to A, swipe home
during that transition, then touch nav region during home transtion;
ensure we don't goToState(BACKGROUND_APP) in the subsequent
onTransitionCanceled().

Fixes: 184583037

Change-Id: I315a5087b12413d88c3ccc1e3245a55a76a73e62
2021-04-06 12:16:00 -07:00
Schneider Victor-tulias bf694d61ee Add logging for adding pending icons to the workspace.
Added logging to help track down b/168788486

Bug: 168788486

Test: manual
Change-Id: I96b38be7c02793f1b6649e6c0de5cdf47dca6edb
2021-04-06 12:10:50 -07:00
Tony Wickham 721a89d93a Merge "Cleanup taskbar touchableInsets" into sc-dev am: c9846dc6e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096731

Change-Id: I5331b56137d960f1d5eea3622e8255bcf5f64937
2021-04-06 19:08:24 +00:00
Tony Wickham c9e3603fdd Merge "Cleanup taskbar touchableInsets" into sc-dev am: c9846dc6e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096731

Change-Id: I6b32230933601805941ac13f6a63379cfe26d787
2021-04-06 19:07:29 +00:00
Tony Wickham c9846dc6e7 Merge "Cleanup taskbar touchableInsets" into sc-dev 2021-04-06 18:36:05 +00:00
Samuel Fufa 06702c00b9 Merge "[Search][Layout] Fix blank space when predictions are disabled" into sc-dev am: 50c6a37ea9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14102304

Change-Id: I7e4b49d72b7d4fadacaeba5a372b0305908c34aa
2021-04-06 17:57:57 +00:00
Zak Cohen be66b43c9f Merge "Overview - update Clear All and Empty message drawing" into sc-dev am: fd9af2f017
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096074

Change-Id: I8cef2fa1301f7faa0e70a12978da3724aaa7397d
2021-04-06 17:57:52 +00:00
Samuel Fufa af45168c58 Merge "[Search][Layout] Fix blank space when predictions are disabled" into sc-dev am: 50c6a37ea9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14102304

Change-Id: Ibe1b37e7e2f2d998f8a5c0464986e397efbe598d
2021-04-06 17:57:39 +00:00
Zak Cohen 19c6a15527 Merge "Overview - update Clear All and Empty message drawing" into sc-dev am: fd9af2f017
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096074

Change-Id: I157405a0932d036f3a41e0dfdae32c5c0bd44918
2021-04-06 17:57:03 +00:00
Samuel Fufa 50c6a37ea9 Merge "[Search][Layout] Fix blank space when predictions are disabled" into sc-dev 2021-04-06 17:56:51 +00:00
Zak Cohen fd9af2f017 Merge "Overview - update Clear All and Empty message drawing" into sc-dev 2021-04-06 17:42:05 +00:00
TreeHugger Robot 46099a47e0 Merge "Update device padding to allocate more space to workspaceBottomPAdding." into sc-dev am: d69407c02e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14095430

Change-Id: Iec72085cd15f466fcd7e2ffe7e1f0a40e7f5c816
2021-04-06 17:36:26 +00:00
TreeHugger Robot cc31edfcda Merge "Update device padding to allocate more space to workspaceBottomPAdding." into sc-dev am: d69407c02e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14095430

Change-Id: I1225c0bade3637c5f5ba01e89f7fe12bcf3e21e3
2021-04-06 17:36:03 +00:00
Tony Wickham fbdb50aa48 Fix HINT_STATE not tracking the entire height of the screen
Explicitly use DeviceProfile#heightPx instead of getShiftRange(),
which might be less depending on AllAppsTransitionController

Test: swipe up from bottom on home, ensure workspace scales down
as the gesture goes all the way to the top of the screen

Change-Id: I9c2988d361c22d437c7eb9bea8ed715d06054c59
2021-04-06 10:09:44 -07:00
TreeHugger Robot d69407c02e Merge "Update device padding to allocate more space to workspaceBottomPAdding." into sc-dev 2021-04-06 16:55:33 +00:00
Samuel Fufa 5461089baa [Search][Layout] Fix blank space when predictions are disabled
This regression is caused due to getExpectedHeight relying on view visibility state while AlphaUpdateListener.updateVisibility was reseting the views visibility.

Bug: 184211402
Test: local
Change-Id: Ib756f5eb8f6356a18a025626008b97fd7c77fec9
2021-04-06 04:05:20 -05:00
Samuel Fufa ac120c9a47 [Search] make AbstractSlideinView#createColorScrim overridable
+ Introduce feature flag for people tile results

Bug: 183972880
Bug: 184003600
Test: Manual
Change-Id: Ia8b3af4e99a66f640f6f42fc5886d9cbfb5e913c
2021-04-06 03:18:07 -05:00