Commit Graph
1314 Commits
Author SHA1 Message Date
Stefan Andonian aa03be3a16 Merge "Migrate IDP_GRID_NAME usage to LauncherPrefs" into tm-qpr-dev am: 3788da6285 am: 844dc76a25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21359246

Change-Id: I77d01b752d13a823b6d41db0b52e62ef46985675
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 19:40:23 +00:00
Stefan Andonian 3788da6285 Merge "Migrate IDP_GRID_NAME usage to LauncherPrefs" into tm-qpr-dev 2023-02-15 18:58:41 +00:00
Stefan Andonian 05ca3a8089 Refactor Workspace Loading / Processing code.
There are no behavioral changes (other than we no longer are recycling
objects while processing workspace items), but this refactor will setup
the next change to load the first workspace page before other workspace
pages.

Bug: 251502424
Test: Workspace, app widgets, and containers loaded properly.
Change-Id: I437aab40000d841d7fcc4380d05ab4a8f5d5c2ad
2023-02-15 17:36:27 +00:00
Thales Lima 0eaaddc6c9 Merge "Create a DeviceProfileDumpTest for nonquickstep" into tm-qpr-dev am: 0af71f85dd am: 42c28e7bfe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20960103

Change-Id: I52af02a531bd19141e29e2945ac960018ad5773f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 11:05:59 +00:00
Thales Lima 0af71f85dd Merge "Create a DeviceProfileDumpTest for nonquickstep" into tm-qpr-dev 2023-02-15 09:46:11 +00:00
Stefan Andonian 6f9a57186c Migrate IDP_GRID_NAME usage to LauncherPrefs
Bug: 251502424
Test: Grid functionality still worked just fine on device when I tested
it locally.

Change-Id: I23676572637f194e1f739e4b39159311870abc32
2023-02-15 06:01:47 +00:00
Sunny Goyal 892fab2c14 Using DiffUtil for calculating widget diff instead
of a custom implementation

This uses the same version as all-apps and avoids whole list refresh
when a widget entry is expanded for the first time

Removing tests which were essentially testing the diffing logic

Bug: 268646258
Test: Verified on device
Change-Id: I4799c66b4674e754547317317e7a63f098fce735
2023-02-14 20:59:29 +00:00
Sunny Goyal 591a128e57 Merge "Moving widget background to xml, so that the same constantstate is used for all entries" into tm-qpr-dev am: a75105ef03 am: 67e1e03913
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21381944

Change-Id: Icde51114b8f5655ea516b0ea8233c5f6734d2997
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-13 19:32:50 +00:00
Sebastian Franco 81b82720de Making ReorderWidget test more reliable
In some cases when starting to drag you can go to the next
CellLayout wich end in an error. Now the dragging functions
will move the item to the desired CellLayout no matter what
CellLayout you start in.

Fix: 266116487
Test: atest ReorderWidgets
Change-Id: Ie3ad2ff88f734856e2c66d5d51b7578482877b5a
2023-02-13 11:02:09 -08:00
Thales Lima 69166dd054 Create a DeviceProfileDumpTest for nonquickstep
This makes sure we are still testing non scalable grids as well

Bug: 241386436
Test: DeviceProfileDumpTest
Change-Id: I06b442cf1052a952ee834f98c5005ea8e950c2f0
2023-02-13 17:31:13 +00:00
Sunny Goyal 77e732a1c4 Moving widget background to xml, so that the same constantstate is
used for all entries

This helps reduce launcher memory by avoiding multuple duplicate
drawable generation

Bug: 268646258
Test: Verified on device
Change-Id: I829750f081cfce65063b35a614b903066d9a4bed
2023-02-13 05:49:31 +00:00
Sunny Goyal 71aa5d815b Merge "Removing unnecessary search header duplication" into tm-qpr-dev am: 290998522c am: 6f2c09f066
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21372949

Change-Id: Ic5fcaa632e2c1aa14d348e143fbf9dde886f4abe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-11 01:01:15 +00:00
Sunny Goyal 62a4932310 Removing unnecessary search header duplication
Bug: 268646258
Test: Verified on device
Change-Id: I33a7df6a523e5600dc6251c3d8feff1236362705
2023-02-10 11:26:05 -08:00
Federico Baron df7066b782 Merge "Implement two pane widget picker" into tm-qpr-dev am: 740541e0a0 am: d36fa5e631
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20508230

Change-Id: I65049b8bb98e845c705e92e33e56a7b8955e3f79
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-10 18:43:59 +00:00
Federico Baron 740541e0a0 Merge "Implement two pane widget picker" into tm-qpr-dev 2023-02-10 17:20:55 +00:00
Brandon Dayauon 1507785a36 Merge "Method to override feature flag" into tm-qpr-dev am: fb9c4d25c4 am: ebd8065f19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21306841

Change-Id: I6b442087c14ef91f3283c00fb85fd8d72a55aa27
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-10 00:41:39 +00:00
Federico Baron 4b1a38bb7d Implement two pane widget picker
The widget picker design is currently not optimized for large screen form factor devices.
We resolve that by adding a two pane widget picker like that of the design in go/widget-picker-2023.

Bug: 256684299
Test: Make sure to be on a tablet in landscape mode.
        1.Turn on flag LARGE_SCREEN_WIDGET_PICKER.
        2. Press and hold on an empty spot in workspace until the popup menu appears.
        3. Click widgets.
        4. Notice the new two pane layout
Change-Id: Ia3ea17dc320f72f9bc5dea52399ff51d9161602b
2023-02-09 16:36:45 -08:00
Brandon Dayauon fb9c4d25c4 Merge "Method to override feature flag" into tm-qpr-dev 2023-02-09 23:31:47 +00:00
Thales Lima bb056c6001 Merge "Create an XML parser for WorkspaceSpecs" into tm-qpr-dev am: 5d5aad3024 am: 0ebaf3a46c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20643018

Change-Id: I471bb3ccd04a0598a309e53038976fbccb638ce1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-09 13:01:28 +00:00
Brandon Dayauon 533e4856b4 Method to override feature flag
- Replaced where it's used in GridSizeMigrationUtilTest.kt

bug: 268094298
test: manually/presubmit and GridSizeMigrationUtilTest photo: https://screenshot.googleplex.com/7cLtFSbBvxnYAFM
Change-Id: Id8e688b95b91b1b6a4962a4e092505cbb79603f7
2023-02-08 17:01:46 -08:00
Thales Lima 1a2d4bd6f4 Create an XML parser for WorkspaceSpecs
Extract DeviceProfileTest to Launcher3 so it can be used in other tests as well, and change name of previous base test to be more descriptive.

Bug: 241386436
Test: WorkspaceSpecsTest
Change-Id: I64613bb5a23c374ed15fb6d936192236a541ab9b
2023-02-08 11:20:14 +00:00
Thales Lima a91f5251b6 Merge "Improvements for All Apps on different display sizes" into tm-qpr-dev am: fcb6a5fc06 am: f0c4b41bf1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21116563

Change-Id: Ifbf110cb76d348a8b6a3b3fdd0f47a4b10dcfe4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-08 11:05:07 +00:00
Thales Lima fcb6a5fc06 Merge "Improvements for All Apps on different display sizes" into tm-qpr-dev 2023-02-08 10:02:17 +00:00
TreeHugger Robot 4a2bf3b131 Merge "Update tests to support floating search." into tm-qpr-dev 2023-02-06 23:50:49 +00:00
Andy Wickham 8d004b0f49 Update tests to support floating search.
Tests need to be updated to account for the new placement of the
searchbar because it overlapped with touch events for scrolling:
 - Scroll back to top: Instead of scrolling from the top of the
   container which could overlap status bar in landscape, scroll
   from the bottom of the top-most visible app icon.
 - Scroll down: swipe up from bottom padding to top of top-most
   visible icon.
 - Close all apps: swipe down more quickly from top icon insetad
   of the search bar (more quickly helps it be detected as a
   fling on more cramped devices).

For Launcher3, the floating flag is not fully supported yet, so
there were some layout issues which are now resolved by ignoring
the flag if the searchbar is still at the top.

Fix: 268052768
Test: Ran tests, manual
Change-Id: If54717e2835c7cc4ed1368554bbc493193945c1d
Merged-In: I406fbcbe12acddb1dd4b862a380576a48cabbebc
2023-02-06 13:49:14 -08:00
Andy Wickham 8353c38f92 Merge "[revert ^2] Enable Floating Search and update tests accordingly." 2023-02-04 09:19:18 +00:00
Andy Wickham 346771550e [revert ^2] Enable Floating Search and update tests accordingly.
Tests need to be updated to account for the new placement of the
searchbar because it overlapped with touch events for scrolling:
 - Scroll back to top: Instead of scrolling from the top of the
   container which could overlap status bar in landscape, scroll
   from the bottom of the top-most visible app icon.
 - Scroll down: swipe up from bottom padding to top of top-most
   visible icon.
 - Close all apps: swipe down more quickly from top icon insetad
   of the search bar (more quickly helps it be detected as a
   fling on more cramped devices).

For Launcher3, the floating flag is not fully supported yet, so
there were some layout issues which are now resolved by ignoring
the flag if the searchbar is still at the top.

Fix: 261873937
Test: Ran tests, manual
Change-Id: I406fbcbe12acddb1dd4b862a380576a48cabbebc
2023-02-03 14:24:22 -08:00
Sebastián Franco 04ba7b0e23 Merge "Adding test to make sure the icons seen when unfolded are the same when folded" into tm-qpr-dev am: b57479c189 am: 591b511565
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21120301

Change-Id: Ib3709fdadf7a07006f5916461f636ea7abc81b03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 21:35:38 +00:00
Sebastián Franco b57479c189 Merge "Adding test to make sure the icons seen when unfolded are the same when folded" into tm-qpr-dev 2023-02-03 20:39:04 +00:00
Sam Dubey 51e1ef37f7 Merge "Revert "Enable Floating Search by default and update tests accordingly."" 2023-02-03 14:42:49 +00:00
Sam Dubey 29f78a597b Revert "Enable Floating Search by default and update tests accordingly."
This reverts commit 952400d2f2.

Reason for revert: b/267743311

Change-Id: I007274cdea1c424c87ddea4592e9e1c7a273bea9
2023-02-03 12:45:15 +00:00
Andy Wickham 89638d2252 Merge "Enable Floating Search by default and update tests accordingly." 2023-02-03 10:27:38 +00:00
Sunny Goyal f98fc1d099 Merge "Exposing method to register content providers in sandbox context" into tm-qpr-dev am: de15772052 am: 459f2c7114
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21236578

Change-Id: Icb74ab16c876aa65db0110a6e39faa50ec4f0a09
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 08:29:53 +00:00
Sunny Goyal de15772052 Merge "Exposing method to register content providers in sandbox context" into tm-qpr-dev 2023-02-03 07:34:10 +00:00
Andy Wickham 952400d2f2 Enable Floating Search by default and update tests accordingly.
Tests need to be updated to account for the new placement of the
searchbar because it overlapped with touch events for scrolling:
 - Scroll back to top: Instead of scrolling from the top of the
   container which could overlap status bar in landscape, scroll
   from the bottom of the top-most visible app icon.
 - Scroll down: swipe up from bottom padding to top of top-most
   visible icon.
 - Close all apps: swipe down fom top of recyclerview instead
   of search bar.

For Launcher3, the floating flag is not fully supported yet, so
there were some layout issues which are now resolved by ignoring
the flag if the searchbar is still at the top.

Fix: 261873937
Test: Ran tests, manual
Change-Id: I7d6fc7deac630835b96fc173211ce31271152607
2023-02-02 21:05:52 -08:00
Jon Miranda 3c76c2212a Merge "Update notification dot renderer when we update the taskbar icon size." into tm-qpr-dev am: 5903751ee3 am: 82382fc784
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21225224

Change-Id: Iec7cd640cb84417f231dd440490a6d1c78b38465
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 02:29:15 +00:00
Jon Miranda 5903751ee3 Merge "Update notification dot renderer when we update the taskbar icon size." into tm-qpr-dev 2023-02-03 01:34:05 +00:00
Stefan Andonian c0d6de8bcf Merge "Migrate "isRotationAllowed" setting to LauncherPrefs." into tm-qpr-dev am: 6a4e9a34ab am: 424c469513
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21061164

Change-Id: I81a4aff8f133dfef57205cc423471fbb4fb2c08c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 01:18:45 +00:00
Stefan Andonian 6a4e9a34ab Merge "Migrate "isRotationAllowed" setting to LauncherPrefs." into tm-qpr-dev 2023-02-03 00:27:14 +00:00
Sunny Goyal 305cb87891 Exposing method to register content providers in sandbox context
Bug: 263286512
Test: presubmit
Change-Id: I04a8160afec2ea0d153eca113537a8778d8f3514
2023-02-02 15:20:58 -08:00
Jon Miranda 2b25ded506 Update notification dot renderer when we update the taskbar icon size.
Test: swipe to home with an app that has a notification dot
      observe no jump in dot size
Bug: 264709741

Change-Id: I5d56fe57e74ed7b094477ecd8727152f3f522042
2023-02-02 23:10:42 +00:00
TreeHugger Robot b59cdf26ab Merge "Add @ScreenRecord to testPressHomeOnAllAppsContextMenu" into tm-qpr-dev am: 18be12d0dd am: fda08cb9cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21136643

Change-Id: Id5d7459eb28d8c4cf9e992e1f2ac61d05e11dd19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 21:28:20 +00:00
Sebastian Franco 48c7f8e035 Adding test to make sure the icons seen when unfolded are the same when folded
Bug: 188081026
Test: atest FoldableItemsIntegrity
Change-Id: I7e09c03fccb89b1d218bf196433b2fe4ad09d8e0
2023-02-01 13:22:33 -08:00
Stefan Andonian 1d7f703514 Migrate "isRotationAllowed" setting to LauncherPrefs.
This semi-complicated case requires use of a context in order to get the
default value. That is why it was migrated by itself.

Bug: 261635315
Test: Manually tested all the base functionality of the launcher.
Change-Id: I40d8ccd414402b55921a0a224264414d3245871b
2023-02-01 20:26:41 +00:00
TreeHugger Robot 18be12d0dd Merge "Add @ScreenRecord to testPressHomeOnAllAppsContextMenu" into tm-qpr-dev 2023-02-01 18:51:31 +00:00
Thales Lima e9273ea743 Improvements for All Apps on different display sizes
Bug: 262912817
Test: DeviceProfileAlternativeDisplaysDumpTest
Change-Id: I50e980183b4d5c1a46cca8f1c867b866b9eae4b5
2023-02-01 11:34:12 +00:00
Sunny Goyal 5fc8131b60 Merge "Introducing CellPosMapper which allows mapping between UI position and model position" into tm-qpr-dev am: 126ac14112 am: a19f661961
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21128574

Change-Id: Id2cdf2a5262def0401cd2a60fbe89044f55a9c98
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-31 19:30:30 +00:00
Sunny Goyal 669b71f5b3 Introducing CellPosMapper which allows mapping between UI position
and model position

Test: atest CellPosMapperTest
Bug: 188081026
Change-Id: If5c6b3df5ad240317bb535c675f6ead94084238e
2023-01-30 12:17:09 -08:00
hyunyoungs 50b824392a Add @ScreenRecord to testPressHomeOnAllAppsContextMenu
Bug: 264538883
Test: seems to run fin on tm-qpr-dev
Change-Id: If395260ba58496282b651e1938e28f3cef22654f
2023-01-28 18:55:05 -08:00
Thales Lima d852d65693 Create attr for padding between icon and text in cells
Bug: 265210314
Test: DeviceProfileDumpTest
Change-Id: I00af790d0c21c35f1cbce1362e63d3ab8259244a
Merged-In: I00af790d0c21c35f1cbce1362e63d3ab8259244a
2023-01-26 22:50:18 +00:00