Commit Graph
15471 Commits
Author SHA1 Message Date
Renato Grottesi fbeaa762ff Revert "[RESTRICT AUTOMERGE] Fix permission issue in legacy shortcut" am: dedca445bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23557759

Change-Id: Ib5445adcc05cccf854f941ed150f8e81e06b2f4a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-05 17:09:05 +00:00
Renato Grottesi dedca445bb Revert "[RESTRICT AUTOMERGE] Fix permission issue in legacy shortcut"
This reverts commit 3de2b51b6b.

Reason for revert: 285847936 getParcelable requires API level 33 (current min is 26)

Change-Id: I83d47f3b55c8a4f48b4ace54b8106c97a854a394
2023-06-05 11:17:41 +00:00
Pinyao Ting 4bbeb0689b [RESTRICT AUTOMERGE] Fix permission issue in legacy shortcut am: 3de2b51b6b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23538718

Change-Id: Ie9c1b478e71b96056234fb7236cb2e87513cb481
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-03 14:43:23 +00:00
Pinyao Ting 3de2b51b6b [RESTRICT AUTOMERGE] Fix permission issue in legacy shortcut
When building legacy shortcut, Launcher calls
PackageManager#resolveActivity to retrieve necessary permission to
launch the intent.

However, when the source app wraps an arbitrary intent within
Intent#createChooser, the existing logic will fail because launching
Chooser doesn't require additional permission.

This CL fixes the security vulnerability by performing the permission
check against the intent that is wrapped within.

Bug: 270152142
Test: manual
Change-Id: If35344c08975e35085c7c2b9b814a3c457a144b0
2023-06-02 16:14:32 +00:00
Presubmit Automerger Backend 5ab41346d8 [automerge] Clear Accessibility Focus from icon after Shorcut Menu invoked 2p: cb582591b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22750962

Change-Id: Ib5981d226c7cabe8e302c108b198c3fb657f3812
2023-04-20 23:21:40 +00:00
Jon Miranda cb582591b3 Clear Accessibility Focus from icon after Shorcut Menu invoked
Similar to I2726504094af2abacf1c41089c7bcd4efb588099

Fixes: 267695526
Test: have talkback on
      open all apps
      open long press menu
      ensure focus stays on pop up menu

Change-Id: I38f78df3855495c53a5ae8966e9a996e4679e95b
2023-04-20 16:21:02 -07:00
Federico Baron 6e15488a84 Merge "Revert "Fix bug where very large widgets get cropped out"" into tm-qpr-dev am: 627376d5b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22514931

Change-Id: Iac69ac354de9a81293e9b3ec7955c926227eb0ab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-07 02:43:54 +00:00
Federico Baron 627376d5b9 Merge "Revert "Fix bug where very large widgets get cropped out"" into tm-qpr-dev 2023-04-07 02:13:45 +00:00
Federico Baron 81ffe3d28d Revert "Fix bug where very large widgets get cropped out"
This reverts commit cb36de9e9f.

Reason for revert: b/276644867

Change-Id: If5d5172ab26c71304364b6b528162e551d35ec9f
2023-04-06 19:53:58 +00:00
TreeHugger Robot a2b770b484 Merge "Allow grids to specify if we should start align taskbar in 3 button nav." into tm-qpr-dev am: 65ac592f40
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22361600

Change-Id: I71c7f33286ccfa770f87b812c8ec27fa4ecb25ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-05 22:06:49 +00:00
Jon Miranda 04f051045c Allow grids to specify if we should start align taskbar in 3 button
nav.

Bug: 259712417
Test: check layout on tablet
      check layout on multi_display devices

Change-Id: I282f51e5d76a30e9ad9d8c52d03d4853e965d65a
2023-04-05 10:29:51 -07:00
Sunny Goyal e2d73bf57d Merge "Removing unnecessary device sumaltion code" into tm-qpr-dev am: 08a13d6aae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22432108

Change-Id: I883a06a1bf44f7f25928b1355637bd3a8b5d7bdc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-04 17:20:58 +00:00
Sunny Goyal 08a13d6aae Merge "Removing unnecessary device sumaltion code" into tm-qpr-dev 2023-04-04 17:00:34 +00:00
Tony Wickham 3979706e06 Merge "Add debug logs for why taskbar might not be destroyed" into tm-qpr-dev am: c8d8c58f5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22391708

Change-Id: I1bea5537e4bfbe6bac55010f58979c2f9fcf6fe4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-04 16:07:16 +00:00
Tony Wickham c8d8c58f5b Merge "Add debug logs for why taskbar might not be destroyed" into tm-qpr-dev 2023-04-04 15:40:28 +00:00
Tony Wickham df59884370 Add debug logs for why taskbar might not be destroyed
Test: Manually read log output
Flag: None
Bug: 254119092
Change-Id: Ibaa7ffdc91030c5c999ddc5f2807a55763854331
2023-04-03 23:20:57 +00:00
TreeHugger Robot 01ebdf81a7 Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev am: b32fd3a556
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22163528

Change-Id: Ib755f18a8f763120fdaa0fd5d39e9491f05f5705
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-03 21:00:44 +00:00
TreeHugger Robot b32fd3a556 Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev 2023-04-03 20:54:16 +00:00
Sunny Goyal 076e04bcc2 Removing unnecessary device sumaltion code
Bug: 276774148
Test: Verified on device
Change-Id: Icb8c2e7649e5b0e107af184b63f7e30f2df717bd
2023-04-03 12:38:52 -07:00
Vinit Nayak 3e5b212204 Merge "Default to using SplitSelectSource drawable if TaskView icon drawable is null" into tm-qpr-dev am: 8e307ba50a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22347415

Change-Id: I9fe261fdaa96ab8d5a0792a3d69cb201beebdb9a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-03 15:22:57 +00:00
Vinit Nayak 8e307ba50a Merge "Default to using SplitSelectSource drawable if TaskView icon drawable is null" into tm-qpr-dev 2023-04-03 14:58:29 +00:00
Andy Wickham c5f8dff8e2 Merge "Don't move down all apps container when touching near scroll bar." into tm-qpr-dev am: 30c2bdda52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22342811

Change-Id: If0e164e719229827e57d2edb34582ab8fd7bc88f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-31 23:25:05 +00:00
Andy Wickham 30c2bdda52 Merge "Don't move down all apps container when touching near scroll bar." into tm-qpr-dev 2023-03-31 23:01:25 +00:00
Brian Isganitis 7d8b81df09 Merge "Clean up device profile change listeners for AllApps." into tm-qpr-dev am: 4500171c6b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22338655

Change-Id: I54c6fb31077ed06f6e0122dca3e47e3a7e6f8f34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-31 17:33:17 +00:00
Brian Isganitis 4500171c6b Merge "Clean up device profile change listeners for AllApps." into tm-qpr-dev 2023-03-31 16:42:07 +00:00
Vinit Nayak ecca8eacbc Default to using SplitSelectSource drawable if TaskView icon drawable is null
* Alternative solution could be to set
onTaskViewVisibilityChanged(true) for the taskView that is about
to be dismissed so it loads it's taskIcon/thumbnail back from the cache
* However, that does still leave us open to race conditions (even though
we can be reasonably confident the icon is probably in the cache)
* Also made other changes to allow already public fields on some classes
to be mockable for unit testing

Fixes: 275267738
Test: Tested with fullscreen task at end of overview,
GroupedTaskView at end of overview,
Initiating split from home,
Initiating split from overview actions,
Initiating split from overview app icon

Change-Id: Ic9059c93c07b90f61c9f418d5d36d6ba201ff96a
2023-03-30 15:26:57 -07:00
Andrew Cole 67f446827b Merge "Fixing an issue with the drop target font becoming very small for removing and uninstalling. I also verified that this doesnt break a fix presented in b/264732627" into tm-qpr-dev am: 6cb7469564
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22338450

Change-Id: I415ab087552478fe95d4055735300be1c77b01bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 16:47:29 +00:00
Schneider Victor-tulias d8e5795131 Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev am: 90259a6db4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22185922

Change-Id: I916c0e191cb2e335b9e393ea76c34cff39778481
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 16:47:04 +00:00
Andy Wickham 23f7d82831 Don't move down all apps container when touching near scroll bar.
Previously we were using any touch outside of the panel to move
the container, but we want to check this last, after checking if
the touch is near the scrollbar (in which case it should intercept
instead).

Test: Manual
Flag: N/A
Fix: 236661990
Change-Id: I518c546356d1f6c6cedf4b31fa621295dd090175
2023-03-29 22:04:11 +00:00
Brian Isganitis d43d7c3702 Clean up device profile change listeners for AllApps.
Test: https://b.corp.google.com/issues/260177372#comment1
Bug: 260177372
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d17261029af89ef03b860686d1d3c6651e7c8e13)
Merged-In: Ic7417980e8280bf2fcb110e5de74ea2ae59d9b74
Change-Id: Ic7417980e8280bf2fcb110e5de74ea2ae59d9b74
2023-03-29 18:46:47 +00:00
Andrew Cole 3ae7be6293 Fixing an issue with the drop target font becoming very small for removing and uninstalling. I also verified that this doesnt break a fix presented in b/264732627
Fix: 274402490
Test: Manual
Change-Id: Id61cf7e33f83e0cb25c82b5e7b167b04657fd612
2023-03-29 17:21:34 +00:00
Schneider Victor-tulias 90259a6db4 Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev 2023-03-29 17:03:59 +00:00
Sunny Goyal 6589b4020b Merge "Updating PinShortcutRequestActivityInfo to provide pinRequest lazily" into tm-qpr-dev am: e1471d3acd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22318893

Change-Id: I38621d4470db873fd0b3b1b1b38047018cbcdec2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-29 06:04:26 +00:00
Sunny Goyal 13a6b228a5 Updating PinShortcutRequestActivityInfo to provide pinRequest lazily
Bug: 275407282
Test: Verified on device
Change-Id: I81867ada454219b44663b58b942329422fb81196
2023-03-28 13:28:34 -07:00
Jon Miranda 705d193aa4 Merge "Fix transient taskbar icon size in two panel portrait DeviceProfile" into tm-qpr-dev am: e7ab5849d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22302207

Change-Id: I43bdf6b1a4391c3e0a7313ae014c86cce253d3cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28 16:23:04 +00:00
Jon Miranda e7ab5849d7 Merge "Fix transient taskbar icon size in two panel portrait DeviceProfile" into tm-qpr-dev 2023-03-28 15:56:49 +00:00
Jon Miranda 4d74ad3c31 Fix transient taskbar icon size in two panel portrait DeviceProfile
Fixes: 275269031
Test: use two panel device
      verify taskbar icon size in portrait
      verify taskbar icon size in landscape
      rotate between the two orientation
Change-Id: I21ae4aee90c3aa54615d8d0881acb40d8b4f351f
2023-03-28 15:55:36 +00:00
Hyunyoung Song a9934f00d3 Merge "Fix lint error in errorprone target (only in tm-qpr-dev)" into tm-qpr-dev am: ec6c2591c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22293181

Change-Id: I57167b224875742ac7f31069e18ebb02460b54b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 23:12:58 +00:00
Hyunyoung Song ec6c2591c5 Merge "Fix lint error in errorprone target (only in tm-qpr-dev)" into tm-qpr-dev 2023-03-27 23:02:38 +00:00
Sebastián Franco 35252fd9f2 Merge "Changing global variable for local variable to prevent memory leaks" into tm-qpr-dev am: 9c83077712
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22293180

Change-Id: Ibba08154760e08134e3d649ad39ef016f1206abb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 22:58:09 +00:00
Sebastián Franco 9c83077712 Merge "Changing global variable for local variable to prevent memory leaks" into tm-qpr-dev 2023-03-27 22:23:26 +00:00
Schneider Victor-tulias 34eb098745 Add debug logs to debug flaky workspace binding
Flag: not needed
Bug: 270216650
Test: ReorderWidgets
Change-Id: Ia5caeb6b0e5ed1b0b406fab9c18e2e6799a4f68a
2023-03-27 14:40:36 -07:00
Schneider Victor-tulias 7cd0ae3f73 Fix TwoPanelWorkspaceTests
- Marking the hotseat long press edu as seen on setup to allow the popup menu to be shown immediately in tests
- Recording onWorkspaceItemLongClick on prediction item long click

Flag: not needed
Fixes: 273239675
Test: TwoPanelWorkspaceTest
Change-Id: I76354fd2e3adde11b2a428374fa9c8855ce2ece9
2023-03-27 14:24:35 -07:00
Hyunyoung Song fa9dbe3291 Fix lint error in errorprone target (only in tm-qpr-dev)
Bug: 275111546
Test: m out/soong/.intermediates/packages/apps/Launcher3/Launcher3/android_common/lint/lint-baseline.xml
Before: https://paste.googleplex.com/6542806926491648
After: https://paste.googleplex.com/5015617085112320

Change-Id: If486407303b81a38b4a35979e442299f33fa49b2
2023-03-27 18:38:35 +00:00
Sebastian Franco 7cdc616a01 Changing global variable for local variable to prevent memory leaks
The array mTmpObjArray is not properly clean but ther is no need
for the array to be global since every time is used is provided
so a use of a local variable will make sure is never leaked.

Fix: 269163620
Test: the flake related to memory leak on testWorkspace should dissapear
Change-Id: I29fb3dd6419f621f2ccce9db2fc5ed86358f7516
2023-03-27 11:18:14 -07:00
Hyunyoung Song 739dcca38a Merge "Icon should not disappear on drag and drop" into tm-qpr-dev am: 7eae6a4ce1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22255567

Change-Id: Ied5d3740325666cc74f407fd0c9d8821bfa8be8e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-26 07:57:20 +00:00
Hyunyoung Song 7eae6a4ce1 Merge "Icon should not disappear on drag and drop" into tm-qpr-dev 2023-03-26 07:22:55 +00:00
hyunyoungs 825480fbcc Icon should not disappear on drag and drop
Bug: 275009677
Test: BubbleTextViewTest

Change-Id: Iddff7a0130c9a0ddb76223064338459dbe9b52e8
2023-03-24 15:16:20 -07:00
Jon Miranda 3cd39729dc Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev am: 085c53869f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22228076

Change-Id: I687ea2a249e73036f8d4c4d187d999fd224b9f02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 22:02:13 +00:00
Hyunyoung Song bb1237eb76 Merge "Revert "Revert "Hide the splash icon when launching with no view..."" into tm-qpr-dev am: e8abfee5e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22067827

Change-Id: I1d5e7b401cfb874a0f801cfc0b5b76b53a608c64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 22:00:27 +00:00