Commit Graph
609 Commits
Author SHA1 Message Date
Becky Qiu 4dfcbec512 Revert "[Overview Actions] UI update for Landscape."
This reverts commit 160ca4b8a2.

Reason for revert: Got issues like b/158318606 when switch nav modes, also the margin seems not set properly. And this doesn't work for 3 button mode too. Would switch to just use task menu for all.

Change-Id: I645f2a2a9032ae99799c75bcc6c983c1bbfd8df8
2020-06-06 00:04:47 +00:00
Becky Qiu 160ca4b8a2 [Overview Actions] UI update for Landscape.
1. When home screen rotation is allowed, we still have action buttons for landscape, but remove bottom margin to shrink the UI.
2. When home screen rotation is not allowed, we do in-place rotation for overview, where we won't show action buttons.

Test: see demo video: https://drive.google.com/file/d/1G6ihv_DOykx1MLpFAQf3VJHq3D1HotnX/view?usp=sharing
Bug: 153736749

Change-Id: Ia1c7ef8c245ac13bf50adf32ee5114f23e491e75
2020-06-03 14:21:08 -07:00
TreeHugger Robot 19fc8b6a83 Merge "Fixing exception when applying transaction while the surface is released" into ub-launcher3-rvc-dev 2020-06-03 20:15:16 +00:00
TreeHugger Robot 62382c3f95 Merge "Update home to overview depth interpolator to match other motion" into ub-launcher3-rvc-dev 2020-06-02 20:18:01 +00:00
vadimt bd7ee7366d Checking for success of interactions with Wellbeing
Bug: 157589968
Change-Id: I9a5cc6341c0133ae5e31c47b6bd89f80e15c9099
2020-06-01 14:03:43 -07:00
Tony Wickham 10c2b4f9d9 Update home to overview depth interpolator to match other motion
Overview comes in and workspace goes out at overshoot(1.2), so
the wallpaper depth/blur should match that speed.

Test: go to overview from home in 3 button or 0 button mode,
ensure wallpaper scales down at the same rate as other elements

Bug: 154637581
Change-Id: I03254fa3fdf19f468852bed8aab7ba21203c429a
2020-06-01 14:36:46 -05:00
Sunny Goyal 142dcd8489 Fixing exception when applying transaction while the surface is released
> Check surface before applying transaction
> Keeping the release check around even if it release true the first time, as some other check may defer release
> Waiting on animation complete before releasing a surface

Bug: 148885018
Bug: 148194313
Change-Id: Ieb2b98492ff7df165e6b28a108b5f2cbc7ded32d
2020-05-29 16:08:28 -07:00
Jon Miranda 84f6e0182e Fix depth jumping around during transitions.
This is caused because we use mDepth for depth comparisons, but there are
cases where we set mDepth but we do not pass that value to WallpaperManager
(ie. surface is null or not valid) and that leads us into
inconsistent states.

Bug: 155780358
Change-Id: I3faf14416d5783ad472892425eb0bd37dd469a46
2020-05-29 13:06:55 -07:00
Sunny Goyal a314d5ad58 Updating swipe up on home animations
> Scaling down home activity on swipe-up from home and spring back to place on cancel
> Fading out recents on swipe-up to home, so ensure that adjecent tiles also dissapear
> Instead of controlling alpha, controlling full transform for base and home task. This allows adding custom animation for home task on swipe up.
> Removing alpha hanging for fallback activity in baseSwipeHandler. Instead controlling full transform for home activity
> Adding feature flag to use QuickstepLauncher as 3P Launcher to make development easier.

Bug: 156398988
Change-Id: I69cc59f2c9c95d15df6926ba635e7d6c251dceb6
2020-05-27 19:49:46 +00:00
TreeHugger Robot a41f9dcbe9 Merge "More logging for swiping to Overview instead of All Apps" into ub-launcher3-rvc-dev 2020-05-19 21:04:20 +00:00
vadimt f95cfce267 More logging for swiping to Overview instead of All Apps
Bug: 156095088
Change-Id: Ia4d59b43225c7652cfc0ae72c05a5477deeb842b
2020-05-19 12:49:17 -07:00
Vinit Nayak 88830c0657 Increase overview thumbnail size for 2 button landscape.
With shelf hidden in 2 button landscape, need to fill
in the extra space w/ larger thumbnail.

Fixes: 156442623
Test: Larger thumbnail shows up in 2 button landscape
Change-Id: Ie2856c8d248b28ae7c06cbe40c7417a827c2bd96
2020-05-19 12:07:37 -07:00
Winson Chung 034ce6fd94 Update shelf offset earlier when in gesture nav
- Provide a hint to Launcher to indicate it will be resumed when
  swiping home, which allows us to notify sysui before any potential
  pip invocation, reducing the likelyhood of two conflicting animations
  when entering pip

Bug: 156637223
Change-Id: Iae773e1aac88bbea6f74e1d1332417b448126471
2020-05-14 10:55:14 -07:00
Sunny Goyal 35e7d38681 Abstracting out state handler logic into base classes so that it can
also be used in different activity

Change-Id: Ic5e60b21e1429c71f1cd4e7041e70bf4fc9761b7
2020-05-11 16:38:26 -07:00
Becky Qiu 7d12134240 [Overview Actions] Change actions view UI based on different nav modes.
1. Change the overview actions container to 66dp height.
2. For 3 button mode, container will have 8dp bottom margin.
3. For gesture mode, container will have 16dp bottom margin.
4. Action buttons and close button will always be in the center vertically.

Spec: https://docs.google.com/presentation/d/1gXWNdCRXvXuEhgDmE0TX2KYqCxIQBXVtWKdl4pKrno8/edit#slide=id.g840c32b190_3_6

Demo:
- 3 button: https://screenshot.googleplex.com/2Y3uMaJMi9E
- gesture: https://screenshot.googleplex.com/XzaKHpp5ke9
Test: tested for both modes and when switch between.
Bug: 155444592

Change-Id: If66d369df0218b7ee2abab8a3f345488bf223b16
2020-05-11 10:46:21 -07:00
Jon Miranda e620872b18 Add logs to debug playtime crash and band aid fix for release builds.
Bug: 153821199
Change-Id: I0caa546254bb51ca8b88cdb16d79c054560bf2be
2020-05-05 18:18:40 -07:00
Winson Chung 2a00f81327 Account for various launcher states when setting back button alpha
- Previously we only check for the flag which is always true in the
  normal launcher state, so if the animation starts, we could end up
  writing the back alpha value without accounting for window focus or
  any other states that launcher is in that affects back button
  visibility

Bug: 155129739
Test: Open -1 article and hit back
Change-Id: I42d27a192b23f394f8565a6893ce092603e31654
2020-04-30 23:03:52 -07:00
Zak Cohen 7f48b0aa34 Overview - position the modal task in the correct place.
video of new behavoir
https://drive.google.com/a/google.com/file/d/1vFTtjjpwamj5H7dhmB1-5JSFS6fv6vMw/view?usp=sharing


Test: local
Bug: 155205932
Change-Id: I7fe79c848af92013587de32a777645cc472ae910
2020-04-30 18:34:46 +00:00
Lucas Dupin 20051e22e5 Merge "Do not blur if all apps is fully visible" into ub-launcher3-rvc-dev 2020-04-30 17:11:53 +00:00
Sunny Goyal 8f96546e79 Generalizing LauncherState definition so that it can be used in RecentsActivity
> Removing 'Launcher' as parameter from state methods called by StateManager
> Converting state properties to methods for easier abstraction
> Moving state handling drom state definition to activity class

Change-Id: I997627df606a7e0bb3bf32688d045a942a47fc94
2020-04-30 01:01:51 -07:00
Lucas Dupin 264cb2ff68 Do not blur if all apps is fully visible
Fixes: 155093795
Fixes: 155203546
Test: manual
Change-Id: I30f4c027e5107a199791e908acbb7ffed94e6a77
2020-04-29 17:49:02 +00:00
Jon Miranda f6225830d5 Fix floating icon view positioning when in multiwindow mode.
The rect we passed in was in screen space to match the window, but needs to be
be local to launcher.

Also updated code/comments to make it more readable.

Note that the bounds of the targets being off is a separate issue b/153581126

Bug: 135195169
Change-Id: I4a8c0aa2f504bdf69342a927725cd440fb324a36
2020-04-28 21:29:51 -07:00
Zak Cohen a39544d562 OverviewActions - Use launcher state to track modal state.
Test:local

Change-Id: I44e25b95095b9a7aac4b4172c9c91fbfbf4d9ec7
2020-04-27 16:29:44 -07:00
TreeHugger Robot 1016bf410d Merge "Don't scale workspace when going to all apps if ENABLE_OVERVIEW_ACTIONS" into ub-launcher3-rvc-dev 2020-04-25 06:21:30 +00:00
Ming-Shin Lu 4f07525417 Fix AlwaysOnTop stack may covered by RemoteAnimation
Now with hierarachical animation, the layer of
RecentsAnimation / RemoteAnimation are controlled by system.

Now Launcher side don't need to have other way to set layer for ZBoost
case, so remove setLayer & withLayer related logics for cleaning up.

Fix: 151024899
Test: manual, launch google map app -> enter PiP mode,
      swipe up to overview screen or launch activity from shortcut,
      make sure the PiP window is not covered by other apps.

Change-Id: I8028cd50d66f7d77e5d1ec6514e953c8be9935d6
(cherry picked from commit 99f7da7dd2)
2020-04-24 02:18:16 +00:00
TreeHugger Robot 1bb37acb5d Merge "Don't allow swiping from overview to all apps in 3 button mode" into ub-launcher3-rvc-dev 2020-04-23 00:04:35 +00:00
Tony Wickham 22757e840c Don't allow swiping from overview to all apps in 3 button mode
Bug: 154761926
Change-Id: I155faec27f3b96e2f11aaec318d6846a893885e6
2020-04-22 23:13:48 +00:00
Becky Qiu 72c53af896 [Overview Actions] Update the navigation mode immediately when switch.
This would fix the issue that overview actions UI visibility was not set correctly.

Test: local
Bug: 152047880
Change-Id: Ia335c5c8947b39e580403090f461f87e78645af1
2020-04-22 15:57:34 -07:00
Winson Chung 674e38fdb6 Merge "Disable blurs while in multiwindow mode" into ub-launcher3-rvc-dev 2020-04-21 19:39:17 +00:00
Sunny Goyal f2393f1d20 Adding TaskViewSimulator for simulating taskView layout on a remote target
1. Tanslating contents of RecentsView instead of recentsView itself. When
   translating, we keep the current TaskView from moving. This allows
   the remoteTarget to follow an individual taskView.
2. Removing translationY in recentsView and setting the pivot instead
3. Using TaskViewSimulator for swipe handler. This allows using similar
   animation creation as Launcher window animation.

Change-Id: I0b7b16c367d9d8cd8dd0ed59061e46853e2f8c83
2020-04-21 11:16:21 -07:00
Winson Chung b330d6e6f8 Disable blurs while in multiwindow mode
- With hierarchical animations, the split-secondary shell root
  is moved above the split-primary shell root immediately during
  transitions, which means that setting the blur on the launcher
  surface will also affect the primary docked surface

Bug: 154125518
Change-Id: I21dd01738ee9bc974d41e5964364917a30143a2a
2020-04-21 10:28:43 -07:00
Winson Chung f66e7c19bd Merge "Dedupe non-perceptable depth updates" into ub-launcher3-rvc-dev 2020-04-20 21:10:20 +00:00
Sunny Goyal 01d8541f14 Fixing actions view getting visible sometimes
> Linking actions view to state flags
> Creating multiple visibility channels that can be controlled separately

Bug: 153906903
Change-Id: I33d20f5fdc8bcdf0520dae3aac986548eb7e0058
2020-04-20 09:59:13 -07:00
Winson Chung 20aeddd853 Dedupe non-perceptable depth updates
Bug: 154304487
Change-Id: I6d96aca555932f4a51aed576d25f7150952bb562
2020-04-17 16:16:44 -07:00
Tony Wickham c09e8fbe9d Merge "Remove mPendingCallback from ActivityTracker" into ub-launcher3-rvc-dev 2020-04-17 19:35:49 +00:00
TreeHugger Robot 74974e802e Merge "Add resume callback to animate back to appropriate depth." into ub-launcher3-rvc-dev 2020-04-16 21:47:38 +00:00
Jon Miranda 172302686c Add resume callback to animate back to appropriate depth.
This fixes the bug where depth gets stuck to 1 after opening a transluscent
activity.

Bug: 152950633
Change-Id: I8bf5f61c57ef79d41656865b1ff1fbadb298fc36
2020-04-16 13:03:48 -07:00
Tony Wickham 73ff6ddeac Remove mPendingCallback from ActivityTracker
Instead, all callers should use EXTRA_SCHEDULER_CALLBACK, set via
addToIntent(), to provide a callback for the next handleIntent().
The updated runCallbackWhenActivityExists() will do that for the
caller if the activity doesn't already exist (otherwise it will
run the callback synchronously as before).

Bug: 151389129
Change-Id: Idbec264354fd6de166ff3bae98249230078d5674
2020-04-15 18:48:39 -05:00
Jon Miranda dc186e68a1 Add AnimationFlag for SKIP_DEPTH_CONTROLLER.
We use this flag to prevent the depth from being immediately set to 0 when
preparing to animate home.

Bug: 152327671
Change-Id: I614c6ae08b9f9e56ecb94fb51748791a38504583
2020-04-15 15:19:49 -07:00
TreeHugger Robot a8c63ecb13 Merge "Revert regression where we no longer reverse translation for RTL" into ub-launcher3-rvc-dev 2020-04-14 18:07:26 +00:00
Tony Wickham 08f9a5878d Don't scale workspace when going to all apps if ENABLE_OVERVIEW_ACTIONS
Before the two-zone model introduced with ENABLE_OVERVIEW_ACTIONS, we
scaled down the workspace when swiping up, since you could pause at
any time to go to overview (which has workspace scaled down behind it).
But in the two-zone model, that scaling is potentially confusing since
it looks similar to the HintState (when swiping from the nav bar).

Bug: 143361609
Change-Id: I3ee9f6eb45abb0123563d283a3145f27c3a63dd5
2020-04-14 10:24:24 -05:00
Tony Wickham 133cd54474 Refactor some onboarding-related shared prefs into a class
Bug: 151768994
Change-Id: I938e23af8c1874714e02fe34d0f9f82bb21d00a2
2020-04-10 21:06:08 -07:00
Tony Wickham b214bd0cb1 Revert regression where we no longer reverse translation for RTL
Change-Id: I6de15c983eaf7ece244f2b2ba7e9f9c80bdab92b
2020-04-09 18:06:03 -07:00
Sunny Goyal e396abf502 Moving model data structures to a separate file
Change-Id: I77ad7a5219e72d2e0d6c1803de2ac3ed6a65a8f7
2020-04-09 13:20:39 -07:00
Sunny Goyal 512a2c1dbe Adding All Apps action even when launcher is not in foreground
> Also avoids additional binder call on resume/pause
> Removes a system API which needs to be mocked for robo tests

Change-Id: I23d0cba62c17f7659121c53d1804df40f5069005
2020-04-09 02:48:40 -07:00
Tracy Zhou 5d35b86558 Merge "Switch to public API for surface view when rendering preview" into ub-launcher3-master 2020-04-06 22:51:49 +00:00
Tracy Zhou bb353d3741 Switch to public API for surface view when rendering preview
Bug: 152003916
Test: Manual
Change-Id: I539ed2876d869366fa7635f4467d19e8488b7a1a
2020-04-06 14:39:52 -07:00
Sunny Goyal c4d3201538 Removing support for fake landscape
Bug: 111068105
Change-Id: If31d2f700ddee1d21541735de3a8006ee2a53c5c
2020-04-03 17:11:35 -07:00
Sunny Goyal 514dfa2deb Changing actions button visibility to match clear-all button
> Removing translation when animating actions button

Change-Id: I6875e03f9c55f00232c605743348175ea132cb15
2020-03-30 16:46:06 -07:00
Samuel Fufa 0928456d55 Fix NPE on FeatureFlag.addChangeListener
Bug: 152400212
Change-Id: I64890370f1d638048b0340bcb537ffdbf7011681
2020-03-26 17:03:44 -07:00