When the widget picker is shown while the show_home_behind_desktop
feature is enabled, it becomes possible for the widget picker to be
opened while freeform tasks are occluding the home screen. To fix this
case, navigate Home to move it in front of occluding tasks, and then
open the widget picker. Navigating home is an asynchronous action, and
widget picker will already be opening once the intent executes, so
exlude closing the widget picker when closing all AbstractFloatingViews
in this case.
This change is intended for the desktop form factor.
Bug: 416057590
Flag: com.android.window.flags.show_home_behind_desktop
Test: Open freeform tasks, open WidgetPicker via menu, make sure that
tasks are hidden and WidgetPicker shows.
Change-Id: I19ebeeb706ae7374df8038d956d453708bc96f7e
When freeform windows are shown on top of launcher, disable the swipe up
to open all apps, which would open behind these windows. This change is
inteded for the desktop form factor.
Bug: 419565477
Flag: com.android.window.flags.show_home_behind_desktop
Test: Manually swipe up on home screen with freeform windows shown.
Change-Id: I795e9e05fe39b0cf8033b51ce4369340d49ef812
Revert submission 33672643-DataDeviceProfile1
Reason for revert: Droidmonitor created revert due to b/419867875. Will be verifying through ABTD before submission.
Fix: 419867875
Reverted changes: /q/submissionid:33672643-DataDeviceProfile1
Change-Id: Icb66aefbbcee24e05806b2139923e1f2ea1c65e3
This will allow us to see the logs in Winscope, including frame by
frame to make debugging easier.
Also added a log for Launcher#onNewIntent to help with Home button.
Test: EXEMPT log only update
Bug: 417248321
Bug: 384423890
Flag: NONE log only update
Change-Id: Ib24aeb78e44ff29542eb25411c51f77dba299a2e
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles
Reland fix:
- Removed mBlursEnabled in BaseDepthController, and only use `mCrossWindowBlursEnabled` to control swapping between blur style and fallback style
- Temporary variables like `mPauseBlurs` and `hasOpaqueBg` should only affect if blurs are applied, but not result in swapping of blur style, otherwise this cause unnecessary redraw or activity recreate
Reason for revert: reland
Reverted changes: /q/submissionid:33581402-revert-33554447-b/414789280-CTVRJLPLRT
Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Test: PressBackFromLaunchedApp.testPressBackFromLaunchedApp
Flag: EXEMPT bugfix
Change-Id: Iac2b0c00811e0e79684da0cf77df76a120c1272a
Revert submission 33554447-b/414789280
Reason for revert: Droidmonitor created revert due to b/417614196. Will be verifying through ABTD before submission.
Fix: 417614196
Reverted changes: /q/submissionid:33554447-b/414789280
Change-Id: Idf349cd39a3f86910f597f0f9ab4d46fb03e945c
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles
Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I90ad724867283fe3c62a9073a6e072491533f774
So we have a central place to replace it with opening
WidgetPickerActivity behind a flag.
Bug: 408283627
Flag: EXEMPT minor refactor
Test: Existing tests
Change-Id: I1c26c3faec8549fd5c3057b4c26ab2ab109f6f0c
Collisions should be handled prior to binding in the ui layer.
The following change adds extra logging to help identify cases
where this might occur.
Bug: 417021465
Flag: EXEMPT Bug fix
Test: manual
Change-Id: I5549c94fe81eb13088f8c56a5ff797d46d4bedb2
> Moving some latency logic out of Launcher and into logger
> This makes it easier to move the logger completely out of Launcher
Bug: 390572144
Test: atest StartupLatencyLoggerTest
Flag: EXEMPT refactor
Change-Id: I6f6d99e7ed6c77610534c64461ec34200780225f
BgDataModel holds a mutable handle of the data, which ensures that all edits go through this class and there is a single place to keep the repository updated
Bug: 390572144
Test: Updated existing model tests
Flag: EXEMPT refactor
Change-Id: I991b707dd21801d1abd00510f676549947285012
> This allows the whole workspace model to be contained in itemIdMap instead of spread across multiple data containers
> Deprecating extraItems, all non-workspace data should use separate repositories
> Design: http://go/launchermodel-re-arch?#heading=h.5y8n4r164d5s
Bug: 390572144
Test: atest PredictionUpdateTaskTest
Flag: EXEMPT refactor
Change-Id: I886d0a8d5bbbf9f5c2054d4a2442bf03f9c4eab5
1. BlurFallbackStyle/BlurStyle will now be applied in Launcher startup.
When "updateBlurStyle" is called, individual element style's swap
happens as per blur style.
2. "hasOpaqueBg" background will now be checked in "applyDepthAndBlur"
for setting the "currentBlur" value.
Bug: 409758306
Test: Manual. go to overview, enable/disable battery saver mode.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Ic9030c2b267867b9124705426dd51deb1b30ca55
When updating hotseat qsb alpha in response to assistant visiblity
changes, use Hotseat.setQsbAlpha with a designated alpha channel instead
of updating the view alpha directly. QSB alpha can be changed for
different reasons - e.g. because taskbar is shown, so the calling
View.setAlpha directly may overrride visibility set from other sources.
Using setQsbAlpha ensures that the final qsb alpha aggregates all alpha
inputs.
Bug: 413500588
Flag: EXEMPT bugfix
Test: On desktop device (where taskbar is shown on home), connect a
display while on home, and verify the inline hotseat qsb does not
become visible on the primary display.
Change-Id: Ida2325aa630c0c2d2c324d5e3001207cf661f2e9
This brings the BgCallbacks closer to a repository pattern making is easier to switch eventually
Bug: 390572144
Flag: EXEMPT refactor
Test: Updated AsyncBindingTest to use real ModelCalbacks
Change-Id: I9c932b00ea8ac7330473b9c0f5d778453fe7a390
Instead of the dispatcher specifying the type, the UI checks th diff. This
ensures that the UI is updated correctly in all paths
Bug: 390572144
Flag: EXEMPT refactor
Test: Manually verified folder edit path where these callbacks were getting dispatched
Change-Id: Ib73eed5da87a847753a78453a48ab4fc495c1199
I had previously hidden workspace with All Apps blur because the
approaches I had tried looked poor. However, I found that this
approach is both simple and relatively performant! Essentially,
wallpaper is still pushed back and blurred by the DepthController.
When the DepthController applies blur, we also apply it to the
Workspace and Hotseat. In addition, we scale these at the same
rate as the depth when swiping to all apps. Perhaps we can have
the DepthController control this scale too, but for now we just
use the same Interpolator. The result looks pretty cohesive.
Demo: https://drive.google.com/file/d/1KyKc0c5BsAEOrT3K4buOW3U9-Gk0e7vE/view?usp=sharing&resourcekey=0-MI1gdQMul0cro9IEkQDEng
App exit demo (slightly outdated): https://drive.google.com/file/d/1r-VhzGhlI0300_6IUXthty3Tm1cgw9aI/view?usp=sharing&resourcekey=0-nxZ2BHW2UN34lr567I0RdA
Bug: 400827727
Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: I5dc66619a001ccd32f37272cf77966cbe1bf8ef6
With the dagger update the initialization happens in constructor which
we would avoid once we work on refactor and move it into a repository
class. The list will also be fetched from a different data source, so,
makes sense to delete it at the moment.
Bug: 406324964
Flag: EXEMPT BUGFIX
Test: Not applicable as code is removed
Change-Id: Iab8bb1e94677abf9b5b882f4d3485b002faf3e0f
This would allow customizing the widget holder in LauncherPreview
Bug: 361850561
Test: Updated tests and presubmit
Flag: EXEMPT dagger
Change-Id: I32491169188992453693048986c57cb780fdf1d8
Folder and FolderIcon are UI objects and can talk to each other directly.
FolderInfo changes are already propogated via model callbacks, and doesn't need a separate listener pattern.
Bug: 398791288
Flag: EXEMPT bugfix
Test: atest FolderTest
Change-Id: Iefd47b8ea12a8ecaf34211a3d908220a0e999187
Moving widget filtering to UI layer as it changes with surface
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9d9377540ca36873659cea4ecc91fb162d82cd44