Commit Graph
1493 Commits
Author SHA1 Message Date
Vinit Nayak 788821ec4e Launch GroupedTaskView from thumbnails
* Previously when starting the remote animation
we were relying on SplitPlaceholderViews to
animate into the proper place since we weren't
launching from the TaskView itself
* Now when launching from a GroupedTaskView,
we use the existing animation that handles that
animation in addition to showing the new split tasks

Fixes: 206608786
Test: Thumbnails animate from home -> overview -> launch
Change-Id: I1499ead7d90cd41e285ed0f4df66ea31f0dfbc95
2021-11-18 22:58:53 -08:00
Tony Wickham bf4a91b0f1 Use TOUCHABLE_INSETS_REGION when IME is visible
This ensures the dismiss button is fully clickable even if taskbar is stashed.

Test: Stash taskbar, can dismiss keyboard by tapping anywhere on the back button
(Same with taskbar unstashed)
Fixes: 206851484

Change-Id: I06f86191e36b596a928c8db8d67a012be033daba
2021-11-17 14:04:25 -08:00
Tracy Zhou 1fdea66f16 Fix memory leak in TaskbarLauncherStateController
mIconAlphaForHome.setConsumer(null) in onDestroy()

Test: Run BinderTests#testSwitchToOverview locally
Bug: 206633573
Change-Id: I912cd66097b113ee84197f23a5862e333d7e63f2
2021-11-16 11:31:15 -08:00
Tracy Zhou 0200636585 Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev 2021-11-16 09:41:58 +00:00
Hyunyoung Song 664f685336 Merge "Address AppEventProducer to correctly send search-result location on AppTargetEvent" into sc-v2-dev 2021-11-12 07:46:23 +00:00
Hyunyoung Song 1e5b621a50 Address AppEventProducer to correctly send search-result location on AppTargetEvent
Bug: 191362091
Test: logcat printout

11-10 20:27:02.290 32215 32237 D QuickstepModelDelegate: notifyAppTargetEvent action=1launchLocation=search-results

Change-Id: I16ef7679116e397a8a108cc291f5741febf2e453
2021-11-11 21:27:01 -08:00
ryanlwlin 1ee6bd7bb6 Fix the cutout of magnification border
If the window is unmagnifiable, it might cause the cutout of
magnification region.
To fix it, we set the flag when the touchable region is not the
entier window frame.

To fix NexusLauncherTests, we add a flag to avoid updateViewLayout
too frequently that would impact memory test and have the performance
issue.

Bug: 196510717
Test: manual test on gestural and 3-button navigation
      presumbit test pass
      run atest NexusLauncherTests with foldables
Change-Id: Ifef81640fe6c08ee1b0dcd3915227fba3002ea43
Merged-In: Ifef81640fe6c08ee1b0dcd3915227fba3002ea43
(cherry picked from commit c8d588cff6)
2021-11-10 09:51:54 +00:00
Tracy Zhou e89a83b65d Track LauncherState, RecentsAnimation, resumed state for task bar in one place
TODO:
- Consider delaying animating task bar to stashed towards all apps state until user releasing their finger (tho in this change heuristic is applied for stashing and unstashing respectively)
- Further consolidate some animation logic

Bug: 204220602
Test: manual

Change-Id: I58b4d035fcf65a9f5c68e69c129eae95b89b1c4a
2021-11-09 23:46:03 -08:00
TreeHugger Robot 44fcfa5bfd Merge "Play fallback animation when overlay is shown." into sc-v2-dev 2021-11-08 20:49:58 +00:00
Jerry Chang 2e2f49e8a5 Merge "Accept snapshot list when cancelling recents animation" into sc-v2-dev 2021-11-08 10:22:34 +00:00
Jerry Chang 331f46fab3 Accept snapshot list when cancelling recents animation
Bug: 200813008
Test: enter overview after activated split screen, observed task
      thumbnails showing with correct bounds after roation.
Change-Id: Ifea17d2c685d16db111c4fab88e131595254b9a5
2021-11-08 09:55:43 +08:00
Jon Miranda 4e5664ac28 Play fallback animation when overlay is shown.
Bug: 205086529
Test: go to -1, click to open app, swipe back
Change-Id: I905511e0ac7576d2134a10088289a5ca37d1b257
2021-11-05 16:16:12 -07:00
Schneider Victor-tulias 2bfbf3bffa Add popup menu and click handling to taskbar.
- Added popup menu support to taskbar icons
- Added item click handling for taskbar icon popup menu items

Bug: 198438631
Test: long pressed taskbar icons, pressed popup menu items, dragged taskbar icons to start multi-window mode
Change-Id: Ibc59c1eada50a877a863c075fbfd3e4accaae008
2021-11-05 13:07:09 -07:00
TreeHugger Robot 160b1357bf Merge "Show divider when GroupedTaskView expanded from recents" into sc-v2-dev 2021-11-05 19:50:24 +00:00
Vinit Nayak d0eea50a0c Show divider when GroupedTaskView expanded from recents
* Also increased animation duration to allow
apps to get ready

Fixes: 202928293
Change-Id: I8814ec2415e7985e4f433695f6cc55f83f0c0ac2
2021-11-05 11:15:01 -07:00
Winson Chung cc4a1925a6 Remove debug tracing checks to get logs beteween tests
Bug: 201305599
Test: Presubmit
Change-Id: Iab4430f88a2cac97a056486edd97895bc30a03b1
2021-11-05 09:45:13 -07:00
Vinit Nayak 04d52b48ac Merge "Invoke IME switcher for taskbar through SysUI" into sc-v2-dev 2021-11-04 20:47:05 +00:00
Winson Chung 3b5dddbce1 Merge "Add some logging for taskbar recreation" into sc-v2-dev 2021-11-03 23:41:07 +00:00
Evan Rosky a3defa4d39 Merge "Provide app-process tokens to remote transitions so they can be boosted" into sc-v2-dev 2021-11-03 20:59:08 +00:00
Winson Chung 067faf3bbe Add some logging for taskbar recreation
Bug: 201305599
Test: Manual
Change-Id: I437fe3226657ebe7b5507146fbe5e7f32e2e2fce
2021-11-03 11:17:44 -07:00
Winson Chung d9db871f79 Merge "Revert "DO NOT MERGE Fix the cutout of magnification border"" into sc-v2-dev 2021-11-03 16:49:07 +00:00
Alex Chau c91a43e110 Revert "DO NOT MERGE Fix the cutout of magnification border"
Revert "Do NOT MERGE Fix magnification border includes taskbar"

Revert submission 16003793-magnification_border

Bug: 196510717
Reason for revert: Caused NexusLauncherTests and NexusLauncherOutOfProcTests to stop running
Reverted Changes:
Ibbc9c51ea:Do NOT MERGE Fix magnification border includes tas...
Ida2bb5bf1:DO NOT MERGE Fix the cutout of magnification borde...

Change-Id: I6b2123aedd2a2f23142a34f158d2d9ab71948a18
2021-11-03 14:19:23 +00:00
Ryan Lin 0ee6940bd0 Merge "DO NOT MERGE Fix the cutout of magnification border" into sc-v2-dev 2021-11-03 05:24:27 +00:00
Vinit Nayak 874ea446c9 Merge "Revert "Align OverviewActionsView for 3 button taskbar"" into sc-v2-dev 2021-11-03 05:04:32 +00:00
ryanlwlin 571df892f7 DO NOT MERGE Fix the cutout of magnification border
If the window is unmagnifiable, it might cause the cutout of
magnification region.
To fix it, we set the flag when the touchable region is not the
entier window frame.

Bug: 196510717
Test: manual test on gestural and 3-button navigation
Change-Id: Ida2bb5bf120038ac9153e12790b93bdec195adbc
2021-11-03 10:50:09 +08:00
Vinit Nayak 3fabe054c2 Revert "Align OverviewActionsView for 3 button taskbar"
This reverts commit 97d64ea8a1.

Reason for revert: b/204891006

Change-Id: I9d40a5c8c9bce6b818779ebaf748bb9bd9231caf
2021-11-02 22:08:33 +00:00
Vinit Nayak ac24e7f6f0 Merge "Align OverviewActionsView for 3 button taskbar" into sc-v2-dev 2021-11-02 05:37:45 +00:00
Vinit Nayak 97d64ea8a1 Align OverviewActionsView for 3 button taskbar
Bug: 189807374
Change-Id: I028ae31b98e28bc372f0148a28755d067fe50678
2021-11-02 01:13:02 +00:00
TreeHugger Robot 651b93bb53 Merge "Do not use shared lib resources" into sc-v2-dev 2021-11-01 20:40:43 +00:00
Jonathan Miranda 9b85616119 Merge "Remove PROTOTYPE_APP_CLOSE feature flag and associated code." into sc-v2-dev 2021-11-01 18:35:44 +00:00
Nick Chameyev 5f11bf60a8 Do not use shared lib resources
Temporary removes usages of SysUI shared
resources as it leads to crashes in Launcher
tests.

Bug: 204727471
Test: install launcher, try autorotate suggestion
Change-Id: I1e3c1f5b331a22a753acc3fe0ee544d50fba5c18
2021-11-01 15:49:54 +00:00
Nick Chameyev 0288d2e8bb Move floating rotation button handling to Launcher
Moves handling of floating rotation button when navigation
bar is not created to the launcher. This button was not
showing when taskbar is visible as it was initialized in
navigation bar (which is not created for large screens).

Bug: 200103245
Test: rotate phone when autorotate disabled on inner screen
Test: showing rotate suggestion when gesture nav enabled/disabled
Change-Id: I13dd555bcd811f1524be7ab9ad51b2b012b3b749
2021-11-01 10:36:34 +00:00
Jon Miranda 029a644a6e Remove PROTOTYPE_APP_CLOSE feature flag and associated code.
Flag was never enabled, safe to remove.

Bug: 200999899
Test: manual
Change-Id: Ie2646d8c4b9a1c40fac1bfd7dadf4ec714171aec
2021-10-29 16:07:29 -07:00
Vinit Nayak 0ca3f98ec6 Invoke IME switcher for taskbar through SysUI
Bug: 191814219
Test: IME switcher works small and large screen
Change-Id: Ic2db60357a13846bb34dddd64b27ecbbf8ff656f
2021-10-29 11:46:18 -07:00
Tony Wickham 5a5a926945 Recreate taskbar when dark mode changes
Also dispatch sysui flags to all controllers upon recreate, not just NavbarButtonsViewController. Additionally, tell the controllers to skip the animation due to the flag changes if it's fromInit.

Test: Enable themed icons, switch dark theme in quick settings, ensure taskbar updates
Fixes: 204403933
Change-Id: Ic43a50cf0456175f9beba5c29360440f051cbd2d
2021-10-28 17:49:03 -07:00
TreeHugger Robot da86c0e64d Merge "Update taskbar drag and drop treatment" into sc-v2-dev 2021-10-28 20:54:09 +00:00
Tony Wickham 89ef745d1c Update taskbar drag and drop treatment
- Disable the FastBitmapDrawable icon instead of setting it to invisible
- Suspend auto hide during drag and drop (moved to new TaskbarAutoHideSuspendController)

Test: Drag and drop from taskbar and ensure the original icon stays in place but desaturated
Test: Open immersive app, drag and drop from taskbar and ensure taskbar doesn't hide before drop
Fixes: 200816442
Change-Id: I4b895efd043be75e7e7034bd75e751ffdd2cfdd7
2021-10-28 11:43:49 -07:00
bquezada e12b321d5f Change AppTargetId for launcher events to align with other AppTargetId's.
Bug: 202535375
Test: Manual
Change-Id: I0c28f7f64935fdaf08edb7781e4e7378a068e8e6
2021-10-28 17:52:02 +00:00
Alina Zaidi 29c3f23be5 Merge "Send widget added and removed events to AiAi." into sc-v2-dev 2021-10-28 16:45:22 +00:00
Schneider Victor-tulias 9188b6b993 Update the hotseat edu layout for foldable devices.
Test: ran the hotseat edu on folded and unfolded foldable device in portrait and landscape mode and in three-button and gesture nav mode. ran hotseat edu on regular phone
Fixes: 203734732
Change-Id: Iea2140c8241cdea60cb5db37fbfb7f7701d63bd6
2021-10-27 17:48:46 +00:00
Tracy Zhou c6bdd9243a Merge "Delete TaskbarStateHander" into sc-v2-dev 2021-10-27 02:11:12 +00:00
Pablo Gamito aae8a2a2a5 Merge "Set custom task transition spec when taskbar is visible" into sc-v2-dev 2021-10-26 21:32:16 +00:00
Tracy Zhou 72f1afcf02 Delete TaskbarStateHander
Bug: 204220602
Test: N/A
Change-Id: I6c26b4d3b8acb35750be56986555350e84f31ecb
2021-10-26 13:26:27 -07:00
TreeHugger Robot 3bd6b8bf81 Merge "Make sure distinct widgets items are used when mapping widget component names to widget items." into sc-v2-dev 2021-10-26 18:01:48 +00:00
Pablo Gamito 77d3cab287 Set custom task transition spec when taskbar is visible
This is to ensure that the task to task animations look good when the
taskbar is visible (the transition background is the same as the taskbar
color, the taskbar overlay rounded corners are hidden, and the task
animates above the taskbar so it's rounded corners are visible during
the animation and not hidden behind the taskbar).

Test: Open tasks from other tasks to trigger task to task animations and
see if they look good
Bug: 200675009
Bug: 196387647

Change-Id: I8e46718829c0e6541a5c1b1a3a156285aeecd30a
2021-10-26 14:56:27 +02:00
Alina Zaidi 987221a1cc Send widget added and removed events to AiAi.
-Pass the widgets on workspace as an extra List<AppTargetEvents> while
 creating prediction session.
-Notify the session about widget added/removed events after creation.

Bug: 186648032
Test: Manually checked events are received
Change-Id: I4de6c011a1e24c129a3e995ddba16bfc55074939
2021-10-26 12:29:48 +01:00
Tony Wickham add188f339 Merge "Hide taskbar background when notification shade is expanded" into sc-v2-dev 2021-10-26 02:56:47 +00:00
TreeHugger Robot c6649763a7 Merge "Fix launching window bounds for immersive apps" into sc-v2-dev 2021-10-25 23:20:47 +00:00
Tony Wickham 232e9a4631 Hide taskbar background when notification shade is expanded
- In 3 button mode, don't hide the background but do ensure nav buttons are translated down when swiping to notificaitons from the home screen

Test: swipe down notifications, background hides in 0 button mode but not in 3 button mode
Fixes: 199163951
Change-Id: Ic70adc7d67b2ab7c92a2d5d846b9b259d1bd7bfc
2021-10-25 13:44:09 -07:00
Alina Zaidi fa37c6742e Make sure distinct widgets items are used when mapping widget component
names to widget items.

This is to prevent a crash on duplicate key when creating map.

Bug: 204065759
Test: Enabled flag and got no crash
Change-Id: Ice9f93af76c02eeba53c934687358ed806c60b60
2021-10-25 16:10:45 +01:00