Commit Graph
16798 Commits
Author SHA1 Message Date
Fengjiang Li cc83032318 Merge "Log appear animation's scale factor" into udc-qpr-dev am: bebcaaae19 am: 3ff869be8f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24119210

Change-Id: I2611a1f8052ef1cacdc513c2fd8b3375365b48a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-20 21:53:34 +00:00
Fengjiang Li bebcaaae19 Merge "Log appear animation's scale factor" into udc-qpr-dev 2023-07-20 21:02:42 +00:00
Fengjiang Li da718e9749 Log appear animation's scale factor
Test: Grabbed a bug report b/291974797
Flag: N/A
Bug: 290320302
Change-Id: Ic33dc94806b838a03a2203bdd5701a1eeaeeb7bf
2023-07-20 11:08:14 -07:00
Jordan Silva ab8c185507 Merge "Implement responsive grid for foldables 4x4 grid" into udc-qpr-dev am: 9dbe9e34af am: 68d0e4891d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23765913

Change-Id: I59236eeb1b7743fdf2c7962ef84fd10644e820bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-20 17:39:09 +00:00
Jordan Silva c118fb5dea Implement responsive grid for foldables 4x4 grid
Bug: 277064862
Fix: 289888732
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: ResponsiveHomeScreenImageTest
Test: ResponsiveAllAppsImageTest
Test: ResponsiveFolderImageTest
Change-Id: Idf21fc0dc71f9cea474dc9515a4695ccaf6bc094
2023-07-20 11:37:00 +01:00
Anushree Ganjam 18b120dce4 Merge "Implement ImpressionLogging v2." into udc-qpr-dev am: 4cd4ed090e am: 935e03400e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24016221

Change-Id: Ic2ddc5b8486430b485ba5924cfd0a4f22e6248dc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-20 00:19:30 +00:00
Brian Isganitis 4b43de28fa Merge "Start drag from current translation shift during animation." into udc-qpr-dev am: 62b59f9a81 am: 268ba3f6dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24130990

Change-Id: I5d15dfe1cb24fec970552d14e5c2b75beed3e816
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-20 00:19:16 +00:00
Anushree Ganjam 4cd4ed090e Merge "Implement ImpressionLogging v2." into udc-qpr-dev 2023-07-19 23:17:10 +00:00
Brian Isganitis 62b59f9a81 Merge "Start drag from current translation shift during animation." into udc-qpr-dev 2023-07-19 23:06:32 +00:00
Brandon Dayauon ba39c6a3e8 Merge "Make mDisplay DISPLAY_SEARCH_RESULT visible for test" into udc-qpr-dev am: cff52a4db6 am: 7f88952e20
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24013857

Change-Id: Icc55dfb940f9c230286a7d0f47fe8882452a01ac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 22:52:37 +00:00
Brandon Dayauon cff52a4db6 Merge "Make mDisplay DISPLAY_SEARCH_RESULT visible for test" into udc-qpr-dev 2023-07-19 22:02:22 +00:00
Thales Lima 20c13c54f8 Merge "Improving responsive grid xml parser" into udc-qpr-dev am: 6382afd657 am: 9b915f6f73
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23766603

Change-Id: Ibaad19450258120849cc94d37ae9442b0aa3631a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 21:28:31 +00:00
Fengjiang Li 86c6840352 Merge "Fix bug where all apps rv preinfaltion is not enabled when work profile is disabled" into udc-qpr-dev am: 82ddd8ac97 am: 5b2008e0bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24119000

Change-Id: Ifd48b6c04dffa63aff1f7872adca0914014f0150
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 21:25:43 +00:00
Thales Lima 6382afd657 Merge "Improving responsive grid xml parser" into udc-qpr-dev 2023-07-19 20:56:04 +00:00
Fengjiang Li 82ddd8ac97 Merge "Fix bug where all apps rv preinfaltion is not enabled when work profile is disabled" into udc-qpr-dev 2023-07-19 20:03:48 +00:00
Anushree Ganjam 514314c7ee Merge "Introduce onAnimateToSearchStateCompleted() in SearchUiDelegate." into udc-qpr-dev am: 55405157e2 am: b561ec2921
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24069799

Change-Id: I537885e676a1e4555a90bf41da73b4fc11a3affd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 19:09:09 +00:00
Pat Manning a38c61d900 Merge "Update scaleRectAboutCenter to correctly account for negative left/top values and floating point errors using centerX/Y." into udc-qpr-dev am: 933f2b9f27 am: e7048dd987
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23917023

Change-Id: If4358fb96e42da9492a2ff3372c5958f46b57c1f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 19:08:56 +00:00
Brian Isganitis f3ebdd4819 Start drag from current translation shift during animation.
Test: Manual
Fix: 291950331
Flag: No
Change-Id: I67fe6a474fc1b10d8e34fb047f98af2c1e6e085c
2023-07-19 14:15:31 -04:00
Anushree Ganjam 55405157e2 Merge "Introduce onAnimateToSearchStateCompleted() in SearchUiDelegate." into udc-qpr-dev 2023-07-19 18:02:41 +00:00
Pat Manning 933f2b9f27 Merge "Update scaleRectAboutCenter to correctly account for negative left/top values and floating point errors using centerX/Y." into udc-qpr-dev 2023-07-19 17:20:39 +00:00
Cameron Brown 089094ab40 launcher3: add missing whitespace to log
Change-Id: Ia3f4ec3bd46647eb3e0ee5a3a5e38d748a8ae02b
2023-07-19 15:08:48 +00:00
Pat Manning 75708262fc Update scaleRectAboutCenter to correctly account for negative left/top values and floating point errors using centerX/Y.
Fix: 290211274
Test: manual.

Change-Id: Ieddce683d76c696b5ac3eae4fb9f73a5827a50ad
2023-07-19 14:47:32 +00:00
Anushree Ganjam a9645535b8 Implement ImpressionLogging v2.
Deprecate V1 implementation and keep only V2.

Bug: 285964742
Test: Manual
Flag: NA

Change-Id: If27f02f7142abf7960f74252d1e46bcd8c5b5e2a
2023-07-18 21:56:28 +00:00
Fengjiang Li bafbdfbfd6 Fix bug where all apps rv preinfaltion is not enabled when work profile is disabled
When work profile is disabled, we should also let main RV use AllAppsStore's recycler view pool.

Test: Turn off work profile, kill launcher process, swipe up all apps, start record perfetto trace, scroll down all apps, then stop record, verify no BubbleTextView inflation after change
Bug: 287523421
Flags: ENABLE_ALL_APPS_RV_PREINFLATION
Change-Id: Idd5f8193e85fc2a250877affc3b2e4ab4a704797
2023-07-18 14:05:36 -07:00
Jordan Silva 8bd7af2b3f Improving responsive grid xml parser
Refactors AllAppsSpecs, FolderSpecs and WorkspaceSpecs initialization to use the same code to parse the xml with different map function. This CL improves the readability of the code and remove code duplication.

Fix: 286538013
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: AllAppsSpecsTes
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecsTest
Test: CalculatedWorkspaceSpecTest
Test: FolderSpecsTest
Test: WorkspaceSpecsTest
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Change-Id: Iec5863619399efd2e80f3db46b75c4d785e1656f
2023-07-18 18:03:16 +01:00
Anushree Ganjam 660679f91f Introduce onAnimateToSearchStateCompleted() in SearchUiDelegate.
This will be called when transition animation to search is completed.

Bug: 285166099
Flag: NA
Test: Manual
Change-Id: I69e594cbf3564a866d258654fc23a00410e7deab
2023-07-18 02:16:42 +00:00
Brian Isganitis 40c96b4049 Have OptionsPopupView depend on ActivityContext.
Only certain static methods in this class require Launcher at this
point.

Test: Manual
Bug: 291615281
Flag: No
Change-Id: I27bda70bd4f9da75e112d4f68a383447bcc3c32c
2023-07-17 14:40:59 -04:00
Brian Isganitis 3f0e7e7c5d Merge "Initial Taskbar drag-n-drop support for search results." into udc-qpr-dev 2023-07-17 17:08:15 +00:00
Sunny Goyal cd5d3d0c31 Merge "Removing LauncherActivityRule as it can be flaky based on when the rule was initialized" into udc-qpr-dev 2023-07-17 16:58:20 +00:00
Pat Manning f351e515f7 Merge "Show tooltips on cursor hover of taskbar icons." into udc-qpr-dev 2023-07-17 10:15:46 +00:00
Fengjiang Li ccd49005c9 Merge "Handle nullable CellLayout when removing app icon from folder" into udc-qpr-dev 2023-07-15 02:44:31 +00:00
TreeHugger Robot 61c2bbe5b8 Merge "Clean up SplitData refactor flag" into udc-qpr-dev 2023-07-14 23:25:27 +00:00
TreeHugger Robot ef52e37e5f Merge "Exposing the layout URI builder method, so that it can be used in tests" into udc-qpr-dev 2023-07-14 22:11:29 +00:00
Sunny Goyal 0d149e6f93 Exposing the layout URI builder method, so that it can be used in tests
Bug: 286558846
Test: N/A
Flag: N/A
Change-Id: Ib39c0477bb977ac2eb3e484463bc3ea770dc4069
2023-07-14 13:03:12 -07:00
Vinit Nayak 1db3292029 Clean up SplitData refactor flag
Bug: 279494325
Test: Invoking split works from home, overview.
Opening split to fullscreen also works

Change-Id: Ie1f26f833d5c10bb114b9e8eb1bd9f3b6b913b3d
2023-07-14 10:54:59 -07:00
Sunny Goyal f6b79f7caf Removing LauncherActivityRule as it can be flaky based on when
the rule was initialized

Bug: 289161193
Test: Presubmit and PostSubmit
Flag: N/A
Change-Id: I0e1e9c6f932d2a98a2f1e47bd1665e26f2db9eb4
2023-07-14 10:29:55 -07:00
Pat Manning da69661add Show tooltips on cursor hover of taskbar icons.
Fix: 250092437
Test: TaskbarHoverToolTipControllerTest
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: Ia0463518d13b313b354328078685930215fb7636
2023-07-14 13:42:30 +01:00
Treehugger Robot 3396b5c338 Merge "Creating a correctly populated mOccupied grid when reordering on foldables" into udc-qpr-dev 2023-07-13 20:31:37 +00:00
Becky Qiu 5bcd1ca3d6 Fix the issue that on tablet/unfold, the allapps background color is wrong. am: aa6612d373 am: 64746f8a29
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24030571

Change-Id: I9f00b40302eba3683f2260f5efa5e5dbc3566f38
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-13 20:09:01 +00:00
Becky Qiu 64746f8a29 Fix the issue that on tablet/unfold, the allapps background color is wrong. am: aa6612d373
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24030571

Change-Id: I513daa1fdeb8d5582bd0cec9b8b2eb4d043f2543
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-13 19:02:27 +00:00
Fengjiang Li 080f9326ab Handle nullable CellLayout when removing app icon from folder
If CellLayout is null, instead of early return that will lead app icon not clickable, we should fallback to use Launcher as activity

Fix: 290973455
Test: attached to video
Change-Id: I10b03f3f41dd672116133af83ae8a5b066824d71
2023-07-13 10:30:19 -07:00
Anushree Ganjam e1a4eb4a09 Merge "Introduce Default Ime height." into udc-qpr-dev 2023-07-13 06:23:28 +00:00
Treehugger Robot a5af8b4276 Merge "Fix inability to remove or interact with folder when removing 2nd item from folder" into udc-qpr-dev 2023-07-12 23:17:30 +00:00
fbaron 5a7ea3069b Fix inability to remove or interact with folder when removing 2nd item from folder
Fix: 289960317
Test: Verify in unfolded felix that going from 2 icon folder and dragging 2nd icon out of folder lets you open the app that remains where the folder was
Test: Verify in unfolded felix that going from 2 icon folder and dragging 2nd icon into remove droptarget removes the folder and turns it into a single clickable icon
flag: no flag
Change-Id: I26138ee9f8e7cdb45cafe2446dc4d1e3d6d8347f
2023-07-12 14:15:00 -07:00
Vinit Nayak f909a72f3f Merge "Cleanup ENABLE_SPLIT_FROM_WORKSPACE flag" into udc-qpr-dev 2023-07-12 20:57:22 +00:00
Sebastian Franco 1c5514b566 Creating a correctly populated mOccupied grid when reordering on foldables
On ag/21680045 I copy the previous mOccupied but the right thing to do is to
create a new one with all the views information.

Some test stoped running inadvertently that's why we didn't catch this issue.

There is a separate cl with the test to ensure we can catch it later on.

Fix: 289584301
Test: ReorderWidgets
Change-Id: I27b5a6e38a556d1c73ff8fbbdd552da6045e5b64
2023-07-12 13:52:54 -07:00
Brian Isganitis 3346e19b3b Initial Taskbar drag-n-drop support for search results.
- Includes initial support for obtaining PendingIntent for ITEM_TYPE_SEARCH_ACTION.
- Custom pre-drag conditions for search results can be provided through TaskbarSearchSessionController.
- Added detection for telling when DragView shift animation ends for
  pre-drag condition usage.

Test: Manual
Bug: 289261756
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I52510a6f3ee49968134ecb591ef7c4df711b9d3d
2023-07-12 14:42:02 -04:00
Thales Lima 735b18ba4c Merge "Fix responsive folders" into udc-qpr-dev 2023-07-12 17:33:55 +00:00
Anushree Ganjam 5730f03c9f Introduce Default Ime height.
Assume IME_DEFAULT_HEIGHT_DP = 300.
When ime is yet to be shown but the UI is ready, then use
IME_DEFAULT_HEIGHT_DP.

For the 2nd time onwards save the actual ime height and use it when the
keyboard is not shown yet.

Bug: 285166099
Test: Manual
Change-Id: I33e38cbd5c2910f4a6dc4cc83c8dc4b6d94fbcff
2023-07-12 17:21:40 +00:00
Jordan Silva 511449fe9e Merge "Add function to update SysUiScrim duration for tests" into udc-qpr-dev 2023-07-12 16:43:43 +00:00