Commit Graph
529 Commits
Author SHA1 Message Date
Sunny Goyal 711c596c86 Binding Taskbar directly from Launcher model
This allows taskbar to be loaded even in case of 3P Launchers
and removes dependency on LauncherActivity lifecycle

Bug: 187353581
Bug: 188788621
Test: Manual
Change-Id: I5a0988e0697b41677d4c58f0213aef14ec0c0972
2021-07-15 12:43:11 -07:00
Andras Kloczl ac3f08558c Fix launcher preview for two panel home
Test: manual
Bug: 185508060
Gif: http://shortn/_oOgKLjg5QC
Change-Id: I216b3761b3bd15c7069b92aa4a1bff8ad655b767
2021-07-13 23:13:17 +02:00
Andras Kloczl 88716645cd Fix icon adding issue on two panel home
Test: manual & PromiseIconUITest & RequestPinItemTest
Bug: 192431856
Change-Id: I4a6319fa33c9359057f87d9c008eb139410593b5
2021-07-06 17:41:26 +02:00
Hyunyoung Song 6700b07b95 Merge "Revert "Don't use ProxyActivity when launching from SearchActionItemInfo intent"" into sc-dev am: 933d2536da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15184812

Change-Id: I11f7a50edec21c2ed2adca381f7841a4844b2580
2021-07-02 21:36:55 +00:00
Hyunyoung Song 933d2536da Merge "Revert "Don't use ProxyActivity when launching from SearchActionItemInfo intent"" into sc-dev 2021-07-02 21:18:18 +00:00
Hyunyoung Song 5881b910e9 Revert "Don't use ProxyActivity when launching from SearchActionItemInfo intent"
This reverts commit 878dedfb84.

Reason for revert: b/192558017
Bug: 192558017

Change-Id: I41e64ab74c00d7b255be6f3ef1b783c01571d641
2021-07-02 21:18:10 +00:00
Yogisha Dixit ba28286260 Merge "Log widgets source." into sc-dev am: f9acf1d5d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879

Change-Id: I2fa39b66ca31549f7754657b7d3bde6bdf8a5f59
2021-06-30 18:33:44 +00:00
Yogisha Dixit 658c5dafd4 Log widgets source.
Test: manual
(1) Upgrading to new DB version is successful (no errors thrown in logcat)
(2) Widgets that were added with the old DB version have CONTAINER_UNKNOWN as their source container
(3) Widgets that are added with the new DB version still log source container after reboot
Bug: 185778648
Change-Id: Iaa38f0be6bc4cb0d29842f9a2ea0d08de000c930
2021-06-30 17:48:14 +00:00
Steven Ng 755c2c54c7 Merge "Use category icon for pending conversation widgets" into sc-dev am: d35dcdec05
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15142493

Change-Id: Id2b6a1429d1b8f84e901fffc0e669c357888d9be
2021-06-29 23:16:56 +00:00
Steven Ng d35dcdec05 Merge "Use category icon for pending conversation widgets" into sc-dev 2021-06-29 23:15:04 +00:00
Steven Ng 12f7a59e5c Use category icon for pending conversation widgets
Fix: 192333050
Test: Manual
Change-Id: Ie3895cd4747f1bec1c8ca9af82347bb0eafa7415
2021-06-29 18:04:09 +01:00
Sunny Goyal 925311975e Merge "Remove expensive logging." into sc-dev am: 2d6d8f890a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15112728

Change-Id: I0432590d39862c7efd312b760c64e4632fe170fc
2021-06-29 00:08:40 +00:00
Hyunyoung Song 587ab6b6bc Merge "Don't use ProxyActivity when launching from SearchActionItemInfo intent" into sc-dev am: c2e05c1df5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15105731

Change-Id: I55f81d6765381dd306e0cc56a13abb0c1a72aa36
2021-06-29 00:08:04 +00:00
Sunny Goyal 2d6d8f890a Merge "Remove expensive logging." into sc-dev 2021-06-29 00:05:12 +00:00
Hyunyoung Song 878dedfb84 Don't use ProxyActivity when launching from SearchActionItemInfo intent
Bug: 188490184
Test: Manual
Change-Id: I9b1b17dfb7e896025a01245414cdab11cf3125cb
2021-06-28 06:34:48 -07:00
Schneider Victor-tulias 9617332f60 Remove expensive logging.
Removed expensive logs added for debugging. Removed unused code.

Fixes: 168788486
Test: none
Change-Id: I0579275633361d2d67399c773e6376af74c9f1b1
2021-06-25 11:48:15 -07:00
Sunny Goyal 49537a8942 Merge "Simplifying Launcher binding callbacks" into sc-v2-dev 2021-06-22 03:42:28 +00:00
Steven Ng 99db0b2bd1 Merge "Copy minSpanX & minSpanY when copying from an existing ItemInfo" into sc-dev am: 95c969530c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15046761

Change-Id: Icb87afa869ba70652911b779ec8163fc12f2ba92
2021-06-21 19:58:41 +00:00
Steven Ng 7b27e7d061 Copy minSpanX & minSpanY when copying from an existing ItemInfo
Test: Drop Gmail widget to home screen and configure it. Then, drop
      the widget to a home screen that doesn't have sufficient space
      to accommodate it. The gmail widget can't be dropped to that
      home page and is returned to its original position.
Fix: 190582606
Change-Id: I177c09562d059b658e835cbb7fdde0d7bc6565d2
2021-06-21 15:38:26 +01:00
Stevie Kideckel 50820e1fb5 Merge "Load widget preview images before adding the rows to the adapter" into sc-dev am: dd19a24769
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14965044

Change-Id: If6b6e437f558922aa0f047c4ce01bb424a0045ae
2021-06-18 22:44:39 +00:00
Stevie Kideckel dd19a24769 Merge "Load widget preview images before adding the rows to the adapter" into sc-dev 2021-06-18 22:37:32 +00:00
Stevie Kideckel a093523299 Load widget preview images before adding the rows to the adapter
This allows for smooth animations as the items will have their full
height resolved

Bug: 190892517
Test: verified locally
Test: CachingWidgetPreviewLoaderTest
Change-Id: I86afc6951a4cc82ae45e63795791d259a3bb3cda
2021-06-18 19:18:29 +00:00
Steven Ng 2c1fb29d26 Merge "Log widget dimensions before deleting a widget violating min size" into sc-dev am: 21780405ac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15015050

Change-Id: I8e2b4160bef59aa17f131a384642975eb0bfbd2c
2021-06-18 10:38:35 +00:00
Sunny Goyal 4a48a988c8 Simplifying Launcher binding callbacks
> Making all methods as default
> Removing obsolete logic around synchronous binding
> Removing some UI dependencies from bind callbacks

Bug: 187353581
Test: Manual
Change-Id: I0d2bbb060af2cab7c64541d7695055629dfaf0b8
2021-06-17 15:21:01 -07:00
Steven Ng b50d747d20 Log widget dimensions before deleting a widget violating min size
Test: N/A
Bug: 191223844
Change-Id: Id909ee19be1a1c7d70a09643422d9ed62a2d82a9
2021-06-17 21:13:17 +01:00
Stevie Kideckel f12eca67b2 Merge "Refresh widgets in the model when packages change" into sc-dev am: 10d4edade1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15012535

Change-Id: I5167f8507164897fb4df07c98c8b49fdd5c41152
2021-06-17 15:19:11 +00:00
Stevie Kideckel 10d4edade1 Merge "Refresh widgets in the model when packages change" into sc-dev 2021-06-17 15:04:01 +00:00
Stevie Kideckel 69af278f8a Refresh widgets in the model when packages change
Fix: 191163748
Test: local sample app
Change-Id: Ic09ad11cabf6efa471fb6e685cb255c4a17493ee
2021-06-17 13:08:53 +00:00
TreeHugger Robot ed7d1c052e Merge "Fix broken app icon on restart during install." into sc-dev am: 3115a4380b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15003917

Change-Id: I46100f030897500f8eeac3fe2421fbb515ac06ae
2021-06-17 01:14:43 +00:00
TreeHugger Robot 3115a4380b Merge "Fix broken app icon on restart during install." into sc-dev 2021-06-17 01:11:53 +00:00
Schneider Victor-tulias bcd72a7b32 Fix broken app icon on restart during install.
Fixes: 186610233
Test: manual with backup/restart and restart during install
Change-Id: Ic64bd98758bc2e1a2a1562579cb25de02faa624c
2021-06-16 16:47:45 -07:00
Schneider Victor-tulias f6ae45e46d Merge "Skip item infos that fail session info verification." into sc-dev am: e00d88e32a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14792907

Change-Id: I1014a006546982860e519dc1d23dd2321e86277e
2021-06-15 21:18:03 +00:00
Schneider Victor-tulias 12e9345f4f Skip item infos that fail session info verification.
trichromelibrary.canary is failing session info verification, but is still being added as blank icon on the workspace in some cases. Added logic to skip apps that fail this verification until the root cause can be found.

Bug: 168788486
Test: none

Change-Id: I8a7fe76f321de493b2c6c67ba6922eae23067ff3
2021-06-15 12:12:07 -07:00
Andras Kloczl dbf577af46 Add left widget panel to Launcher home when unfolded
Test: manual
Bug: 175939730
Change-Id: I9831e7fa95084db12953ec7cb2eb725e7549e01d
2021-06-14 12:22:05 +02:00
Steven Ng 0ed1b41464 Merge "Exact widget sizes functionalities into an utility class" into sc-dev am: 84fe7e3a1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14881307

Change-Id: I5202727f975ce463179674cd54ba8d4b75063f9d
2021-06-08 19:12:12 +00:00
Steven Ng 22b6039270 Exact widget sizes functionalities into an utility class
Test: resize widget, move widget, add widget.
Bug: 189975670
Change-Id: Ia0bc2297891e1cfa33697e985064db5d1dcdfc8b
2021-06-08 11:42:48 +01:00
Andras Kloczl 55edfe55f7 Add two panel home support for page binding logic
There's a logic which prioritizes the binding for the
current page and defers the other pages' binding.
If two panel home is enabled, we want to bind both pages
together. LauncherPageRestoreHelper has been created to
contain the logic for persisting restoring and calculating
which pages to load immediately.

Test: manual + run LauncherPageRestoreHelperTest robo test
Bug: 174464691
Change-Id: I57ac3f7150303b95b272e922f44bda26f9d5ce2a
2021-05-24 23:22:06 +02:00
TreeHugger Robot 50308f3750 Merge "Fixing Launcher preview leaking surface and memory" into sc-dev 2021-05-21 05:51:08 +00:00
Winson Chung bd2fa26bda Tweak ordering of first match search
- Tweak iteration for finding first match, go by operator priority and
  check each cell layout by order to return the first view that matches
- Also reset the launch cookie in cases where we're launching a task
  that doesn't support cookies (ie. via prediction), otherwise we may
  still try to associate it with the last launched cookie later

Fixes: 187720286
Test: Swipe up from various icon types across hotseat/workspace
Change-Id: I71c4c13c442b0884b2247589685f976eaaeb30a4
Signed-off-by: Winson Chung <winsonc@google.com>
2021-05-20 14:50:33 -07:00
Sunny Goyal df4241ca4e Fixing Launcher preview leaking surface and memory
> Closing existing preview if a new request comes for same host token
> Closing in-memory icon db when closing preview
> Removing unnecessary wait blocks on UI thread and rendering
  view asynchronously
> Fixing preview loading failing on LauncherAppState access

Bug: 186712316
Bug: 187140897
Test: Manual
Change-Id: I045930b007e5dc015320224a197eee20a8354d17
2021-05-20 21:37:28 +00:00
Yogisha Dixit 07449132fb Merge "Log widget features." into sc-dev 2021-05-15 15:07:40 +00:00
Yogisha Dixit 0b15c7ee07 Log widget features.
Design doc: go/widgets-logging
Note that this doesn't log dynamic colors yet. I'll work on that in a
follow-up CL.

Bug: 185778648
Test: manual
Change-Id: I04249ef267907b4112c220fb206e077d1bee783a
2021-05-15 00:26:41 +01:00
Hyunyoung Song 1553f4dfae Merge "Revert "Don't crash on dialer app target search results"" into sc-dev 2021-05-11 23:13:13 +00:00
Sunny Goyal c86eb1abf4 Ignoring invalid deep shortcuts during load
Bug: 182728800
Test: Manual
Change-Id: I880c2c8898f7a968024bf7b95e763f4293ee19a0
2021-05-07 16:06:20 -07:00
TreeHugger Robot e227451142 Merge "Updated launcher logging." into sc-dev 2021-05-07 16:26:37 +00:00
Hyunyoung Song a1b7851b53 Revert "Don't crash on dialer app target search results"
This reverts commit 67edf1654c.

Reason for revert: this was temporary launcher side fix until aiai 
proper fix was made and dropped to the system image. 

Bug: 186412929
Change-Id: Idd3abe3fe2104c316aeff16e11d8110dfee7e0d1
2021-05-06 21:55:51 +00:00
Schneider Victor-tulias 344b200710 Updated launcher logging.
Updated logging to help track down b/168788486

Bug: 168788486
Test: manual
Change-Id: I064f0eb70f0281fb09083b95c321857d17e31a7d
2021-05-06 21:39:05 +00:00
Sunny Goyal b47172bc4e Linking various settings that control icon cache to icon state
Also separating icon provider for recents from Launcher as it used a fixed size

Bug: 183641907
Test: Verified on device
Change-Id: I6ea3caa0066d1483bfb8a81f0e8aaa472c813afe
2021-05-05 23:05:38 -07:00
TreeHugger Robot e80a0caa81 Merge "Don't crash on dialer app target search results" into sc-dev 2021-05-05 07:08:12 +00:00
Hyunyoung Song 67edf1654c Don't crash on dialer app target search results
Bug: 186412929
Test: manual
Change-Id: Ic1ab6e212d36ca1f711f51d047e4d62106bf0680
2021-05-04 22:29:33 -07:00