Commit Graph
1470 Commits
Author SHA1 Message Date
Jerry Chang 331f46fab3 Accept snapshot list when cancelling recents animation
Bug: 200813008
Test: enter overview after activated split screen, observed task
      thumbnails showing with correct bounds after roation.
Change-Id: Ifea17d2c685d16db111c4fab88e131595254b9a5
2021-11-08 09:55:43 +08:00
Ryan Lin 0ee6940bd0 Merge "DO NOT MERGE Fix the cutout of magnification border" into sc-v2-dev 2021-11-03 05:24:27 +00:00
Vinit Nayak 874ea446c9 Merge "Revert "Align OverviewActionsView for 3 button taskbar"" into sc-v2-dev 2021-11-03 05:04:32 +00:00
ryanlwlin 571df892f7 DO NOT MERGE Fix the cutout of magnification border
If the window is unmagnifiable, it might cause the cutout of
magnification region.
To fix it, we set the flag when the touchable region is not the
entier window frame.

Bug: 196510717
Test: manual test on gestural and 3-button navigation
Change-Id: Ida2bb5bf120038ac9153e12790b93bdec195adbc
2021-11-03 10:50:09 +08:00
Vinit Nayak 3fabe054c2 Revert "Align OverviewActionsView for 3 button taskbar"
This reverts commit 97d64ea8a1.

Reason for revert: b/204891006

Change-Id: I9d40a5c8c9bce6b818779ebaf748bb9bd9231caf
2021-11-02 22:08:33 +00:00
Vinit Nayak ac24e7f6f0 Merge "Align OverviewActionsView for 3 button taskbar" into sc-v2-dev 2021-11-02 05:37:45 +00:00
Vinit Nayak 97d64ea8a1 Align OverviewActionsView for 3 button taskbar
Bug: 189807374
Change-Id: I028ae31b98e28bc372f0148a28755d067fe50678
2021-11-02 01:13:02 +00:00
TreeHugger Robot 651b93bb53 Merge "Do not use shared lib resources" into sc-v2-dev 2021-11-01 20:40:43 +00:00
Jonathan Miranda 9b85616119 Merge "Remove PROTOTYPE_APP_CLOSE feature flag and associated code." into sc-v2-dev 2021-11-01 18:35:44 +00:00
Nick Chameyev 5f11bf60a8 Do not use shared lib resources
Temporary removes usages of SysUI shared
resources as it leads to crashes in Launcher
tests.

Bug: 204727471
Test: install launcher, try autorotate suggestion
Change-Id: I1e3c1f5b331a22a753acc3fe0ee544d50fba5c18
2021-11-01 15:49:54 +00:00
Nick Chameyev 0288d2e8bb Move floating rotation button handling to Launcher
Moves handling of floating rotation button when navigation
bar is not created to the launcher. This button was not
showing when taskbar is visible as it was initialized in
navigation bar (which is not created for large screens).

Bug: 200103245
Test: rotate phone when autorotate disabled on inner screen
Test: showing rotate suggestion when gesture nav enabled/disabled
Change-Id: I13dd555bcd811f1524be7ab9ad51b2b012b3b749
2021-11-01 10:36:34 +00:00
Jon Miranda 029a644a6e Remove PROTOTYPE_APP_CLOSE feature flag and associated code.
Flag was never enabled, safe to remove.

Bug: 200999899
Test: manual
Change-Id: Ie2646d8c4b9a1c40fac1bfd7dadf4ec714171aec
2021-10-29 16:07:29 -07:00
Tony Wickham 5a5a926945 Recreate taskbar when dark mode changes
Also dispatch sysui flags to all controllers upon recreate, not just NavbarButtonsViewController. Additionally, tell the controllers to skip the animation due to the flag changes if it's fromInit.

Test: Enable themed icons, switch dark theme in quick settings, ensure taskbar updates
Fixes: 204403933
Change-Id: Ic43a50cf0456175f9beba5c29360440f051cbd2d
2021-10-28 17:49:03 -07:00
TreeHugger Robot da86c0e64d Merge "Update taskbar drag and drop treatment" into sc-v2-dev 2021-10-28 20:54:09 +00:00
Tony Wickham 89ef745d1c Update taskbar drag and drop treatment
- Disable the FastBitmapDrawable icon instead of setting it to invisible
- Suspend auto hide during drag and drop (moved to new TaskbarAutoHideSuspendController)

Test: Drag and drop from taskbar and ensure the original icon stays in place but desaturated
Test: Open immersive app, drag and drop from taskbar and ensure taskbar doesn't hide before drop
Fixes: 200816442
Change-Id: I4b895efd043be75e7e7034bd75e751ffdd2cfdd7
2021-10-28 11:43:49 -07:00
bquezada e12b321d5f Change AppTargetId for launcher events to align with other AppTargetId's.
Bug: 202535375
Test: Manual
Change-Id: I0c28f7f64935fdaf08edb7781e4e7378a068e8e6
2021-10-28 17:52:02 +00:00
Alina Zaidi 29c3f23be5 Merge "Send widget added and removed events to AiAi." into sc-v2-dev 2021-10-28 16:45:22 +00:00
Schneider Victor-tulias 9188b6b993 Update the hotseat edu layout for foldable devices.
Test: ran the hotseat edu on folded and unfolded foldable device in portrait and landscape mode and in three-button and gesture nav mode. ran hotseat edu on regular phone
Fixes: 203734732
Change-Id: Iea2140c8241cdea60cb5db37fbfb7f7701d63bd6
2021-10-27 17:48:46 +00:00
Tracy Zhou c6bdd9243a Merge "Delete TaskbarStateHander" into sc-v2-dev 2021-10-27 02:11:12 +00:00
Pablo Gamito aae8a2a2a5 Merge "Set custom task transition spec when taskbar is visible" into sc-v2-dev 2021-10-26 21:32:16 +00:00
Tracy Zhou 72f1afcf02 Delete TaskbarStateHander
Bug: 204220602
Test: N/A
Change-Id: I6c26b4d3b8acb35750be56986555350e84f31ecb
2021-10-26 13:26:27 -07:00
TreeHugger Robot 3bd6b8bf81 Merge "Make sure distinct widgets items are used when mapping widget component names to widget items." into sc-v2-dev 2021-10-26 18:01:48 +00:00
Pablo Gamito 77d3cab287 Set custom task transition spec when taskbar is visible
This is to ensure that the task to task animations look good when the
taskbar is visible (the transition background is the same as the taskbar
color, the taskbar overlay rounded corners are hidden, and the task
animates above the taskbar so it's rounded corners are visible during
the animation and not hidden behind the taskbar).

Test: Open tasks from other tasks to trigger task to task animations and
see if they look good
Bug: 200675009
Bug: 196387647

Change-Id: I8e46718829c0e6541a5c1b1a3a156285aeecd30a
2021-10-26 14:56:27 +02:00
Alina Zaidi 987221a1cc Send widget added and removed events to AiAi.
-Pass the widgets on workspace as an extra List<AppTargetEvents> while
 creating prediction session.
-Notify the session about widget added/removed events after creation.

Bug: 186648032
Test: Manually checked events are received
Change-Id: I4de6c011a1e24c129a3e995ddba16bfc55074939
2021-10-26 12:29:48 +01:00
Tony Wickham add188f339 Merge "Hide taskbar background when notification shade is expanded" into sc-v2-dev 2021-10-26 02:56:47 +00:00
TreeHugger Robot c6649763a7 Merge "Fix launching window bounds for immersive apps" into sc-v2-dev 2021-10-25 23:20:47 +00:00
Tony Wickham 232e9a4631 Hide taskbar background when notification shade is expanded
- In 3 button mode, don't hide the background but do ensure nav buttons are translated down when swiping to notificaitons from the home screen

Test: swipe down notifications, background hides in 0 button mode but not in 3 button mode
Fixes: 199163951
Change-Id: Ic70adc7d67b2ab7c92a2d5d846b9b259d1bd7bfc
2021-10-25 13:44:09 -07:00
Alina Zaidi fa37c6742e Make sure distinct widgets items are used when mapping widget component
names to widget items.

This is to prevent a crash on duplicate key when creating map.

Bug: 204065759
Test: Enabled flag and got no crash
Change-Id: Ice9f93af76c02eeba53c934687358ed806c60b60
2021-10-25 16:10:45 +01:00
Alex Chau 39da1f78da Fix TaskView jumping caused by split select
- Never apply split select translation to grid overview, instead use dismiss translation to make space to split placeholder to minimize motion and avoid janky double movement
- Ensures snapping to last task for end of grid split cases
- Adjust mCurrentPageScrollDiff due to coordinate shift
- Use longGridRowWidthDiff to shift all task to make space for split placeholder
- Also fixed a bug that split translation isn't reset if entering overview immediately after exit

Bug: 200537815
Test: manual
Change-Id: Ie1b57c34ce4bb079f898ba5b7c3464a714021847
2021-10-25 15:38:34 +01:00
Tony Wickham 3f6e3f0650 Stash taskbar in fallback recents
Test: Swipe to Overview with 3P launcher as default, watch taskbar stash
Fixes: 188790554
Change-Id: Id9fdcd715fc50872e3a96f102053a9a99859b482
2021-10-21 10:53:48 -07:00
Tony Wickham 8791e7de11 Add FallbackTaskbarUIController
- Refactor TaskbarManager to accept StatefulActivity instead of BaseQuickstepLauncher
- Update the new StatefulActivity in onOverviewTargetChange()
- Cleanup LauncherTaskbarUIController a bit to avoid initializing TaskbarActivityContext, TaskbarDragLayer, and TaskbarViewController in the constructor, and instead get these from mControllers after init()

Test: No change in behavior
Bug: 188790554
Change-Id: Ic4d69d73deb6dada416876eb265db57803c3adfd
2021-10-21 10:53:46 -07:00
Nick Chameyev 8523412470 Merge "Do not animate statusbar unfold when in portrait orientation" into sc-v2-dev 2021-10-21 10:02:00 +00:00
Schneider Victor-tulias e9bd364390 Merge "Generalize the icon popup menu types." into sc-v2-dev 2021-10-20 18:32:56 +00:00
Schneider Victor-tulias 16e04e29d2 Generalize the icon popup menu types.
Generalized popup menu types and logic to allow wider uses outside of launcher.

Bug: 198438631
Test: long pressed launcher icons and pressed menu options
Change-Id: Iadcbb1796496c0061dcee362784e426ff55dc94a
2021-10-19 16:06:16 -07:00
Sunny Goyal 2a528a43c1 Delaying taskbar loading until user setup completed
> Also keeping it stashed while all-set activity is visible
> Creating a shared state (simiar to saved instance state) for taskbar
> Keeping taskbar stashed while all-set activity is visible

Bug: 194786060
Bug: 201782272
Test: Manual
Change-Id: Iab5e082243a206772266aece62d3028f5acb6400
2021-10-19 12:38:02 -07:00
Tracy Zhou fc0b21596f Merge "Track LauncherState for task bar stashing better" into sc-v2-dev 2021-10-19 07:06:14 +00:00
Mady Mellor 20c05fbd4c Merge "Add a scrim to taskbar for bubbles expanded state" into sc-v2-dev 2021-10-18 19:35:05 +00:00
Tracy Zhou ae88197e5f Track LauncherState for task bar stashing better
- Animate in onStateTransitionStart
- Commit in onStateTransitionComplete

Fixes: 193938970
Fixes: 200765631
Fixes: 201644899
Test: Go home from overview; Go to all apps from home; Go to overview from home
Change-Id: I393022c86f09806fea29fb5bc7191304b473f231
2021-10-18 10:51:51 -07:00
Tony Wickham e202a64e56 Merge "Fix taskbar layout issues in setup wizard" into sc-v2-dev 2021-10-18 16:01:38 +00:00
Vinit Nayak 2a7c0c4ed8 Merge "Align 3 button nav with hotseat" into sc-v2-dev 2021-10-15 15:25:16 +00:00
Nick Chameyev ae818dfe42 Do not animate statusbar unfold when in portrait orientation
Disables unfold animation for statusbar when it is
perpendicular to the screen fold.
Moves ScopedUnfoldTransitionProgressProvider from launcher
to shared SysUI/Launcher code

Bug: 201518277
Test: manual
Test: atest com.android.systemui.unfold.util.NaturalRotationUnfoldProgressProviderTest
Change-Id: I1417ee89b132b541d5a3ed0e5ddcbc56d827da96
2021-10-15 14:06:42 +01:00
Tony Wickham bb6e278f14 Fix taskbar layout issues in setup wizard
- Align nav buttons (only back is enabled) to start instead of end
- Don't animate from init()
- Provide 0 contentInsets.bottom
  - Auto-stash the taskbar during setup
  - Hide the stashed handle by adding an alpha channel for home disabled
  - Report 0 contentInsets when stashed if the handle isn't visible
- Tint nav buttons according to theme

Test: adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity
Bug: 194786060
Change-Id: I4a40501e8aad2a38ec00398efe9ea3dbfa7428cd
2021-10-14 21:50:03 -07:00
Vinit Nayak 74b25ca266 Align 3 button nav with hotseat
* Animate translationY alongside icons
* When device rotates on home, update
translationY
* Add padding to contextual buttons to center
it

Bug: 189807374
Change-Id: I149ef25df570fb1fd385f1da960c827105ff975d
2021-10-14 18:32:35 -07:00
Vinit Nayak 22762d91cd Merge "Suspend auto-hiding taskbar when folder is open" into sc-v2-dev 2021-10-14 19:11:53 +00:00
Tony Wickham 615cf6c431 Fix launching window bounds for immersive apps
Test: Open an immersive app (e.g. fullscreen YT video), ensure it fills
the screen; open a non-immersive app (e.g. Calculator), ensure it only
fills up to the top of the taskbar.
Fixes: 200036592

Change-Id: Id815bbc8140cbaf1e61ac587ae1f1325e7ec5b72
2021-10-13 21:17:16 +00:00
TreeHugger Robot 60c64adeed Merge "Sending Launcher resume event to app predictor" into sc-v2-dev 2021-10-11 21:22:50 +00:00
Alex Chau 02150305f9 Fix split select scroll range when TaskView aren't shifting
- There is an edge case that when ClearAllButton is visible, no split translation is applied, the offset adjustment needs to be calculated differently in that case
- Also, apply the scrollOffset to the TaskViews / ClearAllButton instead of updating min/max scroll

Bug: 200537659
Test: Split right in grid, split left with clear all button, split left without clear all button
Change-Id: I869c448bbec6aec8fa070e47193a692be6f75e84
2021-10-11 19:02:28 +01:00
Sunny Goyal 1b6d43b13e Sending Launcher resume event to app predictor
Bug: 202535375
Test: Manual
Change-Id: I1618a5ed973b9d4f898442647e3e197ed4935aa4
2021-10-08 16:21:56 -07:00
Mady Mellor 5fdf2d08fc Add a scrim to taskbar for bubbles expanded state
When bubbles are expanded a scrim is shown on top of
everything. Taskbar is layered above bubbles but we still
need the scrim to show on top of it. This CL adds the
ability to show a scrim on taskbar.

The scrim is a view in the taskbar drag layer and is
placed between the taskbar and the nav buttons so that
it can block touches / scrim the taskbar but still allow
the nav buttons to be visible and touchable.

Add interpolators for alpha matching what bubbles is using.

Test: manual 1 - expand bubbles while taskbar is visible
                 => observe scrim
               - open manage menu
                 => observe darker scrim
             2 - check that taps on scrim collapse manage
                 menu or stack
             3 - check there isn't a scrim while taskbar is
                 stashed and bubbles / manage menu are open
             4 - check that three button nav works while
                 bubbles are expanded
Bug: 197139718
Change-Id: I94c4ecd07f81b2bad55c38525d60f493d3c1f9d8
2021-10-08 14:55:43 -07:00
Tony Wickham 1bd4bf7ff1 When taskbar would be stashed in 3 button mode, hide icons instead
In 0 button mode, stashing morphs the icons into the home handle. In 3 button mode, that doesn't make sense, but we should still hide the icons (and just keep the 3 nav buttons). You still can't manually stash via long press in 3 button mode, but this will address other states where we automatically stash the taskbar when we want to hide the icons from users (e.g. when pinning an app).

Test: Pin an app from overview in 3 button mode, ensure the taskbar icons disappear until unpinning
Bug: 190192993
Change-Id: I499c59bd9d7871ff64696b67065cf9d4863222a5
2021-10-07 23:29:41 -07:00