Commit Graph
13048 Commits
Author SHA1 Message Date
TreeHugger Robot 30fedb9a4f Merge "Update all home screen widgets size upon workspace inset change" into sc-v2-dev am: 4c96d446a5 am: 5d9278bcec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16191333

Change-Id: Ic1407c141713259701844452cb4185dc0a06891e
2021-11-04 18:28:22 +00:00
TreeHugger Robot 4c96d446a5 Merge "Update all home screen widgets size upon workspace inset change" into sc-v2-dev 2021-11-04 17:39:06 +00:00
Thales Lima 238f630001 launcher: use a different task menu for foldables
Foldables use a different menu from phones, positioned either to the
right or left of the app icon, and display an arrow. Since TaskMenuView
is very specific for handhelds, it was cleaner to create another class
to handle foldables case extending from ArrowPopup.

This creates a working menu, the correct style will come in later CLs.

Bug: 193432925
Test: open Overview and tap the app icon
Change-Id: Icb068954e1e20a52d80c16c52d8e38ce9a181a8b
2021-11-04 14:40:47 +00:00
Steven Ng 91b46d1ba3 Update all home screen widgets size upon workspace inset change
Test: Add a clock widget to the home screen. Then, change the navigation
      gesture. Go to home screen to confirm the clock widget is rendered
      as expected in the portrait. Then, rotate the device to landscape.
      Confirmed the clock widget is rendered correctly in the landscape.
Fix: 202837404
Change-Id: I93b70c53f10c8150131b183defc8baf01e5924a8
2021-11-04 12:00:03 +00:00
Winson Chung 7047a1d80e Merge "Add some logging for taskbar recreation" into sc-v2-dev am: 3b5dddbce1 am: 00ad5612b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16184040

Change-Id: Id9e4825ae08c2d9ab48ce67a557c107c337fa310
2021-11-04 00:07:04 +00:00
Winson Chung 3b5dddbce1 Merge "Add some logging for taskbar recreation" into sc-v2-dev 2021-11-03 23:41:07 +00:00
Winson Chung 067faf3bbe Add some logging for taskbar recreation
Bug: 201305599
Test: Manual
Change-Id: I437fe3226657ebe7b5507146fbe5e7f32e2e2fce
2021-11-03 11:17:44 -07:00
Benno Lin 413a663096 Merge "Update TAPL to operate on folder icons." into sc-v2-dev am: 8f083ccce3 am: 062300e0eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15757342

Change-Id: Ia3d6ef0cb11913fe4f81933be5a34cea1746f06e
2021-11-03 02:51:41 +00:00
Benno Lin 8f083ccce3 Merge "Update TAPL to operate on folder icons." into sc-v2-dev 2021-11-03 02:14:46 +00:00
Zak Cohen 42ff088123 Merge "Add temporary logging to try and debug: b/202414125" into sc-v2-dev am: 427113fa58 am: 78515f70cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16177152

Change-Id: I2144a5749005cf28a85cd8dd0d8d4ceb1b006aee
2021-11-03 00:05:22 +00:00
Zak Cohen 427113fa58 Merge "Add temporary logging to try and debug: b/202414125" into sc-v2-dev 2021-11-02 23:33:31 +00:00
Zak Cohen 21f6189cd5 Add temporary logging to try and debug: b/202414125
Bug: 202414125
Test: Local
Change-Id: I641f9877972f3f584e5fc618d89c65c52f0d1da0
2021-11-02 14:17:15 -07:00
Alex Chau 7f9148906c Merge "Add logging of draw / DeviceProfile params for a crash" into sc-v2-dev am: 27794e8fa3 am: 03d414bc8d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16174366

Change-Id: I1b9187fe37e733a3e6d8ce476610e1e9ee472cd4
2021-11-02 19:27:04 +00:00
Alex Chau 27794e8fa3 Merge "Add logging of draw / DeviceProfile params for a crash" into sc-v2-dev 2021-11-02 18:26:58 +00:00
Alina Zaidi 177c63f153 Merge "Use equals() to compare UserHandle when building LauncherAtom#ItemInfo." into sc-v2-dev am: 6180273e1f am: 3a0cad3868
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16166973

Change-Id: I91d374bf0b91c18e240f0fafc6eff005b0b2ba4c
2021-11-02 16:54:42 +00:00
Alina Zaidi 6180273e1f Merge "Use equals() to compare UserHandle when building LauncherAtom#ItemInfo." into sc-v2-dev 2021-11-02 16:27:56 +00:00
Alina Zaidi 08c3e8f526 Use equals() to compare UserHandle when building LauncherAtom#ItemInfo.
Bug: 204756057
Test: Manually verified correct behave through logs
Change-Id: Ic314e38978893984bac89988bfc3229a21d0214e
2021-11-02 14:10:37 +00:00
Alex Chau 05659a3d10 Add logging of draw / DeviceProfile params for a crash
Bug: 203530620
Test: manual
Change-Id: I376157ee3f688b16a05b59a0093f06519533f6c7
2021-11-02 13:11:05 +00:00
Jonathan Miranda 610f4fd798 Merge "Remove PROTOTYPE_APP_CLOSE feature flag and associated code." into sc-v2-dev am: 9b85616119 am: 470c4ffe3b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16151440

Change-Id: I4cf8275faf7a55e3b24aa24175599d32b5bd2098
2021-11-01 19:20:12 +00:00
Jonathan Miranda 9b85616119 Merge "Remove PROTOTYPE_APP_CLOSE feature flag and associated code." into sc-v2-dev 2021-11-01 18:35:44 +00:00
Jon Miranda 029a644a6e Remove PROTOTYPE_APP_CLOSE feature flag and associated code.
Flag was never enabled, safe to remove.

Bug: 200999899
Test: manual
Change-Id: Ie2646d8c4b9a1c40fac1bfd7dadf4ec714171aec
2021-10-29 16:07:29 -07:00
Rajeev Kumar 5cc195f449 Merge "P2P App Sharing: Gray out disabled SystemShortcut" 2021-10-29 22:32:44 +00:00
Jon Spivack 688621498a P2P App Sharing: Gray out disabled SystemShortcut
The Share App system shortcut is disabled for apps that are deemed unshareable. This updates the UX to gray out the shortcut instead of hiding it. When the user clicks on the grayed out shortcut, a Toast message is displayed. This update also enables the shareability check.

In order to properly gray out the shortcut, this also fixes a bug with BubbleTextView in which ColorStateLists weren't applied correctly.

Bug: 202556634
Bug: 204495363
Test: Manual (observed UX on Wembley device in regular and dark themes)
Test: m -j RunLauncherGoGoogleRoboTests
Change-Id: Ieb04baf8c9cb9d325119cb97fceb96f2fc5a62ff
2021-10-28 19:30:31 -07:00
TreeHugger Robot 5562e7e773 Merge "Fixing the possibility of opening multiple WidgetsFullSheet" into sc-v2-dev am: 01f8b561b3 am: a7a257c8d6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16118178

Change-Id: I11b81420faafed3f683ff378a5ded34ebe0dc926
2021-10-28 16:59:51 +00:00
TreeHugger Robot 01f8b561b3 Merge "Fixing the possibility of opening multiple WidgetsFullSheet" into sc-v2-dev 2021-10-28 16:20:05 +00:00
Alex Chau cc1e19c3bc Merge "Partially restoring reverted logging" into sc-v2-dev am: 0cc439ab18 am: 9ce7848a8f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16120438

Change-Id: Id7a862358eee66fc8d47ba5a469d731f443a883c
2021-10-28 11:41:18 +00:00
Alex Chau 0cc439ab18 Merge "Partially restoring reverted logging" into sc-v2-dev 2021-10-28 11:10:17 +00:00
TreeHugger Robot a8dacb88e2 Merge "Clean up IllegalStateException for page pairing" into sc-v2-dev am: 0c689ef773 am: 25c40cb0a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16116271

Change-Id: If34f3ef5902eca2710f5cd49097d185c4d1010b3
2021-10-27 11:58:07 +00:00
TreeHugger Robot 0c689ef773 Merge "Clean up IllegalStateException for page pairing" into sc-v2-dev 2021-10-27 11:21:46 +00:00
TreeHugger Robot d81b579fc2 Merge "Fix the fallback logic for shortcut icons when icons are missing" into sc-v2-dev am: e9316d5ba7 am: fa30672ec7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16124501

Change-Id: I7fea7a7151014fedd7671a4d116e878e09e6bf88
2021-10-26 20:40:31 +00:00
Vadim Tryshev 8629be753f Partially restoring reverted logging
ag/15858126 slowed down everything so
that the flake stopped to repro.

Attempting to reintroduce a more
lightweight logging hoping that the flake will
keep reproing.

Test: presubmit
Bug: 195031154

Change-Id: Ib533c22253e367cced1680a6f4d6736087f0837a
2021-10-26 20:00:55 +00:00
Pinyao Ting 35c5755b71 Fix the fallback logic for shortcut icons when icons are missing
The icons of shortcuts in general are not persisted in backup payload
and thus are not available on the new device, apps are reposponsible for
republishing those shortcuts on the new device, with the only exception
being pinned shortcuts, whose icons are stored in launcher.db as a
fallback when icons are not avaialble in the shortcut themselves.

A previous CL unexpected excluded deep shortcuts from loading their
fallback icons in launcher.db, causes pinned shortcut to fallback
further to default droid icons, this CL restores the original behavior.

Bug: 202346722
Test: manual
Change-Id: Ie09becd3a0dc1ca1e7c2573fe1b68b61a58c2091
2021-10-26 18:02:08 +00:00
Sebastian Franco 97503ab4fb Fixing the possibility of opening multiple WidgetsFullSheet
The error is that you can open multiple times the view for
selecting widgets for the Home Screen (i.e. WidgetsFullSheet.java)
but only when using a keyboard by using the command ctrl+w
creating a new instance every time you use it. To fix this
I added a singleton pattern so that only one instance of
WidgetsFullSheet.java can be open at any given point.

Test: Manually Tested
Fix: 196704061
Change-Id: I7a364ee5e746e77455da326a21aff6830ac18e8c
2021-10-26 11:26:21 -05:00
TreeHugger Robot 74f7d5e0b8 Merge "Fix the remove button icon not centered when the home screen is in landscape." into sc-v2-dev am: 8935b22cd7 am: 763405dfca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16087348

Change-Id: I29b9912fdf63a922b5cf8904be768c1e481b5e6c
2021-10-26 00:35:36 +00:00
TreeHugger Robot 8935b22cd7 Merge "Fix the remove button icon not centered when the home screen is in landscape." into sc-v2-dev 2021-10-26 00:06:37 +00:00
Alex Chau 46306e31b7 Merge "Avoid calling getIconResult if recycle is called after request is queued" into sc-v2-dev am: 4941b84717 am: 2a6e9abf6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16118639

Change-Id: I3fc485432c60f815e7cdbdab428b6bb3ff7543dc
2021-10-25 23:54:49 +00:00
Sebastian Franco 63d1a181e5 Fix the remove button icon not centered when the home screen is in landscape.
To fix it I put the bounds of the Icon/drawable when the text is not visible.

Fix: 202811811
Test: Manually Tested.
Change-Id: Ieff54a73e819c4b3a61e28fd76faf93a84b67666
2021-10-25 17:34:11 -05:00
Alex Chau 53c7ed5084 Avoid calling getIconResult if recycle is called after request is queued
Fix: 203582251
Test: atest -c NexusLauncherTests:com.android.launcher3.memory.MemoryTests
Change-Id: Ice1e981e1813df516008be578aa89ee17fb79fab
2021-10-25 21:06:27 +01:00
Alex Chau 920be89b26 Clean up IllegalStateException for page pairing
Fix: 198820019
Test: manual
Change-Id: Ic691f781b20d664c57a26370aae479ab68508303
2021-10-25 15:20:16 +01:00
Benno Lin 5261776d3a Update TAPL to operate on folder icons.
The change updates features listed as follow:

1. Create a new class for folder icon.
2. Implement function to drag a icon to the other.
   (create a folder)
3. Find folders in a workspace.

Bug: 199120092
Test: Launcher3Tests:com.android.launcher3.ui.TaplTestsLauncher3#testDragToFolder
Change-Id: I3044025f8297f6e442446d70238f4b56f38a798a
2021-10-25 11:08:44 +00:00
TreeHugger Robot d3b5b6adf3 Merge "Bugfix where the widget handles appear even when you can't resize it." into sc-v2-dev am: d4df41b78f am: a15ea27e04
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16065847

Change-Id: I75deea59ed5d63b7720b56b30d7c8713b1026d04
2021-10-21 21:14:13 +00:00
TreeHugger Robot d4df41b78f Merge "Bugfix where the widget handles appear even when you can't resize it." into sc-v2-dev 2021-10-21 20:46:37 +00:00
TreeHugger Robot 17f24235e5 Merge "Fixing wrong text spacing bounds" into sc-v2-dev am: a293a864a6 am: 8f8a55817d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16103164

Change-Id: Ibdcdd2f47b3727f5a2c360f7024a92b9fede30d8
2021-10-21 20:29:03 +00:00
Sunny Goyal 486adb03a0 Fixing wrong text spacing bounds
Bug: 203740844
Test: Manual
Change-Id: I68fcab489643acf80759f90736f806ae2852e648
2021-10-21 11:30:18 -07:00
Sebastian Franco 4067f5d4ae Bugfix where the widget handles appear even when you can't resize it.
To fix it I added the following logic condition: if the minimum size of
the widget (`mMinVSpan` vertically) is equal to the maximum size of the
widget (`mMaxVSpan` vertically), then you can't change the size and the
handles shouldn't appear, I did this for both the horizontal handles as
well as the vertical handles.

Fix: 202004006
Change-Id: Ide05231f5712a736129ac6cb2fee358f7c70e371
Test: Manully veryfied.
2021-10-21 17:32:31 +00:00
TreeHugger Robot 53d0921acf Merge "Fix bug with resize frame in Launcher3." into sc-v2-dev am: ea38519fa4 am: 6bfd14613b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16057107

Change-Id: I1c600ea73a6e37bb79794650efa003874703e757
2021-10-20 21:20:24 +00:00
TreeHugger Robot ea38519fa4 Merge "Fix bug with resize frame in Launcher3." into sc-v2-dev 2021-10-20 20:50:17 +00:00
Schneider Victor-tulias c1a99b8712 Merge "Generalize the icon popup menu types." into sc-v2-dev am: e9bd364390 am: e650a048fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16065857

Change-Id: Ibef5acdb235ff1b0f30dd18e90330584ec037fa1
2021-10-20 19:23:18 +00:00
Schneider Victor-tulias e9bd364390 Merge "Generalize the icon popup menu types." into sc-v2-dev 2021-10-20 18:32:56 +00:00
Yogisha Dixit 7b1d25b251 Fix bug with resize frame in Launcher3.
Also updated the tests to check that the resize frame is shown.

Bug: 192655785
Test: AddWidgetTest, AddConfigWidgetTest, manual
Change-Id: Id348f39cec1bebc8ec9ea9f3068f4bda2159eac4
2021-10-20 19:03:14 +01:00