- This makes the suggestion section non-overwhelming
- Currently it shows too many suggestions for user to find any value
- Limiting the height also allows pagination to feel smooth when showing
in categories
Bug: 318410881
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Test: Manual
Change-Id: Iab1f9a15bdd46ee1560734e30551bfb7c8a74a82
Fix: 328639347
Test: Manual - took a video
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I909cca47477d75c2dd9b861e3c7812b9540e6fa1
Ordering changes and some more UI changes in follow-up.
Bug: 318410881
Test: See screenshots
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: I77e7f4dcdda32e2921ae56721cddbe261832f0d8
The change is really for enabling display of categorical suggestions,
so using the same flag.
Bug: 315055849
Bug: 318410881
Test: See screenshots
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: Ia98fdd6b827f31a63264128617f6a16ee0716bcc
When differently-sized widgets OR widgets of same size but not filling
space in previews are shown side by side, the top alignment looks odd.
Besides, in the updated UX, we want them to be center aligned.
Bug: 318410881
Bug: 319152349
Flag: N/A
Test: Screenshot update in cl chain.
Change-Id: I52cd7d6a1b5397a3c4c9dea8b072792b3211a8d3
Here we:
-Move no widgets text outside of the right pane so that we can center it
-setInset and change the clipping of children in the views so that we can fix the padding at the bottom when we have 3 button nav
-create selectedHeader where we keep track of the currently selected header in order to refresh the widgets for the selected header on rotation
-when widgets are bound we check if there are no recommended widgets, and if there aren't we select the first visible header
Fix: 324002996
Fix: 324001940
Fix: 323417968
Fix: 323460545
Fix: 323409306
Test: WidgetPickerImageTest
Flag: NONE
Change-Id: Ibd85cb086bb6c2aede6cf79da0c688a1fdaec4e5
The filter was missing from the refactor in ag/25502473.
There aren't currently WidgetPicker tests that would catch this behavior
but there should be.
Bug: 317452407
Test: Ran existing widget tests, looking at adding work profile tests.
Flag: none
Change-Id: I2ce8464a1c76505bfe7ce8cf4280bb5b576cdb1d
There are test failures when using ConstraintLayout without a known solution, see https://chat.google.com/room/AAAACwktJi8/2OogGWfbLvI. Switching back to a relativelayout to resolve those issues.
Bug: 301918659
Test: WidgetPickerImageTest
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT
Change-Id: I004c2d77ca308d85b29217d4f1e548067126556f
Currently the work widget matcher matches against all
non-foreground user profiles, due to which the work
tab is incorrectly shown in widgets full screen, when
PS is present.
This was missed in ag/25129268 where a bunch of work
matcher fixes were done.
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 312900122
Test: Launcher3 tests
Change-Id: I80d33e851ea3366dc3897bb1f5cc17fcd6b34520
This Cl adds the following:
1. Fixes for Quite Mode check maintained by Launcher
2. Addition of new Quite Mode broadcasts
3. Fixes for determining work profile user correctly.
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I5f6158b213723339e70ff99e66c5f439f5879e12
In some cases the controller can be null if the view is no longer
connected to the window.
Also, this issue seems to only happen in cuttlefish instances so there
might be a weird behaviour going on there but in any case is good to check
for nulls.
Test: No testing require is only null checkin, just making sure it compiles.
Bug: 302869930
Change-Id: I88d6091b57293e9493385185bfeb3e470c9bad84
As described, this is a small prototype to show what the current state of the two pane widget picker would look like in an unfolded foldable.
Bug: 301918659
Test: N/A
Flag: UNFOLDED_WIDGET_PICKER
Change-Id: Ia495de39a470f1dccf70ce53e59c7929525c4a00
We scroll to top when rotating device, which is a behavior that aligns with other AbstractSlideInView's like allApps
Fix: 293203839
Test: verify that when rotating in widget sheet that the suggested widget no longer overlaps with widget list
Flag: no-flag
Change-Id: Icf021a46ae2c2b85b4c55e40cbd2f7e70f83c248
This reverts commit 575a6ef5f8.
Reason for revert: we no longer need the logs since we're going to ignore widget picker image test in UDC-QPR and leave it on in main where it's already not failing
Change-Id: Ib132c9df710031d291d0254fe4bb0acdfeb3f863
The screenshot test is failing in udc-qpr because the search bar is smaller when the screenshot is taken than what the reference image is. Adding logs to figure out what might be causing the search bar to be differently sized in udc-qpr tests (in main WidgetPickerImageTest passes, as well as udc-qpr locally)
Bug: b/294050472
Test: atest WidgetPickerImageTest
Flag: no flag
Change-Id: Ib94773bc411ff97d373af490ca920f6d6ae6cb2d
The PendingAnimation gives us more flexibility than the AnimatorSet.
Test: Manual
Bug: 289290185
Flag: No
Change-Id: I3156a659098c44ce9e6b20e5e79e88742add629a
Subclasses can add more animations to the set to animate other
components in sync with themselves.
Test: Manual
Bug: 289290185
Flag: No
Change-Id: I96d9afe166e243bb0d2a9cecb8158e2e7d431a6c
We need screenshot tests for widget picker to prevent unintended UI changes.
Bug: 268219507
Test: n/a
Change-Id: I405401f5c68bb73bcb7bbd097f507abb1d66ff7e
Bug: 285909636
Test: on first use of widget picker a tooltip edu shows up, rotate from landscape to portrait or vice-versa and make sure widget picker doesn't crash
Change-Id: Iaa066a41633d3efe48b67a867f3f267f613ea5fe
Currently, there's a few sections of the code that are intended to only be reached by tablets in landscape mode that can be reached by unfolded foldables. Here, we fix this so it no longer occurs.
Bug: 277102339
Test: Verify widget picker works correctly on tablet
Change-Id: I1f2bc99072aff6d852f9ce658ab00fa33b9e02b5
Currently the names used for widgets two pane sheet files are similar to full sheet files, just with "_large_screen" added to it. This is not a good name as it can cause confusion. The new name includes "_two_pane" which is more indicative of the actual functionality of these files.
Fix: 276917926
Test: verify widget picker two pane still works
Change-Id: I23cf2a20fc137cc3e99c5fdc90100648a0926368
Currently, the two pane widget picker shows up in unfolded foldables. Here we guard against that.
Fix: 276913797
Test: Verify that widget picker in foldable doesn't have two panel layout
Change-Id: I7b949bdf9b0497c381ea43a4b8b473393ff59039
Bug: 275435999
Test: Verified suggested widgets header doesn't show up unless there are suggested widgets to show
Change-Id: I2ec2ba100d7a6ddc338a36ece75633abba990b2b
Since the regular widget picker and the widget picker for tablet diverge quite a bit, we added a child class for it that extends WidgetsFullSheet.java
There should be no functionality changes with this CL, it's purely changes in code structure.
Bug: 256684299
Test: Turn on LARGE_SCREEN_WIDGET_PICKER flag and verify nothing changes compared to ag/20508230.
Change-Id: Ie0e93534d7b93017cc11a05f67728155d22951f9
-increase width of two pane picker
-center widgets when they're too few to overflow
-make background stretch out all the way to the bottom even when there aren't multiple widgets
-fit many widgets in one row if they fit
Bug: 256684299
Test: open widget picker and notice that all the listed fixes match the last figma added in the bug
Change-Id: Id4e8445f4ffe484c24c04fd9d1b4ffbf93a00bb2
When we added widget picker two pane layout, it broke some tests with the flag on. Here we fix those tests.
Bug: 256684299
Test: AddWidgetsTest and TaplTestsLauncher3#testWidget
Change-Id: I383c754016d82fba51fa0b7b0459cd7e83b274d8
OnBackPressedHandler was mimicking android.window.OnBackAnimationCallback because later one was hidden API to T.
Now that we have moved to U, we can remove the former handler.
Test: manual
Bug: 272797556
Change-Id: Ic5302cfa0a6fb15c4a64bdf5dc331834b1f06f38
This variable is now mutable, making the uppercase format misleading.
For instance, users might assume they can use this value in other
immutable properties, when they really should be accessing the latest
value every time they need it.
Context: https://source.android.com/docs/setup/contribute/code-style#follow-field-naming-conventions
Test: Manual
Bug: 271160958
Change-Id: Iaaa51d9153cb8a7d686c72e1210b1948029dcfd5
Widget picker closes and reopens when switching orientation on phones when it's not necessary. We should only close and reopen widget picker if it's tablet since that's when we want to inflate either the regular widget picker or the two pane widget picker. When we're on a phone, we always want to inflate the regular widget picker, so closing and re-inflating is not needed.
Fix: 271474746
Test: Change orientation in phones vs tablets. Verify that both still work.
Change-Id: I6062b056c4e7675bc830b6884761ec1f2eb20b1d
Previously 'no widgets found' appeared on the left pane, but in large screen landscape we want it to appear on the right pane. Additionally, we added rounded edges to the right pane that turn into sharp edges when we scroll.
Fix: 268558448
Fix: 268557435
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and on tablet landscape mode go to the widget picker and search for a widget that doesn't exist, verify that 'no widgets found' appears on the right pane. Also verify that right pane has rounded corner that turn into sharp corners as we scroll
Change-Id: I6c89c63941e3b0680836828d0c7849d789cbce61
We need to use setSelected in order to add a ripple effect when a header is selected in tablet landscape mode, and to set the style through XML rather than programmatically the way it was done before in the method `setLargeScreenTheme`.
Fix: 268558453
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and verify that when selecting a header there's a ripple effect on that header
Change-Id: I6cab920258a57118430d1e07416508ef36faa56d