Commit Graph
16445 Commits
Author SHA1 Message Date
Treehugger Robot 2ba03e8d11 Merge "Add logs to check which userId is used for workProfile matcher" into udc-dev am: e201480e77 am: 06f1b97214
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23174986

Change-Id: Ib13851f91544921d4e54c9b2977195a46401b751
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-12 00:41:26 +00:00
Treehugger Robot e201480e77 Merge "Add logs to check which userId is used for workProfile matcher" into udc-dev 2023-05-12 00:07:37 +00:00
Jeremy Sim 6b41662ac8 Merge "Fix animation canceling crash bug (short swipe during split select)" into udc-dev am: 7158d2d0e2 am: b13f3456cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146539

Change-Id: I274aa922f51af456ce8b06a857c31f39f8464ded
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-11 23:33:34 +00:00
Sunny Goyal 1758f9db7b Merge "Revert "Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""""" into udc-dev am: c110587dba am: 396abeecaf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23159152

Change-Id: I67919780cb245058f85bb8f048f49c7803f88d57
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-11 23:33:02 +00:00
Jeremy Sim 7158d2d0e2 Merge "Fix animation canceling crash bug (short swipe during split select)" into udc-dev 2023-05-11 22:31:34 +00:00
Sunny Goyal 09905cfa90 Revert "Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""""
This reverts commit bca4e694f0.

Reason for revert: post submit broken

Change-Id: I8afc63b5aa67ee14127f79e2245ef543bff8cf31
2023-05-11 22:22:16 +00:00
Sunny Goyal e3cd579e7d Merge "Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""""" into udc-dev am: 04a6211120 am: d10d3d9aa4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23117443

Change-Id: Ia28b795bec507253d35e39096b761367369202ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-11 22:05:52 +00:00
Vinit Nayak 88a91bbd16 Add logs to check which userId is used for workProfile matcher
Flag: none
Test: compiles
Bug: 243688989
Change-Id: I0a579203cc0c51f7707180b323ed4828f1dea297
2023-05-11 14:55:00 -07:00
Sunny Goyal bca4e694f0 Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""""
This reverts commit 3772b246c2.

Reason for revert: Fixed the test failure

Change-Id: Ibdc9e184fcb32c7caa4ab25d8753a46fa322b703
2023-05-10 17:49:16 +00:00
Thales Lima ed8954c031 Merge "Add feature flag and attribute for responsive grid" into udc-dev am: 0740b7fb43 am: 46cbbc1ab9 am: b39c669938
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22476842

Change-Id: Ic020b4e9769fa325349349064c767a025a011170
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 10:25:21 +00:00
Thales Lima 0740b7fb43 Merge "Add feature flag and attribute for responsive grid" into udc-dev 2023-05-10 09:44:49 +00:00
Xiaowen Lei 4aecca2519 Merge "Add Lifecycle and SavedState support in Launcher ActivityContext." into udc-dev am: 7c8aeffa4e am: 2e55608106
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22608496

Change-Id: Iae78573270d2ab0edc3000791f357eb7b7570cac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 22:42:57 +00:00
Xiaowen Lei 7c8aeffa4e Merge "Add Lifecycle and SavedState support in Launcher ActivityContext." into udc-dev 2023-05-09 22:07:40 +00:00
Fengjiang Li 72b4193a1a Merge "[5/n] Log cardinality to StatsLogManager" into udc-dev am: d382a4880b am: ed42b63508
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23088599

Change-Id: I1c81577a06123a2fcc87c5499e3c173dd3712010
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 22:01:42 +00:00
Treehugger Robot fa6c13a399 Merge "Removing unused wallpaper-scrim feature" into udc-dev am: 386f9796e3 am: e97f1eac9b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23039034

Change-Id: Idd0e898dc95c901bed1eab766a463ce09f2c1784
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 21:37:29 +00:00
Fengjiang Li d382a4880b Merge "[5/n] Log cardinality to StatsLogManager" into udc-dev 2023-05-09 21:33:36 +00:00
Treehugger Robot 386f9796e3 Merge "Removing unused wallpaper-scrim feature" into udc-dev 2023-05-09 20:57:33 +00:00
Jagrut Desai bd31b05cb4 Merge "Taskbar All Apps Icon Shortcuts Popup Accesiiblity" into udc-dev am: 75109c7abc am: d015685ec7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23035380

Change-Id: Idd8519ad62e9e309da909191061cc8e26e5b75be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 17:41:53 +00:00
Xiaowen Lei 3c0f30a2bb Add Lifecycle and SavedState support in Launcher ActivityContext.
And call initCompose() in Launcher.java. Therefore there is no behavior
change for BaseActivity, or other ActivityContext subtypes that don't
call initCompose().

This should work for non-activity subtypes of ActivityContext. It's
likely that the Launcher activity will require more complete supoort for
Lifecycle and SavedState.

Note: In order to test the ComposeView, need to build this CL together
with ag/22461463.

1. `ViewTreeLifecycleOwner.set(..., ...);` is necessary to fix the
   following crash:

java.lang.IllegalStateException: ViewTreeLifecycleOwner not found

This error comes from WindowRecomposer.android.kt
  - http://cs/androidx-platform-dev/compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/WindowRecomposer.android.kt;l=351-354;rcl=5673af1441ebe04c776f528193dfc5f85c0c9a66

2. `ViewTreeSavedStateRegistryOwner.set(..., ...);` is necessary to fix
   the following crash:

java.lang.IllegalStateException: Composed into the View which doesn't propagateViewTreeSavedStateRegistryOwner!

This error comes from AndroidComposeView.android.kt.
  - http://cs/androidx-platform-dev/compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt;l=1178-1183;rcl=5673af1441ebe04c776f528193dfc5f85c0c9a66

3. The lifecycle needs to be STARTED. Otherwise the ComposeView doesn't
   show up in its parent (i.e., isn't drawn).
  - In ComponentActivity, `onSaveInstanceState` starts the lifecycle.
  - In ComposeInitializeImpl (from SystemUI),
    ViewLifecycleOwner.updateState() starts the lifecycle when the
    window is visible and in focus.
The implementation in this CL does the same thing as the
ComposeInitializeImpl.

Bug: 275905704
Test: on device, trigger a card such as the timer
Test: RUN_ERROR_PRONE=True m out/soong/.intermediates/packages/apps/Launcher3/Launcher3/android_common/lint/lint-report.xml
Test: RUN_ERROR_PRONE=True m out/soong/.intermediates/vendor/google/gms/packages/SearchLauncher/SearchLauncher/android_common/lint/lint-report.html
Test: Presubmit
Change-Id: Ieced66ad5238916a82ea13c01f69146bbdcf287a
2023-05-09 09:40:03 -07:00
Jagrut Desai 75109c7abc Merge "Taskbar All Apps Icon Shortcuts Popup Accesiiblity" into udc-dev 2023-05-09 16:19:44 +00:00
Pat Manning a5507b0ec6 Enable flag ENABLE_CURSOR_HOVER_STATES by default in UDC-QPR-1 branch.
Bug: 243191650
Change-Id: I8ce29471e2d1838a2b7b9deee5729474c41865af
Test: manual.
2023-05-09 14:05:03 +00:00
Thales Lima ec5abba93b Add feature flag and attribute for responsive grid
This shouldn't change anything in the grids, only support the creation of responsive grids in the future. For now, to check that the flag works, turn it on and check the dumpsys. There is also a dump test created for this.

Fix: 277064696
Fix: 277064702
Test: DeviceProfileResponsiveDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I1bef87043a100234bd661cd6ac00007fdc654116
2023-05-09 12:06:18 +01:00
Vinit Nayak b33a2e0762 Enable flag ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Flag: ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Bug: 279494325
Change-Id: I9c58ba50f0269c69a12f548a1873c2d8251f6243
2023-05-08 17:27:03 -07:00
Jagrut Desai 29fcd9a636 Taskbar All Apps Icon Shortcuts Popup Accesiiblity
Before we were only applying the icon.clearAccessibilityFocus() only on normal popup and not material u popups, since the flag is turned on for udc, we can move it outside.

There seems to be a bug associated with either nested abstract floating views or the accessibility service where upon opening a nested abstract floating view from another the icon get the focus. This change make the bug littl less visible to use but users will still see this bug if they open the shortcut pop agian withought closing taskbar all apps.

The accessibility delegate was always null when using the TaskbarOverlayContext, now we use TaskbarActivityContext Delegate when in TaskbarOverlayContext.

Test: Manual
Bug: 280657266
Flag: not needed
Change-Id: I631e3aa6e54748c4c8ea2ac7daf5473b198e47d6
2023-05-08 16:25:53 -07:00
Fengjiang Li d9253224b3 [5/n] Log cardinality to StatsLogManager
Test: app builds
Bug: 278271805
Change-Id: Ia0180815509759caf867296a7941fa32402d8f45
2023-05-08 16:13:05 -07:00
Sunny Goyal 356aa61fe4 Merge "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""" into udc-dev 2023-05-06 18:19:13 +00:00
Sunny Goyal 3772b246c2 Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""
This reverts commit 8d9e468dbb.

Reason for revert: b/281179368

Change-Id: Ibfc5329f72cdbcb37d01a8bf3dac2ba0724b9faf
2023-05-06 18:18:07 +00:00
Sunny Goyal 3a75b494f2 Merge "Fixing WidgetBottomSheet getting cut off around insets" into udc-dev 2023-05-06 09:43:06 +00:00
Treehugger Robot 698f59ccbb Merge "Loading widget description on the background thread" into udc-dev 2023-05-06 08:19:12 +00:00
Fengjiang Li 9a055ee5dd Merge "[3/n] Update StartupLatencyLogger's @VisibleForTesting" into udc-dev 2023-05-06 03:32:03 +00:00
Sebastián Franco 5fd9a76760 Merge "Call getModelWriter() to get the newest version instead of using the old one" into udc-dev 2023-05-06 00:22:20 +00:00
Sunny Goyal 2185f6f420 Loading widget description on the background thread
Bug: 281074741
Test: Varified on device
Flag: N/A
Change-Id: I6b9b13e712534bdc582b98dbfb7bdfcc40d2f19d
2023-05-05 23:15:41 +00:00
Sunny Goyal e7da062d9a Fixing WidgetBottomSheet getting cut off around insets
Bug: 265639220
Test: Verified on device
Flag: N/A
Change-Id: If595fde8e84a226aef82f41caa0be913b22d99c2
2023-05-05 23:15:31 +00:00
Sebastian Franco a64f3a6c98 Call getModelWriter() to get the newest version instead of using the old one
DropTargetHandler was calling getModelWriter() on a final variable
and the model writer it was using was and old one.

Fix: 280170665
Test: Manul test, delete widget and rotate the device, you have to do this twice.
Change-Id: I7b3ac4b272568fcc81438ffd5ac84cf7b64a62ea
2023-05-05 16:09:38 -06:00
Brandon Dayauon 1ee28cd273 Merge "ENABLE_TWOLINE_ALLAPPS default true (only in teamfood)" into udc-dev 2023-05-05 20:49:58 +00:00
Sunny Goyal 2e17bcaa0b Merge "Simplifying widget cell layout" into udc-dev 2023-05-05 19:18:46 +00:00
Sunny Goyal 8de4199463 Simplifying widget cell layout
Calculating the preview scale during onMeasure to ensure the
content is never clipped.

Bug: 268715418
Test: Verified on device
Change-Id: Ia0fd5ca3ccaae9644e043d75f810e91909a2aea0
2023-05-05 09:28:30 -07:00
Sunny Goyal 8d9e468dbb Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""
This reverts commit 30bb3a247a.

Reason for revert: Fixed original issue

Change-Id: I02d85d604631795d96f0379eb94b7b6789102ea9
2023-05-05 16:00:49 +00:00
Jordan Silva 11167aa1f2 Merge "Fix text sizes and alignment in drop target" into udc-dev 2023-05-05 14:09:23 +00:00
Holly Jiuyu Sun ae1c56e34d Merge "[play] Add debug config flag to GMS Play." into udc-dev 2023-05-05 06:55:43 +00:00
Brandon Dayauon 017e7a2e06 ENABLE_TWOLINE_ALLAPPS default true (only in teamfood)
- modified test so enabling two line all apps work
- have appIconSelector() select from content description

bug: 275116822
test: manual
Change-Id: Id3ccc6859b55d6b8a80ca509d420409d484207cf
2023-05-04 19:37:48 -07:00
Fengjiang Li 1ecbfe153c [3/n] Update StartupLatencyLogger's @VisibleForTesting
Change to use (otherwise = VisibleForTesting.PROTECTED)

Bug: Bug: 278092752
Test: print launcher startup latency logs locally
Flag: not needed
Change-Id: I19630cc3436370e4d6a846e58dee002e5d28d5d7
2023-05-04 16:13:24 -07:00
Brian Isganitis 64ee67c6b5 Merge "Add header protection for Taskbar All Apps search bar." into udc-dev 2023-05-04 22:20:46 +00:00
Sunny Goyal db19958b82 Removing unused wallpaper-scrim feature
Bug: 270393604
Test: Presubmit
Flag: N/A
Change-Id: I10df3a96eb26b9871eb1b330ea5b2c0797d0668d
2023-05-04 14:02:41 -07:00
Josep del Río 229d11892a Merge "Close floating panels on Launcher when using Escape" into udc-dev 2023-05-04 20:50:28 +00:00
Charlie Anderson 178802d35c Merge "Revert "Changing GridMigrationTask to use ModelDbController directly"" into udc-dev 2023-05-04 17:58:01 +00:00
Treehugger Robot c2dca5fec4 Merge "Always insetting the widget by a minimum of 6dp" into udc-dev 2023-05-04 17:48:48 +00:00
Josep del Rio 1d976c6702 Close floating panels on Launcher when using Escape
This change will make the Escape key close floating panels in
Launcher.

Bug: 280801803
Test: Flashed on device, tried with physical keyboard and panels
will close.

Change-Id: Ie09e57716a7be74638037abe6272b47eec1b8a6c
2023-05-04 16:07:50 +00:00
Charlie Anderson 30bb3a247a Revert "Changing GridMigrationTask to use ModelDbController directly"
This reverts commit 9ef41413e0.

Reason for revert: This was the only launcher CL during the time  b/280669657 and 280680602 occurred

Change-Id: Id7107f0935f84908ca87e1ae4c62ab05efe41a24
2023-05-04 15:19:58 +00:00
Fengjiang Li efb0c4e98c Merge "[2/n] Refactor StartupLatencyLogger 1. Use kt stirng's $substitutions for StartupLatencyLogger 2. Add "otherwise =" for @VisibleForTesting" into udc-dev 2023-05-04 13:39:08 +00:00