Commit Graph
2595 Commits
Author SHA1 Message Date
Hongwei Wang 4dbf14ed67 Merge "Skip window transform if SwipePipToHomeAnimator's running" into sc-dev am: 4f3e8ef3f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13714585

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ie05a0c289d88aeef487aff19bf04938926cc3958
2021-02-27 00:23:10 +00:00
Hongwei Wang 4f3e8ef3f2 Merge "Skip window transform if SwipePipToHomeAnimator's running" into sc-dev 2021-02-27 00:05:05 +00:00
Hongwei Wang 9140af12d2 Skip window transform if SwipePipToHomeAnimator's running
Launcher tries to set the window transform on the recents animation
leash when it's settled on end target, which might conflict with
SwipePipToHomeAnimator and causes flash/flick at the end of the
transition. Simply skip the window transform since
SwipePipToHomeAnimator is the one solely responsible for updating the
leash in this case.

Bug: 179720719
Test: repeatedly enter PiP from ApiDemos with autoEnterPip enabled
Change-Id: Ia98675c21e3bd898cd11cf6ed97f6eaadcb11a42
2021-02-26 14:11:45 -08:00
TreeHugger Robot a1e0a801c5 Merge "Adds a removeChangeListener to FeatureFlags$BooleanFlag." into sc-dev am: a9cb2fb476
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13700168

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I00d2769059cfae7e0b68ca1c6e28578386a5f88c
2021-02-26 21:15:07 +00:00
Andy Wickham 75845ed9a8 Adds a removeChangeListener to FeatureFlags$BooleanFlag.
This will help us avoid leaks, etc.

Also changes ENABLE_SMARTSPACE_ENHANCED back to a DeviceFlag

Bug: 181194850
Bug: 181077020
Test: atest NexusLauncherOutOfProcTests:com.android.launcher3.memory.MemoryTests -- --abi armeabi-v7a
Change-Id: I6f54af3e6b6302a073b8b7d448ff72b05a803d8f
2021-02-26 07:41:45 +00:00
Evan Rosky aa15ec0897 Merge "Update input-monitors to accept unrotated coordinates" into sc-dev am: be5fdb08a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13486583

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I44709c7c8ed00bd8e4fd5f82916d12cb2669acba
2021-02-25 18:20:39 +00:00
Evan Rosky be5fdb08a5 Merge "Update input-monitors to accept unrotated coordinates" into sc-dev 2021-02-25 17:53:57 +00:00
Sreyas Rangaraju 7b29ef28cd Merge "Fix DWB cutting off above inset when translating down." into sc-dev am: 036b585475
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13668660

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I3b639167045f6339beb9d7b9ab543b22a45cae47
2021-02-25 01:55:35 +00:00
Sreyas Rangaraju 036b585475 Merge "Fix DWB cutting off above inset when translating down." into sc-dev 2021-02-25 01:47:25 +00:00
Samuel Fufa dfbb2a4883 Merge "Restore divider between app predictions and apps" into sc-dev am: 226c4af911
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13688192

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I6b3b2e112096545a7b20f704a0633cb7fdfffbbe
2021-02-24 21:54:15 +00:00
Samuel Fufa 226c4af911 Merge "Restore divider between app predictions and apps" into sc-dev 2021-02-24 20:50:10 +00:00
Tony Wickham 3c4138b226 Merge "Ensure taskbar visibility callbacks are called in init()" into sc-dev am: 2fb22af840
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13666594

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I25dba17d085cc0d6996b32837240664237ee74be
2021-02-24 17:53:59 +00:00
Tony Wickham ab35fe92fa Merge "Make RecentsView INVISIBLE instead of GONE" into sc-dev am: 7801bf68d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13680030

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ib199e30d30a0efc0617843fba2f88cc4f21866e7
2021-02-24 17:52:48 +00:00
Tony Wickham 2fb22af840 Merge "Ensure taskbar visibility callbacks are called in init()" into sc-dev 2021-02-24 17:16:45 +00:00
Tony Wickham 7801bf68d1 Merge "Make RecentsView INVISIBLE instead of GONE" into sc-dev 2021-02-24 17:15:58 +00:00
Samuel Fufa b984cf7fa6 Restore divider between app predictions and apps
Screenshot: https://screenshot.googleplex.com/89jJLU3JXV8tRXM
Bug: 180017741
Test: Manual
Change-Id: Iab1764fe94340f120770054cf5a59bd3ed9e45a4
2021-02-24 10:31:57 -06:00
Sreyas 25992f12e5 Fix DWB cutting off above inset when translating down.
Bug: 180979788
Test: Manual
Change-Id: I08577db4149b339fa217cab6401250a3fca10e65
2021-02-23 19:10:47 -08:00
Tony Wickham 752ebfcef2 Ensure taskbar visibility callbacks are called in init()
We're initializing the correct values, but the callback only runs if
the value is different than the default value of 0. Thus we weren't
updating the visibility according to the value 0 in init().

Test: Initialize taskbar while launcher is resumed
Fixes: 180103543
Change-Id: I3f754cac59e2bd5ad542de050e8b4c3146d5eebf
2021-02-23 17:08:40 -08:00
Tony Wickham 29016e8e46 Make RecentsView INVISIBLE instead of GONE
This ensures it gets laid out to compute things like page scrolls.

Test: Repro steps to both bugs below
- Force stop launcher, swipe up slightly, hold, and let go to return
  to the current task; ensure no jumps or jank
- Force stop launcher, swipe up and hold to go to Overview, ensure
  no jump on motion pause

Fixes: 180736503
Fixes: 175064755
Change-Id: I44581f87600b02a3c9ddefcb8c94bb3845cd9152
2021-02-23 17:02:36 -08:00
Sreyas Rangaraju facd274f18 Merge "ShareTargets animations and styling." into sc-dev am: 1408c6459c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13555898

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I3845b47ad61b0d7035886b548aee47ea0e38235b
2021-02-23 22:10:33 +00:00
Sreyas Rangaraju 1408c6459c Merge "ShareTargets animations and styling." into sc-dev 2021-02-23 21:15:53 +00:00
Vadim Tryshev df12e20e94 Merge "Instrumenting swiping up to all apps for jank" into sc-dev am: 06df8d7262
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13536203

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Id700d71b56ee79949544c3d28f1a4ac14acfcb6d
2021-02-23 19:01:07 +00:00
Vadim Tryshev 06df8d7262 Merge "Instrumenting swiping up to all apps for jank" into sc-dev 2021-02-23 18:32:23 +00:00
thiruram 59ee2ed28b [AA+] Add WW logging for Slice actions. am: d0ab1a0eed
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13612485

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Iaa21b2685ebf560737acc409ca8510309283edd8
2021-02-23 05:58:23 +00:00
thiruram 84152b0327 [AA+] Log additional UI events with Launcher snapshot logging. am: 97710ffbb2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13658540

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I9aa3d110a120461dc57e50b3f9b04c6e4c58a54b
2021-02-23 04:32:49 +00:00
thiruram d0ab1a0eed [AA+] Add WW logging for Slice actions.
Bug: 178562918
Test: Manual
Change-Id: I515ee3c0990dea2c30e68d5919568dc1773912ee
2021-02-22 20:07:29 -08:00
thiruram 97710ffbb2 [AA+] Log additional UI events with Launcher snapshot logging.
Bug: 180418845
Test: Manual
Change-Id: I74ab1faafe6c21a8fbf6992a8aebe918cc31d85e
2021-02-23 02:59:43 +00:00
thiruram 221cad0d7e [AA+] Log tap on SearchActionItem. am: f8f2a6ed0a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13630035

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I1236c4f08efcc28199bc0c89948a8bfb15c611ca
2021-02-22 23:09:46 +00:00
thiruram f8f2a6ed0a [AA+] Log tap on SearchActionItem.
Bug: 178562918
Test: Presubmit
Change-Id: I42a44de4f3cc02ca331c4f99c107891c4658995d
2021-02-22 22:39:41 +00:00
Hyunyoung Song a312772d90 Merge "Add group highlighting to AA+ result" into sc-dev am: dfdeddc66a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13597046

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I8a3df0f65885084f9ea5c852ff354a821b98347f
2021-02-19 21:03:10 +00:00
Hyunyoung Song dfdeddc66a Merge "Add group highlighting to AA+ result" into sc-dev 2021-02-19 20:48:37 +00:00
TreeHugger Robot c0a1467369 Merge changes Id68b6c37,I16d39d3e into sc-dev am: aa14b19725
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13617907

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I651d4778d6d41a18115eaf15aede6c7ee29d62a6
2021-02-19 19:32:44 +00:00
TreeHugger Robot aa14b19725 Merge changes Id68b6c37,I16d39d3e into sc-dev
* changes:
  Fix a couple of crashes when taskbar isn't yet attached
  Subtract taskbar size from DeviceProfile#availableHeight
2021-02-19 19:01:38 +00:00
Tony Wickham 786dd93f2b Fix a couple of crashes when taskbar isn't yet attached
- Handle back to back addTaskbarIfNecessary(). Specifically, handle
  cleanup() before the previous add was attached. This is already
  handled on WM side, just had to remove isAttachedToWindow() check.
- Add isAttachedToWindow() check to isViewInTaskbar()

Test: call addTaskbarIfNecessary() three times back to back, ensure no crash.

Fixes: 180509238
Bug: 171917176
Change-Id: Id68b6c376029eb5c651f47afa56666391c516aef
2021-02-18 15:40:33 -08:00
Alex Chau 67a3f2a0e0 Merge "Use PersistedTaskSnapshotData to calculate TaskView size" into sc-dev am: 0bd7c9bf46
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13562502

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I312820b774cfdc0a946216e9c50e3d787d7809ff
2021-02-18 21:42:31 +00:00
Alex Chau 0bd7c9bf46 Merge "Use PersistedTaskSnapshotData to calculate TaskView size" into sc-dev 2021-02-18 21:15:10 +00:00
Tony Wickham 15883891ea Subtract taskbar size from DeviceProfile#availableHeight
Normally availableHeight excludes system insets, but taskbar is added
after availableHeight is calculated. This discrepency causes some bad
calculations such as TaskView size.

Test: touch nav bar when in an app with taskbar present, ensure the
task doesn't jump due to incorrect calculation

Fixes: 179478728
Bug: 171917176
Change-Id: I16d39d3e1d9708e2a64c81b1ac24466f9567d1b9
2021-02-18 11:39:10 -08:00
Hyunyoung Song db9a53d9aa Add group highlighting to AA+ result
Bug: 180071886
Test: manual
Change-Id: Id1cc3d7400e1a7fe41af272d689aa9315030b420
2021-02-18 02:19:27 -08:00
Sunny Goyal 8bd94baa08 Merge "Removing menu and dialog for custom actions hanlding. These do not work well with gesture-nav and can potentially block the Launcher UI." into sc-dev am: 3c5e748b36
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13540210

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Icffdaeb2713db9e2b1efa2e651d3426d7ea8dac0
2021-02-17 22:04:15 +00:00
Sunny Goyal 3c5e748b36 Merge "Removing menu and dialog for custom actions hanlding. These do not work well with gesture-nav and can potentially block the Launcher UI." into sc-dev 2021-02-17 21:40:26 +00:00
Vinit Nayak 08219531ec Merge "Update System settings content observer to cache values." into sc-dev am: 4d6b0270ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13556230

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I8f94656817f2eebf2a86e28ade9c0be62ea0a3ef
2021-02-17 17:33:49 +00:00
Vinit Nayak 4d6b0270ab Merge "Update System settings content observer to cache values." into sc-dev 2021-02-17 17:05:59 +00:00
Alex Chau 3a06568d8b Use PersistedTaskSnapshotData to calculate TaskView size
- Disabled variable width for running task, as PersistedTaskSnapshotData is not always up to date for current task after rotating the device

Bug: 174464656
Test: Test tablet overview with different comination of portrait/landscape wide/narrow thumbnails in portrait/landscape
Change-Id: Ifa01e72020ccaf422e3975b092462de85fa19efd
2021-02-17 11:41:24 +00:00
Vinit Nayak a34af18b0e Update System settings content observer to cache values.
Existing ContentObserver will cache values and overwrite
them when the value itself is modified or caller force
updates.

Bug: 149571513
Test: Wrote unit tests, mostly for caching logic.
Not meant to test ContentObserver contract for registering an
observer.

Change-Id: I12835f6c2be27ce17f65a55c51c4ef85c63b4487
2021-02-16 20:58:53 -08:00
Tony Wickham a62a36cac1 Draw folder leave-behind when opening folder in taskbar am: bb4de85c25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13546997

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I2a5a34ecdfa402b7eb5d51354b650755a5d52496
2021-02-17 03:48:54 +00:00
Tony Wickham b1f9d5853c Folder support in Taskbar am: 7ba547cd2d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13545778

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Idfb7bee634c590d3c6bf83856d37959b5f61ecb4
2021-02-17 03:48:53 +00:00
Tony Wickham bb4de85c25 Draw folder leave-behind when opening folder in taskbar
Previously there was only support for CellLayout to draw the
leave-behind. Added FolderIconParent interface so any parent can
draw the leave-behind, and implement that by TaskbarView.

Test: Open folder in Taskber, ensure leave-behind draws

Bug: 171917176
Change-Id: I08d1d939a34f971f893994fe05cac972d165ef53
2021-02-16 15:10:05 -08:00
Tony Wickham 7ba547cd2d Folder support in Taskbar
- Add TaskbarActivityContext which allows shared Launcher elements to
  "just work" using existing generic ActivityContext.
- TaskbarContainerView extends BaseDragLayer<TaskbarActivityContext>.
- Inflate FolderIcon and Folder using TaskbarActivityContext to be
  shown in TaskbarContainerView.
- Use TaskbarActivityContext's DeviceProfile to determine icon size
  instead of overriding in styles. This also ensures that normal
  BubbleTextView icons have the same size as FolderIcons.

Test: Place a folder in home screen hotseat, ensure it shows up in
taskbar and can be opened, and that apps inside it can be launched
or dragged.
Bug: 171917176

Change-Id: Ic25d2f84bcd7e3399c88989305ea565497c030d9
2021-02-16 15:07:01 -08:00
Sreyas 960ddb07fc ShareTargets animations and styling.
Test: Manual
Bug: 169772466
Change-Id: I5a5118e23f90c4c585ad78f054e2c3e6b5d32001
2021-02-16 13:23:02 -08:00
Sunny Goyal 384b578ab2 Removing menu and dialog for custom actions hanlding.
These do not work well with gesture-nav and can potentially
block the Launcher UI.

Instead exposing on custom actions with keyboard accelerator and
using thee internal arrowPopup for resize options
Fixing SecondoryDropTarget not sending appropriate stats log

Bug: 179854703
Test: Verified on device
Change-Id: I268690f8a937896e4350496128a38959003f8939
2021-02-16 10:45:06 -08:00