Commit Graph
14781 Commits
Author SHA1 Message Date
Sunny Goyal 50097ef272 Waiting for app install to finish before procedding with the test
Bug: 256659409
Test: Presubmit
Change-Id: Ia0f4cdd072c4c439d09070b0395fcfd6909c2a8f
2022-11-03 13:33:41 -07:00
TreeHugger Robot bcc14682e0 Merge "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile"" into tm-qpr-dev 2022-11-03 11:27:12 +00:00
Holly Sun a793fc6e2c Bring up IME and focus on input when scroll to top.
Do this behind a feature flag AND only when "Always show keyboard" is selected or in prefix state.

Bug: 218846025
Test: keyboard shown when swiping up for QSB and AA+ (both main and work). Keyboard not shown when either the feature flag or Always show keyboard is disabled.
Change-Id: I3df2e0e44a8313eaf749cd6b91b7f9d0b9b80ec3
2022-11-02 15:19:23 -07:00
Sebastian Franco 4a92267d1d Making code more readable by removing global variable used for optimizations
Using the stack was more efficient because it prevented the creation
of new rectangles but it makes the code harder to read and prone to
bugs if the global state of the stack of rectangles gets corrupted
in any way.

When this optimization was written in 2008 it was necessary but now I
don't think it would have a big impact. The stack size is on average
of 30 and the rectangles are only created when doing the reorder which
runs about once per second if the user moves the finger too quickly.

Bug: 188081026
Test: atest ReorderWidgets
Change-Id: I35d8ee8d92f01035e72fe5763a7de47f4b6a73de
2022-11-02 22:10:14 +00:00
Sebastián Franco ef24d5954c Merge "Return the right radius to start reorder when dragging a Widget" into tm-qpr-dev 2022-11-02 21:19:44 +00:00
Alex Chau 5dfd939d41 Reland "Add logs for InvariantDeviceProfile.getDeviceProfile"
This reverts commit b065b4b05a.

Bug: 253338238
Change-Id: Idea32130c8ec535f848ded5cff0269d97ea064e2
Test: manual
2022-11-02 17:40:05 +00:00
Tony Wickham 6b32ce07b1 Merge "Decrease TAPL All Apps scrolling flakiness" into tm-qpr-dev 2022-11-02 15:39:45 +00:00
Sunny Goyal 3c7054f0d2 Updating widget prediction handling:
When handling widget prediction, first match the full provider names
Only if no widgets are found, match any widget in the package

Bug: 256202399
Test: atest WidgetsPredicationUpdateTaskTest
Change-Id: I5337618d935f8b926803aeefede46059545de72d
2022-11-02 02:24:21 +00:00
Sebastián Franco 1b14a73223 Merge "No code changes, this cl only reorganizes the functions" into tm-qpr-dev 2022-11-01 23:43:30 +00:00
Sebastian Franco 9cab1c3ece No code changes, this cl only reorganizes the functions
This is done such that future cls are easier to visualize.

Bug: 188081026
Test: atest ReorderWidgets
Change-Id: I749d21b517dada97887d5b5e7cb5e2ac644d0030
2022-11-01 18:24:43 +00:00
Federico Baron 120c99f440 Merge "Tapping on a "folder" on the Homescreen right after returning home results in it starting to open, then canceling." into tm-qpr-dev 2022-11-01 17:56:50 +00:00
Tracy Zhou 0c853991fd Merge "Support split from fullscreen with shortcuts" into tm-qpr-dev 2022-11-01 17:17:33 +00:00
Luca Zuccarini 938dde8111 Merge "Make sure that PropertySetter applies the final state." into tm-qpr-dev 2022-11-01 12:28:54 +00:00
TreeHugger Robot 86dc1edbf8 Merge "Move DropTargetBar to bottom" into tm-qpr-dev 2022-11-01 07:21:31 +00:00
TreeHugger Robot d20e6676b1 Merge "Add dot pagination in workspace" into tm-qpr-dev 2022-11-01 04:33:29 +00:00
Tracy Zhou ba0b5952c8 Support split from fullscreen with shortcuts
Recording: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/978a3a55-2982-4026-9726-2a73cb694258

TODO: improve transition animation

Bug: 246661484
Test: manual
Change-Id: Id0d1aec0685bc18f4b273f8e466996efc1d9a3d8
Merged-In: Id0d1aec0685bc18f4b273f8e466996efc1d9a3d8
2022-11-01 04:30:39 +00:00
Sebastián Franco 0c3f990b34 Merge "Decoupling finding the solution and animation of a reorder in CellLayout" into tm-qpr-dev 2022-10-31 23:02:44 +00:00
Federico Baron 8bf1bca59a Tapping on a "folder" on the Homescreen right after returning home results in it starting to open, then canceling.
Fix: 243531200, 253264925
Test: manual
Change-Id: I180300e8333536346ad07ce7bc9956d3b84d82e6
2022-10-31 15:12:17 -07:00
Holly Jiuyu Sun c5f43eb9f7 Merge "Log sub event type to latency logger." into tm-qpr-dev 2022-10-31 19:28:27 +00:00
Sebastian Franco c8392ea881 Return the right radius to start reorder when dragging a Widget
Currently the radius is only one cell but in the case of a widget
we want the radius of the whole widget.

Fix: 255421400
Test: this case only happens when dagging comming from outside of the cell layuot in the corners dragging a widget
Change-Id: I3fe294d18283dbecb27df1a2d4748dd44db9b956
2022-10-31 10:20:53 -07:00
Sunny Goyal 276e72c249 Merge "Fixing flakyness in widget tests" into tm-qpr-dev 2022-10-31 16:23:08 +00:00
Holly Jiuyu Sun 35b0378d45 Merge "[QL-v2] Use subtitle as hint if title doesn't apply." into tm-qpr-dev 2022-10-28 19:35:33 +00:00
Sunny Goyal 1d76159de4 Fixing flakyness in widget tests
For some predicted app widgets, the layout happens before the recyclerView
can layout completely (because of preview layout invalidation), causing the
scroll cache to get in a wrong state.
Checking for scroll cache validity everytime instead of only during
data changes

Bug: 255797215
Test: Verified by hardcoing the chrome widget as predicted widget
Change-Id: Id2c68560baa45de89e08c53bdb9ee6820eab68c4
2022-10-28 12:25:04 -07:00
Sebastian Franco 53a15a4b1f Decoupling finding the solution and animation of a reorder in CellLayout
Adding new functions to CellLayout, two of them return a solution
(calculateReorder, getSimpleReorder) and the other one takes a
solution and animates that solution (void performReorder) and it can
either submit the solution or just show it for a preview.

Right now this two things are done under the same function:
int[] performReorder. The need to separate this two functions is
because to add this functionality b/188081026 which needs to find
soluion without animation and animation solutions that can be
calculated in another place.

Bug: 188081026
Test: atest ReorderWidgets
Change-Id: Ib519d4346f58f9b55aff5008cd3ccbcfe8443d2d
2022-10-28 11:55:50 -07:00
Holly Sun 4d6fa05c83 Log sub event type to latency logger.
Bug: 255355348
Test: build
Change-Id: Idac85b5e31e2abdd98f6fd1bed4ec687d8bb5cd5
2022-10-27 16:37:18 -07:00
Federico Baron 626d51c68c Move DropTargetBar to bottom
The DropTargetBar has "Remove" and "Uninstall" buttons for workspace edit mode. We are moving them to the bottom for workspace home gardening

Bug: 251259222
Test: Turn on flag HOME_GARDENING_WORKSPACE_BUTTONS and enter spring loaded mode (edit workspace), notice the buttons are now at the bottom
Change-Id: I739162bdd5764dd8367a63a67fae0fe5c7329b0a
2022-10-27 14:18:00 -07:00
Holly Sun 786bdce214 [QL-v2] Add logging for quick launch.
Move logging to DeviceSearchAdapterProvider to take advantage of View so we can log more info attached to the quick launch event. Another reason is currently we can't dynamically change the enter key icon so we can't really distinguish whether it's a quick search or quick launch using the icon (we are working with gboard team to fix this issue).

Bug: 256010819
Test: see wwlogging https://paste.googleplex.com/5668268562972672
Change-Id: I38aad2ae97c9b372f3d76222a82de45fc3bf3eed
2022-10-27 13:18:19 -07:00
Sihua Ma 17137e8bce Merge "Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost" into tm-qpr-dev 2022-10-27 17:53:28 +00:00
Alex Chau b3ab6f5014 Merge "Update pullback animation to use reset FloatProperty for non-active state" into tm-qpr-dev 2022-10-27 12:38:15 +00:00
Luca Zuccarini 05d19dc261 Make sure that PropertySetter applies the final state.
In some tests with animations disabled, NO_ANIM_PROPERTY_SETTER wasn't
applying the correct final value. See ag/20139786 for more context.

Bug: 251769927
Test: see other CL in topic, plus manual
Change-Id: I296de1a0d64768c43608839745cc7e955ecd2076
2022-10-27 09:31:57 +00:00
Becky Qiu 6a2dd438da Merge "[Toast] Use a BaseSearchConfig for launcher3 to read allapps device config." into tm-qpr-dev 2022-10-26 20:33:05 +00:00
Sihua Ma e53245fbc7 Merge "Correctly show the widget in the recommendation table" into tm-qpr-dev 2022-10-26 18:19:23 +00:00
Sihua Ma 0593a0d3ec Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost
The wrapper class is created for further changes that will run the wrapped host in the background.

Test: N/A
Bug: 235358918
Change-Id: I9bd6fc2749c5d4a4d3391fb75d0c3ff1e13d17bf
2022-10-26 10:57:13 -07:00
Sebastián Franco a4798b5687 Merge "Revert "Prevent double touch inputs in the BaseDragLayer"" into tm-qpr-dev 2022-10-26 16:42:12 +00:00
Thales Lima 3a63fca303 Merge "Make all handheld grids scalable" into tm-qpr-dev 2022-10-26 16:28:08 +00:00
Sunny Goyal dd3d50d76a Merge "Introducing feature flag for optimizing overlay service connection" into tm-qpr-dev 2022-10-26 16:24:16 +00:00
Alex Chau ee6a99b798 Update pullback animation to use reset FloatProperty for non-active state
Fix: 246733229
Test: Change display between phone and tablet, use home gesture in AllApps
Change-Id: I20bdef9dcf9a60475f482261501ad39106b8b107
2022-10-26 16:03:15 +01:00
Jon Miranda 661f38cdb8 Merge "Add transient taskbar UI" into tm-qpr-dev 2022-10-26 14:56:15 +00:00
Sebastián Franco 7d4176bf73 Revert "Prevent double touch inputs in the BaseDragLayer"
This reverts commit 68fc44ffad.

Reason for revert: Wrong handling of events

Change-Id: Ic34916123ed6c4ba33f629549dda2cdbc890b413
2022-10-25 22:35:34 +00:00
Federico Baron a184511bb4 Add dot pagination in workspace
Here we add dot pagination (the same as the one in folders) to the workspace.

Bug: 254769710
Test: Turn on the flag SHOW_DOT_PAGINATION and check out the workspace
Change-Id: Ia1e9ec78eae661aa5e7c37b2b2f1ded38b138ce8
2022-10-25 15:14:37 -07:00
Sihua Ma a28182d9c6 Correctly show the widget in the recommendation table
Test: Manual
Bug: 246121954
Change-Id: Ib32a20683b3dc456417549284744642ad451a829
2022-10-25 14:40:02 -07:00
Sunny Goyal 3912808183 Merge "Merging MultiValueAlpha with MultiPropertyFactory" into tm-qpr-dev 2022-10-25 21:39:11 +00:00
Jon Miranda 184a04266d Add transient taskbar UI
This change is only for the visual appearance of the
transient taskbar.

Bug: 252905206
Test: manual
Change-Id: I4990b20b39089a0c27ec2a72dd3010cf64ddba1d
2022-10-25 13:46:19 -07:00
Federico Baron 7c70ba3ede Merge "Add new flag for dot pagination" into tm-qpr-dev 2022-10-25 20:37:52 +00:00
Federico Baron 7382883ee6 Merge changes If1a00ac6,I5b233070 into tm-qpr-dev
* changes:
  Hide QSB (toast) when editing workspace
  Add flag for moving the workspace edit buttons to bottom
2022-10-25 20:27:47 +00:00
Federico Baron f834cfe954 Merge "Autohide and autoshow pagination in workspace" into tm-qpr-dev 2022-10-25 19:44:35 +00:00
Federico Baron cfa0f833f6 Add new flag for dot pagination
Here we add a flag for adding the dot pagination (same as currently in folders) to workspace

Bug: 254769710
Test: N/A
Change-Id: Id5fc33f61b9814f73afea8c5119c7d8d4ee24756
2022-10-25 18:00:03 +00:00
Holly Jiuyu Sun 381ba3319d Merge "Log a-z apps count." into tm-qpr-dev 2022-10-25 17:50:19 +00:00
Federico Baron 98db0df4ab Hide QSB (toast) when editing workspace
Here we hide QSB when we enter drag mode in order to follow the guidelines set by https://docs.google.com/presentation/d/1FOmmCdmGmSMR77_901IOMbvbPVxPmjaAdxZjy-D9tw0/edit#slide=id.g159289e55db_0_229

Bug: 251259222
Test: Enter edit mode with SHOW_HOME_GARDENING flag on, notice how QSB disappears when we enter drag
Change-Id: If1a00ac62cec21a641295494d3a2dbb1f267bd62
2022-10-25 10:47:48 -07:00
Federico Baron 69c5f2d840 Add flag for moving the workspace edit buttons to bottom
This flag is for moving the workspace edit buttons to the bottom as per https://docs.google.com/presentation/d/1FOmmCdmGmSMR77_901IOMbvbPVxPmjaAdxZjy-D9tw0/edit#slide=id.g159289e55db_0_229.

Bug: 255586768
Test: N/A
Change-Id: I5b23307081333f80f3a8a1f23aa9a09c5425129d
2022-10-25 10:44:36 -07:00