Commit Graph
14781 Commits
Author SHA1 Message Date
Stefan Andonian 8b85f83785 Add null check for NPE in FolderIcon.
Bug: 265298513
Test: N/A
Change-Id: Id55bd488c40edcca376df2843b1a1999aeb944be
2023-01-18 18:19:26 +00:00
Nick Chameyev a8037620bd Calculate StatusBar height locally in Launcher
When reading the status bar inset on devices with
multiple displays after switching the displays
the inset is not updated immediately (SystemUI
should update the height of the window first by
reacting to the display switch in it's own process).

Due to this race condition Launcher is very likely
to calculate DeviceProfile with incorrect inset
of the previous display first and update it to
the correct one only after SystemUI finished the
window update.

To avoid this adding calculation of the StatusBar
height to Launcher locally using the same utility
method that is used by SystemUI.

Bug: 264656380
Test: manual test that the statusbar height is calculated
 correctly in Launcher on a device with two displays, both on
 the inner and outer display and different rotations
Change-Id: Ia16ecadd8fcac29082d27ca693ab7740ce6161c4
2023-01-18 16:04:41 +00:00
Alex Chau 6ef0f12286 Merge "Use transient taskbar size/margin to calculate taskbar position for persistent taskbar" into tm-qpr-dev 2023-01-18 15:37:34 +00:00
Federico Baron 3278715fd4 Change preload icon size to always be 0.7 scale when downloading
In order to match upcoming designs. We will keep the icon size when downloading at 0.7 scale

Test: download an app with ENABLE_DOWNLOAD_APP_UX_V2 on
Bug: 254858049
Change-Id: I7f22eb3a5c6f1e75f19e033ff11a70aa4010ea10
2023-01-17 16:42:43 -08:00
TreeHugger Robot a13d5c4b91 Merge "Workspace pagination UI update" into tm-qpr-dev 2023-01-17 23:29:18 +00:00
TreeHugger Robot 196569bb50 Merge "Add finish icon scale animation for downloading apps" into tm-qpr-dev 2023-01-17 19:38:47 +00:00
Stefan Andonian 1eb59d6c6a Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev 2023-01-17 18:23:10 +00:00
Nicolo' Mazzucato cb7bd50247 Log device profile changes in perfetto traces
This is needed to easily spot unwanted DeviceProfile changes in perfetto traces, as each one causes many new inflation and slows down the ui thread considerably.

Test: recorded trace with this log
Bug: 258214245
Change-Id: I805d56d4dfe1c08d7f28215c0462d01fcaece84e
2023-01-17 14:54:11 +00:00
Alex Chau 85d664efaa Use transient taskbar size/margin to calculate taskbar position for persistent taskbar
- DeviceProfileTest should use persistent taskbar in 3-button mode

Fix: 260596114
Test: DeviceProfileTest
Change-Id: Iadcca218dab2bc2eedc006c86dbbe3f9a0fa5e51
2023-01-16 17:00:46 +00:00
Sebastian Franco de1fe14a47 Adding the avility to add icons on multiple CellLayouts on tests.
I needed to change the code so that you can pass the CellX/Y
position to the drag function instead of the pixel coordinates
and we can pass X position bigger than one CellLayout.

Also, I notice that getCellCenter only worked for 1x1 items
so I added the option to specify the widget size.

Fix: 262431878
Test: atest ReorderWidgets#multipleCellLayoutsSimpleReorder
Change-Id: I3b09de770e8f99aa10cae8cea32e7e6bc02c7b8b
2023-01-16 10:32:40 -06:00
TreeHugger Robot 77a388c79e Merge "Predictive swipe: show extra app icons at bottom of All Apps's RecyclerViews" into tm-qpr-dev 2023-01-14 06:03:52 +00:00
Sebastián Franco 519714449f Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" into tm-qpr-dev 2023-01-14 00:59:47 +00:00
Stefan Andonian d1b33b311c Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage.
LauncherPrefs will contain Launcher's shared preference functionality.
It controls optimizations and classifications such as restorable vs
non-restorable data, bootaware vs non-bootaware data, and configurations
such as default values  so the calling code doesn't need to and our code
base can have a single source of truth for items that are used in
multiple places.

The old APIs remain in place, but are deprecated and will be removed
after all Shared Preference usage has been gated by LauncherPrefs in
future CLs.

Bug: 261635315
Test: Manually tested themed icon, Workspace configuration, and app
install functionality.

Change-Id: I29fd516468bc93fda393062e95be26b6d55c816e
2023-01-14 00:54:15 +00:00
Brandon Dayauon 994bed564e Merge "split the scrolling logging into work,personal, and search" into tm-qpr-dev 2023-01-14 00:32:54 +00:00
Fengjiang Li 3774824cea Predictive swipe: show extra app icons at bottom of All Apps's RecyclerViews
The maximum center scale of All Apps to Home is 90%. It means we should add 5% height to All Apps's RecyclerView to render extra app icons.

Test: manual
bug: b/264906511
Change-Id: I2e970580810220e25d7fc3a86c19abaf87ba2c6e
2023-01-13 15:55:17 -08:00
Federico Baron 4eb502ae10 Add finish icon scale animation for downloading apps
We add an animation when we finish downloading an app where the scale of the icon increases to from scale 0.867 to scale 1

Bug: 254858049
Test: Download an app and visualize finish download animation
Change-Id: I67912f86b0e35091a5fe1b39c3463a1ff203bd3b
2023-01-13 15:35:14 -08:00
Lucas Silva 97976bc345 Merge "Display back button on home settings." into tm-qpr-dev 2023-01-13 19:06:27 +00:00
Sebastian Franco 877088e6c3 Change the access of cellX/Y of CellLayoutLayoutParams to private
Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
Merged-In: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-13 18:25:10 +00:00
Luca Zuccarini da31c5e3a3 Merge "[Toast] Add a feature flag for result launch animations." into tm-qpr-dev 2023-01-13 15:14:55 +00:00
Federico Baron 3f255eb591 Workspace pagination UI update
Here we improve the pagination visuals to follow the new design specs. We also polish and fix some issues with dot pagination in workspace.

Bug: 262741688
Test: Turn on flag SHOW_DOT_PAGINATION, and test pagination on workspace. Verify that it follows the specs linked in the bug
Change-Id: I626cdcf1f7392bcc88e9b4d6fd1df65246861445
2023-01-12 18:17:42 -08:00
Alex Chau bebeefe993 Merge "Reduce icon/text simultaneously when cellHeight is not enough for largest display size" into tm-qpr-dev 2023-01-13 00:57:04 +00:00
Jeremy Sim 9dfeb03a71 Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev 2023-01-12 23:08:37 +00:00
Ats Jenk 1c28f290c1 Merge "Skip depth and scrim if freeform tasks are visible" into tm-qpr-dev 2023-01-12 22:39:57 +00:00
Ats Jenk ca009e4e93 Skip depth and scrim if freeform tasks are visible
If freeform tasks are shown, skip applying depth effect and scrim
changes. These cause the background to flicker while showing freeform
tasks and for example showing the transient taskbar.

Bug: 263264985
Test: swipe up to show transient taskbar, observe launcher background
does not blur or flicker to black

Change-Id: I5b10d0f0c7065e903cb761488367c02d7e31d8b2
2023-01-12 10:15:30 -08:00
TreeHugger Robot 944348a522 Merge "Support predictive back from all apps to home" into tm-qpr-dev 2023-01-12 17:01:02 +00:00
Luca Zuccarini 51c89ca493 Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev 2023-01-12 14:06:07 +00:00
Fengjiang Li e884c2c79f Support predictive back from all apps to home
bug: b/238475505
Test: manual

Change-Id: Ibf4f7f41a26b044a538e2cd566d2297ed88f1b99
2023-01-11 22:55:28 +00:00
Stefan Andonian bf69ef034a Merge "Rename LoaderResults to LauncherBinder." into tm-qpr-dev 2023-01-11 22:47:34 +00:00
Stefan Andonian fb602d4db7 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev 2023-01-11 22:46:31 +00:00
Sunny Goyal 96bfea9d32 Merge "Fetching the session info on the background thread when launching pening icon" into tm-qpr-dev 2023-01-11 22:32:01 +00:00
Stefan Andonian e82476ad3b Rename LoaderResults to LauncherBinder.
LoaderResults implies a data object, not binding code specific to
Launcher UX containers. This CL merely renames this class and its
usages. It also adds a comment that explains why the functionality is
split into a base class and an implementing class.

Bug: 251502424
Test: Compilation worked correctly.
Change-Id: I01b5ac2f717e9b20612538d5c1e0ca947beb593f
2023-01-11 20:32:25 +00:00
Stefan Andonian 2a58ddb89f Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and
into its own class.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly.

Change-Id: Ifa42dc32f90dfa4fda8df0e52811ddfe20cc5a9b
2023-01-11 19:33:32 +00:00
Brandon Dayauon f54e016c82 split the scrolling logging into work,personal, and search
- moved collapse/extend logging with the other scroll logging

bug: 263817965
test: Manual - WW
Change-Id: I9cd57b895c0c2edb7fe39ef98dced574d09a0953
2023-01-11 10:09:27 -08:00
Luca Zuccarini 50ef8004e0 [Toast] Add a feature flag for result launch animations.
Bug: 250588519
Test: manual
Change-Id: I6d605bf8b1008a3b12497e1d04601735ad79c001
2023-01-11 13:16:02 +00:00
Jeremy Sim 5f8dd20236 Fix transition animations for launch-from-staged operation
This change makes it so that a smoother animation will play when the user cancels the splitscreen flow by tapping the staged app to launch the app in fullscreen. Since this was the only blocker to activating the feature, this change also enables launch-from-staged by default and removes the flag.

Fixes: 257513449
Test: Manual
Change-Id: Iabff2fc72bfcd6975d216b5cd86e0df7a772b308
2023-01-10 15:44:23 -08:00
Sunny Goyal 5fe99d560e Fetching the session info on the background thread when launching pening icon
Bug: 242669604
Test: Verified that the RPC is not made on UI thread
Change-Id: I4299628b8b3e9aa2844f5556c57f47d997dd85e1
2023-01-10 11:02:58 -08:00
Alex Chau 06f36e8568 Reduce icon/text simultaneously when cellHeight is not enough for largest display size
- Follow-up of http://ag/20691430
- Reduce iconDrawablePaddingPx to further recover space
- Then proportional reduce both iconSizePx and iconTextSizePx
- This will result in larger icon/text size in px when going from larger to largest for most devices
- For extremely large desnity (> largest for most devices), iconSizePx/iconTextSizePx will inevitably reduce due to smaller availalbe space

Fix: 264149604
Test: test different density between larger and largest, check that icon/text size continues to grow in px
Change-Id: I1633566b9372acf1393c7e997598cb3e46c4a507
2023-01-10 18:11:59 +00:00
Luca Zuccarini fb4429f0b0 Revert^2 "Update timings for the Home <> All Apps transition."
e18ac479e5

Change-Id: Id09987b2c67be70e62349574973d4bc62b10bc9d
Bug: 263221786
2023-01-10 17:05:29 +00:00
Thales Lima bdfc07f1f0 Merge "Check kotlin format before uploading" into tm-qpr-dev 2023-01-10 16:41:58 +00:00
Thales Lima 03ac377a34 Check kotlin format before uploading
This uses ktfmt on the PREUPLOAD hook to check file formatting.

Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
Merged-In: I8bdeabd9c1ed571a464707e6912419ad3190a169
2023-01-10 13:24:43 +00:00
Sebastián Franco b66293e96d Merge "Printing the workspace items to improve flake investigation." into tm-qpr-dev 2023-01-09 23:20:51 +00:00
Vinit Nayak 72b186aefd Merge "Improves overview split adjacent launch animation" into tm-qpr-dev 2023-01-07 00:36:16 +00:00
Sebastian Franco f34f35fddb Printing the workspace items to improve flake investigation.
Recording the screen to investigates flakes on ReorderWidgets
is really useful but it requires changing the code for that and
storing the video and most of the time the useful information
is just the end state so by logging the end state makes resolving
flakes easier

Fix: 261877803
Test: atest ReorderWidgets
Change-Id: If5d9745ebb57826a55b5df9d3599eed56c48298f
2023-01-06 12:29:11 -06:00
Sunny Goyal 3da648a80b Merge "Fixing work tab is not updated when work-mode changes" into tm-qpr-dev 2023-01-06 18:11:15 +00:00
Brandon Dayauon bae7e704a4 Merge "Add logging to work mode switch" into tm-qpr-dev 2023-01-05 23:21:35 +00:00
Sunny Goyal 3c2ee27a01 Fixing work tab is not updated when work-mode changes
Bug: 263399769
Test: Verified on device
Change-Id: I94d8f20bc70f2299d11d539d4821ba7e13253522
2023-01-05 14:53:28 -08:00
TreeHugger Robot 1973056e40 Merge "Revert "Add logging to help debug additional app infos being updated by CacheDataUpdatedTask"" into tm-qpr-dev 2023-01-05 20:04:07 +00:00
TreeHugger Robot 5b860ca3ed Merge "Re-enable the fast scroll in widget picker" into tm-qpr-dev 2023-01-05 19:55:51 +00:00
Vinit Nayak da2819ed5f Improves overview split adjacent launch animation
* Translation gets scaled along with the parent,
so the secondary thumbnailView which has a translate on
it gets exaggerated as the parent goes to fullscreen
scale.
* Now we inversely scale translationX/Y properties,
however it seems like the interpolation is still slighly
off at the beginning of the animation (or maybe some other
value, such as pivot, etc)

Bug: 260814999
Test: Manually slowed down animation and observed
Change-Id: I831476b4ffb582fecbd166525ceea33623e66bdd
Merged-In: I831476b4ffb582fecbd166525ceea33623e66bdd
2023-01-05 11:54:22 -08:00
Brandon Dayauon 9d38a3fd10 Add logging to work mode switch
Add logging to the work button on work profile, logging when button
is extended and collapsed

bug: 263817965
test: presubmit
Change-Id: I3194d0a1567a9ee995497391350ed5be4b08c3db
2023-01-05 01:40:30 -08:00