Commit Graph
31 Commits
Author SHA1 Message Date
Vadim Tryshev 14c6c8cee4 Improving tests to fix testBindNormalWidget_withoutConfig, and beyond
1. Make waitXXX methods fail if the condition diesn’t turn true.
2. Waiting for loading to complete in tearDown instead of reloading the
 model
3. Avoiding waiting for load-complete where loading didn’t start
4. Disabling last test in AddConfigWidgetTest
5. Waiting for loading to complete inside setupAndVerifyContents(), not
 outside
6. Unifying how we wait for loader to complete
7. Adding more logging

Bug: 117332845
Test: running all Nexus tests
Change-Id: I3070e1ac2b9161179cc3e0800b0cd8162807389a
2018-10-09 18:47:42 -07:00
TreeHugger Robot 02e900c3c9 Merge "Adding tests for fallback recents when a 3rd party launcher is installed" into ub-launcher3-master 2018-10-09 21:32:19 +00:00
Sunny Goyal 4ed58d6c03 Adding tests for fallback recents when a 3rd party launcher is installed
Change-Id: I1d4da13cc779f49832008b12b9628d01631faffe
2018-10-09 14:25:01 -07:00
Vadim Tryshev 2d5713634e Ignoring more tests
Bug: 117106893
Test: will see on TAP
Change-Id: Ic031cc6756473552fc11186f666bcb9debfcecb5
2018-10-09 10:31:33 -07:00
TreeHugger Robot 9720452363 Merge "Converting long item IDs to int" into ub-launcher3-master 2018-10-08 23:27:27 +00:00
Vadim Tryshev b769edec46 Ignoring more tests
Bug: 117106893
Test: will see on TAP
Change-Id: I992edaff5e40e8c16188033b5cbda6b0228fc2b6
2018-10-08 16:05:11 -07:00
Sunny Goyal efb7e84242 Converting long item IDs to int
> Items ids were already being typecasted to int when being bound on the UI
> Using a consistent type allow better use of platform data-structures
> Adding IntArray and IntSet as a replacement for various Collection classes

Change-Id: Id3c650ed2420c2bfca3bd7671d2b705b56112371
2018-10-08 14:52:39 -07:00
Vadim Tryshev a7da86e14a More temporary logging to diagnose testPendingWidget_autoRestored
And waiting to loader to finish to improve determinism.

Bug: 117332845
Test: running Launcher
Change-Id: Icdfce969b61f8ceb952a2715037783458da4d4c4
2018-10-05 20:05:34 -07:00
Vadim Tryshev c052e4e68a Adding temporary logging to diagnose testPendingWidget_autoRestored
This test fails

Bug: 117332845
Test: running Launcher
Change-Id: I300c856992b3d1f559c4c31525a45e2c4a960f11
2018-10-05 17:37:01 -07:00
TreeHugger Robot b609c7970a Merge "Disabling testConfigCancelled_rotate" into ub-launcher3-master 2018-10-03 23:20:13 +00:00
Vadim Tryshev 7662701ee9 Disabling testConfigCancelled_rotate
It's flaky

Bug: 117106893
Test: will see on TAP
Change-Id: I452af39b0b3401d1ef875aee3c49eedd298a1cd3
2018-10-03 10:37:16 -07:00
Vadim Tryshev 6ffb2c8faa Make @QuickstepOnOff and @PortraitLandscape available to all UI tests.
Also, fix rotation as Portrait as starting poin for all tests, to avoid
tests running in unexpected configuration.

Bug: 115645301
Test: run all Nexus tests
Change-Id: I3ab0e91db111eeefda77af2960c43962a119de0c
2018-10-02 17:32:01 -07:00
Vadim Tryshev c78b6fa465 Disabling TestDragIcon tests
The bug below is for re-enabling disabled tests.

The problem is not reproable locally, at least after several hours of
attempts.

For now, we'd benefit more for enabling presubmits.

Bug: 117106893
Test: will see on TAP
Change-Id: Idd3f80accaf444eef29c151efea542924fcc713b
2018-10-01 12:27:35 -07:00
Vadim Tryshev c59465efe0 Disabling heads-up notifications in launcher tests.
This prevents the tests from interacting with this popup.

Bug: 110103162
Test: TaplTests
Change-Id: I0215ddab634611d20a63ed728de11d4138456f96
2018-09-18 14:02:33 -07:00
Vadim Tryshev 0a9f3ab4a6 Converting tests to Androidx
Bug: 112610679
Change-Id: I712826e668f1fbeb4e47cc541d4f5296d8eb74c0
2018-08-21 15:04:48 -04:00
TreeHugger Robot a950d40d09 Merge "Started converting Launcher to be gesture-stable" into ub-launcher3-master 2018-08-14 19:18:46 +00:00
Vadim Tryshev dc755e718d Started converting Launcher to be gesture-stable
All tests keep passing.

WorkTabTest.workTabExists was made gesture-stable. There is no need to
use TAPL, as the point is not to check answering to gestures, but to
check presence of tabs, which is better to do using launcher internal
state. (It still fails if run as a part of all tests, presumably,
because after Launcher's start, changes in user configuration are not
recognized, so I've commented the failing part)

Bug: 110103162
Test: Run all tests
Change-Id: Ic30b8e8475d16cee3880332f12311a44ddfa26cb
2018-08-14 10:29:57 -07:00
Sunny Goyal 6edb1b84bf Changing Condition to an interface to allow using lambdas
Change-Id: Ib7ad6a45d2ce556f843cd3a9767001904707dced
2018-08-14 10:27:48 -07:00
Jon Miranda ca02f00eb1 Add @Test and @Ignore to untested test methods in RequestPinItemTest.
Error prone complains when trying to merge launcher3 code to platform pi-dev.

"This looks like a test method but is not run; please add @Test and @Ignore,
or, if this is a helper method, reduce its visibility."

Output:

Executing tasks: [:assembleGoogleDebug, :assembleGoogleDebugAndroidTest]
Gradle build finished in 1s 631ms
Tests Ignored: 1 passed, 4 ignored

Bug: 78589564
Change-Id: Icde57fd8307e1ef409822d1417f629cd1aaa57ba
2018-06-21 17:20:23 -07:00
Jon Miranda 1aaaac8343 Add @Test and @Ignore to untested test methods.
Error prone complains when trying to merge launcher3 code to platform pi-dev.

"This looks like a test method but is not run; please add @Test and @Ignore,
or, if this is a helper method, reduce its visibility."

Change-Id: I95f55b95d8f7752c9c941f0828ca22d6427528c6
2018-06-21 14:04:52 -07:00
Hyunyoung Song 3efd037e63 Fix the Launcher3Tests
Bug: 78589564

$ adb shell am instrument -w com.android.launcher3.tests/android.support.test.runner.AndroidJUnitRunner

com.android.launcher3.allapps.search.DefaultAppSearchAlgorithmTest:..
com.android.launcher3.logging.FileLogTest:..
com.android.launcher3.model.AddWorkspaceItemsTaskTest:....
com.android.launcher3.model.CacheDataUpdatedTaskTest:...
com.android.launcher3.model.DbDowngradeHelperTest:....
com.android.launcher3.model.GridSizeMigrationTaskTest:...........
com.android.launcher3.model.LoaderCursorTest:........
com.android.launcher3.model.PackageInstallStateChangedTaskTest:...
com.android.launcher3.popup.PopupPopulatorTest:..
com.android.launcher3.provider.RestoreDbTaskTest:..
com.android.launcher3.touch.SwipeDetectorTest:.....
com.android.launcher3.ui.AllAppsAppLaunchTest:..
com.android.launcher3.ui.AllAppsIconToHomeTest:..
com.android.launcher3.ui.ShortcutsLaunchTest:..
com.android.launcher3.ui.ShortcutsToHomeTest:..
com.android.launcher3.ui.WorkTabTest:.
com.android.launcher3.ui.widget.AddConfigWidgetTest:....
com.android.launcher3.ui.widget.AddWidgetTest:..
com.android.launcher3.ui.widget.BindWidgetTest:......
com.android.launcher3.ui.widget.RequestPinItemTest:.
com.android.launcher3.util.GridOccupancyTest:..
com.android.launcher3.widget.WidgetsListAdapterTest:......

Time: 180.363
OK (76 test)

Change-Id: I4a50581bc8d06a030467ac9fec3e1ef668745214
2018-06-19 14:13:13 -07:00
Sunny Goyal 29947f0b53 No more waiting around for resume
Apply model updates as son as they arrive instead of waiting for onResume.
Various workspace items do not use any configuration dependent resources.
For Widgets, we wait until the host starts lietening before inflating the actual view.

Change-Id: Icb2f5e5940c1ce6c27062ccd34eff87e80af5ab1
2017-12-19 12:50:17 -08:00
Sunny Goyal 952e63d006 Fixing custom widgets support:
> Moving the definitions to xml so that it is easier to override in derivative projects
> Fixing verious bind and save logic for custom widgets
> Adding feature flag to easily disable custom widgets

Change-Id: I0e278bc7dd415713029364060ef10842da990be9
2017-09-13 14:04:35 -07:00
Hyunyoung Song e24cb63b81 WallpaperManagerCompat should target correct platform
Also replace Utilities.isAtLeastO() to static final constant.
Bug: 65544683

Change-Id: I39fbea66939d72c31702748716c4e65b4f9bee6a
2017-09-11 12:17:09 -07:00
Sunny Goyal 1d7f45d8f8 Fixing various tests
> Migrating UI tests to AndroidJUnit4 for better support
> Removing obsolete RotationPreference test
> Fixing broken FileLogTest and AndroidJUnit4
> Removing InvariantDeviceProfileTest as it does not work well with
  resource overlays

Change-Id: I0abb1df6765d76d86c1c6c84e8ac35eb9a6bcdaa
2017-07-31 11:03:54 -07:00
Sunny Goyal 64a75aa305 Adding A feature flag to disable widgets and a corresponding build
target Launcher3Go without widgets support

Bug: 62353159
Change-Id: Ia03d2235a9bcf75f9ef191924f81630e63a2c684
2017-07-21 14:10:13 -07:00
Sunny Goyal afc3f09240 Adding support for showing the widget preview based on the provided RemoteViews
am: c65a0085d7

Change-Id: Iabea96bb74294e2775a08427c17e154020d9bc40
2017-03-17 18:41:31 +00:00
Sunny Goyal c65a0085d7 Adding support for showing the widget preview based on the provided RemoteViews
Bug: 35811129
Change-Id: I336e48cd00cfec2e617ac73bd8a81419b0944aa7
2017-03-17 11:25:29 -07:00
Sunny Goyal b265ba7449 Removing DeferredHandler and using a simple Handler to post callbacks
DeferredHandler was added when we were posting each icon separately,
to prevent starvation. But since then we have moved to binding batct
items during bind.

Also fixing waitForIdle not waiting the second time. waitForIdle was
using a global variable to maintain state, and was not waiting properly
when its called the second time before binding deep shortcuts

Original Change-Id: I9c1289cb3bfb74f86e53ec7ac6dd76bb39666b2d

Change-Id: I9e6b3ae65fbd3aec3a46092efc5249c4525efedf
2017-03-07 13:44:52 -08:00
Sunny Goyal d9843357d0 Adding some tests for request pin shortcut/widget flow
Bug: 33584624
Change-Id: I49df36f60d2ae071b9d2c77c9c3300e010cd3bb9
2017-02-22 15:46:40 -08:00
Sunny Goyal 658058b960 Adding some widget addition flow tests
> Added two dummy widget providers: with config and without config
> Added tests for verify widget config flow

Change-Id: I4577f085abe8f8b82047b644c71cc9065358153a
2017-01-23 15:28:25 -08:00