Commit Graph
18420 Commits
Author SHA1 Message Date
Liam Lee Pong Lam 61ac47e675 Merge "Revert "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard"" into main 2024-06-04 00:25:19 +00:00
Schneider Victor-tulias 38b9e1438e Merge "Clean up unused debug logs for b/319168409" into main 2024-06-03 20:31:42 +00:00
Shamali Patwa 54d8924415 Merge changes from topic "image-previews-wrap" into main
* changes:
  Adjust previews in a row to align with each other and remove whitespace.
  Move item animator to its own class and use it only for full sheet
  Measure recommendation children using the provided available height
2024-06-03 19:47:22 +00:00
Anton Vayvod ee38224910 Guard Flags references with a check for running on Android V.
Otherwise, Launcher3 next build crashes on non-V devices.

Bug: NONE Trivial cleanup.
Test: manual
Flag: NONE The change deals with flags

Change-Id: I9d9335ea1cb0f299aa5af8095ff1ea2f98c23542
2024-06-03 19:04:41 +00:00
Liam Lee Pong Lam ee5867e980 Revert "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard"
This reverts commit 883a79db71.

Reason for revert: Revert this change because it caused other bug b/343285163

Change-Id: I1fdb21cc4a5cdcf2c22e9b1927753b290626289c
2024-06-03 19:00:14 +00:00
Brandon Dayauon f839b1121d Merge "Create a bug fix flag for the FloatingMaskView." into main 2024-06-03 18:18:05 +00:00
Shamali P 7a183e4051 Adjust previews in a row to align with each other and remove whitespace.
- Introduces a WidgetTableRow that identifies preview height for all of
its children while keeping them aligned with minimum whitespace
- The fullSheet's move / change animations can conflict with the resize
so, we wait for them before performing resize of the row.

Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: Id843430c7adfc228c219ba54d504baddba792df0
2024-06-03 18:07:30 +00:00
Shamali P 01d1c31ec7 Move item animator to its own class and use it only for full sheet
Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: I6977e9854edcee385f5b7075f62dd1d8ff8dfdce
2024-06-03 18:07:21 +00:00
Shamali P 93ee47f729 Measure recommendation children using the provided available height
We always want to measure the pages based on the provided height.

Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: I9de2ed1e0d4cc37d24435b9077e60bf5f0456091
2024-06-03 18:07:11 +00:00
Schneider Victor-tulias 43592a83c8 Clean up unused debug logs for b/319168409
Flag: NONE removing debug logs
Fixes: 319168409
Test: TaplDragTest#testDragAppIcon
Change-Id: I73208b042248df04281d52eaf3ed6832abbfc144
2024-06-03 12:05:40 -04:00
Brandon Dayauon 6b65956a5c Merge "Make PrivateSpaceSettingsButton instead of having just the imageView." into main 2024-06-03 15:02:59 +00:00
Brandon Dayauon 6f1ca642ee Merge "Rename add* to update* and call setQuietMode() itself" into main 2024-06-01 00:09:52 +00:00
Brandon Dayauon 582790c56a Merge "Fading PS container on hide." into main 2024-06-01 00:07:34 +00:00
Brandon Dayauon 736527a127 Make PrivateSpaceSettingsButton instead of having just the imageView.
This way we can keep the click listener in this PrivateSpaceSettingsButton.java class.
- Moved itemInfo creation to PrivateSpaceSettingsButton and created a test class

bug: 341053089
Test: manually - presubmit video: https://drive.google.com/file/d/1_TCGrILvwmMpxbgIcbOcpB2AxeBJbyNf/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I79cd319274f4445dd00bc257be81728360d09684
2024-05-31 17:05:13 -07:00
Shamali Patwa 7c3e2ff946 Merge "Don't apply color filter on header icons if animations are disabled." into main 2024-05-31 22:00:35 +00:00
Kevin Lim f284f45581 [IconCache] Override persistent log method for when BaseIconCache
retreived empty ApplicationInfo or default app icon

Bug: b/343233224
Flag: NONE logging change for investigation
Test: NONE logging change for investigation
Change-Id: I5cd586a4868486c540a0497e2130764d44577ee9
2024-05-31 18:53:11 +00:00
Shamali Patwa 9040505afb Don't apply color filter on header icons if animations are disabled.
Disabling animations altogether reduces the flakiness, however, icon's alpha seem to be changed and then cleared, and there was 1 out of 24 runs where it flaked; so, avoiding the toggle of alpha when animations are disabled.

Bug: 337916664
Test: Screenshot tests
Flag: N/A
Change-Id: I4e9d703d005e3916ee01cf74baa2a804a3c1efd1
2024-05-31 15:08:47 +00:00
Himanshu Gupta af724fcea5 Fading PS container on hide.
This change adds a fading effect to the PS
container when Space is locked with
"hide when locked" toggle enabled.

Video: https://photos.app.goo.gl/pqhsvhfBqkTcbHXa9
GPU Profile Video: https://photos.app.goo.gl/V9yLYDH4EtAZZNrt8
before: https://drive.google.com/file/d/1bThcu34w2kgiJhgeGSmeZY_lVnMgCdsQ/view?usp=sharing
after: https://drive.google.com/file/d/1ceI3A8UXyx7GYDfHGRkN8Wkzoi-01OVh/view?usp=sharing

Bug: 299294792
Test: Manual Flash
Flag: None Animation tweak.
Change-Id: I742036f43605ca9a64f0d0a22c86b3fd69223456
2024-05-30 17:06:39 -07:00
Anushree Ganjam 991a40ca92 Merge "Update the Online search Engine key to "selected_search_engine"." into main 2024-05-30 19:50:05 +00:00
Brandon Dayauon 16cb3efa1f Rename add* to update* and call setQuietMode() itself
bug: 341053089
Test: manually - presubmit
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I7d88f18e08f45fc731f3122c55986a12e754d56a
2024-05-30 11:02:01 -07:00
Jordan Silva 503985c663 Merge "Fix Talkback wrong label announced going from App to Overview" into main 2024-05-30 16:02:55 +00:00
Shamali Patwa c4c554139f Merge "Scale down the widget previews on similar scale as the spring load scale" into main 2024-05-30 14:58:41 +00:00
Jordan Silva 8181dfdf92 Fix Talkback wrong label announced going from App to Overview
To fix the incorrect title information being spoken after a transition state ends, a new function named getTitle is introduced in the LauncherState. This function provides the correct title for the transition state. The default accessibility label is set to R.string.home_screen. All Apps and Overview states override the getTitle function to ensure the correct accessibility label for their respective states.

Fix: 265892510
Flag: EXEMPT bugfix
Test: Manual with Talkback. With Talkback enabled, navigate from App to Overview.
Change-Id: I96b820f310f8b778a149709bca687a5912386246
2024-05-30 14:01:32 +00:00
Brandon Dayauon e2d42c617f Merge "Fix private space icons disappearing from search state." into main 2024-05-30 07:19:45 +00:00
Brandon Dayauon 987efd6ea4 Fix private space icons disappearing from search state.
This is because during onBind() that the icon alpha should be set to 0 ONLY in the case
when animation + scroll is happening.

The repro cuj is this:
user has private space unlocked -> goes to toast and clicks qs tile -> onBind() happens
and animationScrolling = true -> icon alpha is now 0. Instead we should check getAnimate() && scrolling()
&& isStateTransitioning()

bug: 340836439
Test: manually -
before: https://drive.google.com/file/d/1WLZRPsz-hm1d3fVRNGXs_Ps_AcdJhkPs/view?usp=sharing
after: https://drive.google.com/file/d/1LidDKhx2ijOXmX_tcPAmng5P56WNPyyx/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation NEXTFOOD
Change-Id: I10b8ee5d8449acdb3d2c64e0e311f7dde89a464a
2024-05-29 22:41:57 -07:00
Shamali P 3dabf391f2 Scale down the widget previews on similar scale as the spring load scale
Currently entire workspace scales down, but the original view sticks
to user's finger at same size as before. This makes the view look larger
obstructing the view of workspace behind it - specifically, when the
widgets are of larger size.

Additionally, with this scaling change, the preview images that aren't
of same aspect ratio don't break the transition to final widget as
before.

Bug: 338290585
Test: Unit test
Flag: None bugfix
Change-Id: I1d1818e60506898c7b28074f01cee91282032a94
2024-05-29 22:38:22 +00:00
Brandon Dayauon c1a7d51870 Merge "Remove animatorSet's duration" into main 2024-05-29 21:16:22 +00:00
Anushree Ganjam 34c4605cf1 Update the Online search Engine key to "selected_search_engine".
Test steps:
1. Execute adb shell settings put secure selected_search_engine <search_engine_package_name> (Ex: com.duckduckgo.mobile.android)
2. Install the app and verify the search widget on launcher is updated.
3. Uninstall the app and verify the search widget is replaced by
   placeholder

When we change the search engine setting after the app is installed , we need to force-stop launcher app for the new settings to take effect.

Bug: 333029477
Flag: EXEMPT bugfix
Test: Manual
Change-Id: If127dcc87c5278a98177b83514cddb09a4124223
2024-05-29 13:40:41 -07:00
Brandon Dayauon 3f5437e14e Remove animatorSet's duration
Setting this animationDuration slows down the individual animations.
This is fine as the individual animations already has the timings that will add up to spec.

bug: 343493101
Test: before: https://drive.google.com/file/d/1nuS1c143HUosaVdhde3GW8Ryz04gUW7x/view?usp=sharing
after: https://drive.google.com/file/d/1yNcYLqBFD0di-YISNMUpryzBhqNZdncm/view?usp=sharing
Flag: None Animation tweak.
Change-Id: I5f10388fdecd934801ca208a46cc6ba93094c56f
2024-05-29 11:51:19 -07:00
Brandon Dayauon e16a2725d2 Create a bug fix flag for the FloatingMaskView.
Need to create a bug-fix flag since feature flags can't reach nextfood in time for V. We do this by renaming
the current flag.

According to https://g3doc.corp.google.com/company/teams/android-core-experiments/trunk-stable/gantry-stages/bug-fix.md?cl=head

After a flag declaration has been merged, it's no longer possible to change its purpose. If the purpose of a flag changes over time, simply rename the flag; this will create a new workflow and invalidate the previous workflow.
In cases where renaming is not possible, please file a bug for the ACE oncall. Even when re-using the name of a flag for a new purpose, please note that all the progress in the pre-existing workflow will be lost; the new bug-fix workflow will start from scratch.

bug: 339850589
Test: Presubmit/locally adb shell device_config put launcher_search com.android.launcher3.private_space_add_floating_mask_view true
Flag: ACONFIG com.android.launcher3.private_space_add_floating_mask_view STAGING
Change-Id: Iffbc6a93c4ef6bbe121e0c8fb83250174f367b9d
2024-05-28 15:49:58 -07:00
Sunny Goyal b03d274375 Merge "Fixing some missing swipecancelled events" into main 2024-05-25 08:11:56 +00:00
Sunny Goyal 97ceed42e6 Fixing some missing swipecancelled events
Updating NavBarPosition to expose more constructor and getters

Flag: com.android.launcher3.use_activity_overlay
Test: atest SwipeTransitionTest
Bug: 340432854
Change-Id: I86193fa26c0337d50e366cecb2d7debf37940fe1
2024-05-24 17:34:36 -07:00
Brian Isganitis 7317e42b47 Merge changes I340485ed,Iba07382d into main
* changes:
  Disable taskbar EDU for tiny taskbar.
  Initial prototype of tiny taskbar.
2024-05-24 19:11:55 +00:00
Pierre Barbier de Reuille 2de842b558 Merge "Update desktop mode to identify minimized tasks" into main 2024-05-24 08:26:48 +00:00
Liam Lee Pong Lam 1f5e8c6e77 Merge "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard shown" into main 2024-05-23 23:35:36 +00:00
Brian Isganitis e1eaefd537 Initial prototype of tiny taskbar.
Introducing isTinyTaskbar and using in a few places to show Taskbar on
phones.

Disabling for three button mode since the buttons will take up most of
the space. Could also prototype adding meta key as a 4th button in
this case if we feel like it.

Flag: com.android.wm.shell.enable_tiny_taskbar
Test: Manual
Bug: 341784466
Change-Id: Iba07382d9bd5d14fc29ef080a390db561f6fd454
2024-05-23 16:40:58 -04:00
Pierre Barbier de Reuille f60dd5471c Update desktop mode to identify minimized tasks
When a task is minimised, it becomes invisible but is still running.
WMShell now signals to the launcher when a task's visibility changes.
The task bar takes the visibility into account to know if a running task
is, in fact, minimised.

Test: atest NexusLauncherTests:DesktopTaskbarRunningAppsControllerTest
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 333872717
Change-Id: Iaff6b1240d354bb3c4de8e4884948acf9bf40112
2024-05-23 20:59:16 +01:00
Liam, Lee Pong Lam 883a79db71 [Launcher3] Hide keyboard when fastscroller scrolling down and keyboard
shown

Implement keyboard hiding logic: Hide keyboard when scrolling down (y > mLastY) unless already requested (mRequestedHideKeyboard). Track hide request state to prevent redundant calls.

result video: https://photos.app.goo.gl/e4dYUUiUN3BujNUz9

Bug: 333967597
Flag: EXEMPT bugfix
Test: Manual
Change-Id: I42b9d05dd5368b021577f12541248d434ee22495
2024-05-22 23:17:28 +00:00
Treehugger Robot 014a17ee58 Merge "Animate scrim within open/close PendingAnimation." into main 2024-05-22 23:13:47 +00:00
Sihua Ma 26d9b9c696 Merge "Reapply "Move widget picker tests to Robolectric"" into main 2024-05-22 21:56:02 +00:00
Zak Cohen 73fe0b439e Merge "WidgetPicker - Fix sliding scrim on add widget dialog." into main 2024-05-22 21:03:46 +00:00
Zak Cohen 10cf086910 WidgetPicker - Fix sliding scrim on add widget dialog.
Use the system dimming for standalone widget picker activity, as the system
is applying a default transition.


Bug: 342230362
Flag: NONE animation tweak
Test: visual

Change-Id: I278f8bf97acbfbfca652e1e6b616e2d2885ca92a
2024-05-22 13:32:59 -07:00
Andrew Cole 4897f7bcd6 Merge "Removing AdaptiveIconDrawable Checks" into main 2024-05-22 20:25:56 +00:00
Sihua Ma 1159c2546f Reapply "Move widget picker tests to Robolectric"
This reverts commit 97ee134acc.

Reason for revert: Fixed an issue with UI_HELPER_EXECUTOR that caused the flakiness

Test: atest NexusLauncherRoboTests
Test: SysUI studio
Flag: None Test migration
Fix: 325088642
Fix: 325088805
Fix: 325089116
Fix: 325088960

Change-Id: I2f50c30d2c861e3bba8a8fa3ec547ca2ade6153a
2024-05-22 19:41:11 +00:00
Anushree Ganjam ef9427c709 Merge "Add "Uninstall app" string for private space shortcut." into main 2024-05-22 16:08:31 +00:00
Anushree Ganjam 87e875e702 Add "Uninstall app" string for private space shortcut.
Before: https://screenshot.googleplex.com/8RvbiWnJmgAvSYf.png
After: https://screenshot.googleplex.com/4e7N3rr8EAH7k6B.png

Bug: 335451332
Flag: com.android.launcher3.enable_private_space
Flag: EXEMPT resource only update
Test: Manual
Change-Id: I759005f51562683cb6c095abcca27d448acd10f8
2024-05-21 16:36:02 -07:00
Brian Isganitis 08a7ef9d6d Animate scrim within open/close PendingAnimation.
AbstractSlideInView implementations can override how the scrim is
interpolated.

Test: Manual
Flag: NONE Trivial
Bug: 341784466
Change-Id: Id184a5753b369f8f6b4c3d905d26c1a27209dad6
2024-05-21 15:06:54 -04:00
Alex Chau 4127e460b0 Move common code from DesktopTaskView and GroupedTaskView to TaskView
- Most TaskView method will now loop through taskContainer instead of accessing the first/second
- Moved TaskThumbnailView, showWindowsView, and TaskOverlay to be part of TaskContainer. There are still some TaskOverlay access from TaskThumbnailViewDeprecated that should be remove as we start using TaskThumbnailView

Fix: 339787250
Test: Manual
Flag: EXEMPT refactor
Change-Id: Icfaa4f5eb50582faed01113465335b6d2899f781
2024-05-21 12:43:37 +01:00
Andrew Cole cdfa5e6b33 Removing AdaptiveIconDrawable Checks
As part of the internal cleanup for adaptive icons, we are removing if checks for AdaptiveIconDrawable that are no longer necessary. Also refactoring to follow a more functional programming pattern for easier future refactors.

Bug: 318867282
Flag: EXEMPT BUGFIX
Test: AllAppsSearchImageTest
Change-Id: Id13040bc4fd2ca7e85583d727b228ee390eadc91
2024-05-20 11:01:51 -07:00
Oli Thompson 9305badf5a Merge "Show edu card when managed profile removed" into main 2024-05-20 10:38:19 +00:00