Commit Graph
1528 Commits
Author SHA1 Message Date
Brandon Dayauon 412821fadf Merge "Create an alpha letter scroller" into main 2024-08-26 20:21:17 +00:00
Brandon Dayauon 1f8f88696b Create an alpha letter scroller
- The function used is a raised cosine function to determine the sections to animate.

Tested flag: adb shell device_config put launcher com.android.launcher3.letter_fast_scroller true
Based on recent figmaspec, size of selected letter is 28dp and regular is 20dp. That means scaling should be 28/20.
Colors are:
onSurface for letter
surfaceContainer for background.
Figma shows selected colors are materialColorOnSecondary

bug:358673724
Test manually: https://drive.google.com/file/d/1gvJd5KoK8X_Sv8jXg1cZ65R4AuqHuvcd/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller

Change-Id: Ia86eb0e8c41bc043fda3c44aeaf59e204429f337
2024-08-26 11:21:26 -07:00
Brandon Dayauon 71fff87e2d Add logs for when sectionInfo is computed or added for bugreport.
bug: 336947811
Test: manually/presubmit: https://screenshot.googleplex.com/A2st8q57pajFBcG
dump: https://screenshot.googleplex.com/8JGoqz2ixodHH94
Flag: NONE adding logs

Change-Id: I3edc953fa8ec58a3677cc65f858b50d95184592c
2024-08-15 11:40:31 -07:00
Treehugger Robot f205266047 Merge "Fixes background color issue in private space" into main 2024-08-05 09:39:13 +00:00
Marcelo Arteiro 17422a8c61 Fixes background color issue in private space
Bug: 355066712
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I3d53b7d82b577c05642aab9fc40f54d382578942
2024-08-02 14:54:38 +00:00
Brandon Dayauon dfb1722afc Merge "Make a dummy view at the bottom of all apps" into main 2024-07-30 20:15:26 +00:00
Brandon Dayauon 4a024c0834 Make a dummy view at the bottom of all apps
This is so that user can scroll all the way to bottom of all apps.
- updated tests to account for this new view

bug:340936636
Test manually:
before:https://drive.google.com/file/d/18mKMAedQh2uUOR2G4U_ZORIKP2tkRmEk/view?usp=sharing
after:https://drive.google.com/file/d/1UEl3kBfeInqxsgF2HwCfzOBEcsEqdbJ4/view?usp=sharing
Flag: NONE addingViewToBottomOfAllApps

Change-Id: Ib4b67a66cfc7ec2ba0dbbe211a241f244d204aaf
2024-07-29 14:58:25 -07:00
Brandon Dayauon 0ffb2d5530 Merge "Create floatingMaskViewTest and make FloatingMaskView testable." into main 2024-07-25 05:00:46 +00:00
Brandon Dayauon b6528c92ba Merge "Make settings/text alpha animation happen in parallelSet instead of when headerSetter starts." into main 2024-07-25 05:00:00 +00:00
Brandon Dayauon 29b374bcda Merge "Don't let settings button clickable during animation." into main 2024-07-24 23:28:10 +00:00
Brandon Dayauon a616e79764 Create floatingMaskViewTest and make FloatingMaskView testable.
bug: 354209068
Test: presubmit locally
Flag: NONE writing test for floatingmaskview
Change-Id: I90cbed18a908279365af185330fb2dc1e747ebff
2024-07-24 15:32:36 -07:00
Brandon Dayauon 1fe2da0d5d Make settings/text alpha animation happen in parallelSet instead of when headerSetter starts.
With the addition of floating mask views, settingsAlpha and textAlpha animation shouldn't be played in the beginning when animatorSet starts but more so during the parallel set. Otherwise, the text/settings alpha will start first before/same time as translationView. You can see this if you were to look at the video at the bottom of this commit message, specifically during the collapse case.

bug:355042924
Test manually -
before:https://drive.google.com/file/d/1BoCA5rlr9m3QDVfF5zfp9G12Ldst3kn0/view?usp=sharing
after:https://drive.google.com/file/d/1y84uxmAfJ7_SNh26jT2O-m2xOFWCMkJm/view?usp=sharing
Flag: com.android.launcher3.enable_private_space

Change-Id: I98248f4b9aa2a4e1287183710ffdc66093cef022
2024-07-24 15:18:57 -07:00
Brandon Dayauon da9520355f Don't let settings button clickable during animation.
Otherwise the user will open settings instead of unlocking the container like normal.

bug: 349115995
Test:
before: https://drive.google.com/file/d/1jmd9Pxp6d0aGSC5Sp7efrlY6JLCPvKLR/view?usp=sharing
after: https://drive.google.com/file/d/1xyKPd_hT9ut10r5B1PHxLO9gE3zh9vxK/view?usp=sharing
Flag: com.android.launcher3.enable_private_space
Change-Id: Icefaf7de72678ccf0b976039f4a3ee88c6712167
2024-07-24 14:02:54 -07:00
Kevin Lim 5ca6219003 Merge "[UniversalSearchInput] Support search box dynamic height adjustment in ActivityAllAppsContainerView" into main 2024-07-24 16:10:16 +00:00
Brandon Dayauon 6c5a875927 Adding more information to logs like content description to help with debugging.
Using appTitle doesn't seem to work and instead returns null. Content description seems to work
better anyways and show what user type (work/private)

bug: 353796175
Test: after: https://screenshot.googleplex.com/8ysLRHc9cRPg3JF
Flag: NONE adding logs
Change-Id: I4ddab1c02d795d87190592471f84faa6c98f0bfd
2024-07-22 16:27:19 -07:00
Marcelo Arteiro f38d98d1a6 Align color resources in launcher projects.
This is an effort to align/unify color usage across all launcher projects and the system itself.
This fix recreates all dynamic color attributes present in the OS since many launcher areas cannot access private attributes.
It is recomemnded to use these new local attributes in all launcher areas and avoid creating new color resources when these can be used directly.

Bug: 352690172
Test: Presubmits
Flag: EXEMPT bugfix
Change-Id: Ic36b8bf70ee37f2fdd32e459e66f0e2d001d6ba2
2024-07-19 14:22:21 +00:00
Brandon Dayauon 1710cbeb6e Don't add floatingMaskView if it will not fit.
See this screenshot for math explanation: https://screenshot.googleplex.com/9x256x5uk7qNZDg
We use the Y values of the views to determine if the header will be clipped by the
floating mask view.

Also added logs for private space.

bug:343478928
Test manually before: see bug.
after: https://drive.google.com/file/d/1FZXDQG-hV-V3wErVR0-nVCMgjUDk910Z/view?usp=sharing
Flag: com.android.launcher3.enable_private_space

Change-Id: I025e4e62f9ba60e8493d2aceb139d2c4ed6a84dd
2024-07-17 17:12:34 -07:00
Kevin Lim 0c7079ece0 [UniversalSearchInput] Support search box dynamic height adjustment in
ActivityAllAppsContainerView

Previously, ActivityAllAppsContainerView assumed a static height for the
search box and relied only on FloatingHeaderView's height calculation.
With multi-line search bar, we need to add to the FloatingHeaderView's
mMaxTranslation to update the clipping position for the recycler views
belowe

Bug: b/341795751
Flag: com.android.launcher3.multiline_search_bar
Test: http://recall/clips/32f64e77-3522-4873-bc7b-86d844912724
Change-Id: I67aab186e96d7bdecbba454f660d73f0f4408a98
2024-07-17 23:07:58 +00:00
Brandon Dayauon 0e5640376e Remove enableLayoutTransitions for private space.
Get rid of layoutTransitions as they are not reliable, see here: https://docs.google.com/document/d/1ExSemBvzzVv-I9tUCVzdLeN-lDb2hTSOM886UYSH-Qk/edit?usp=sharing&resourcekey=0-aBCCLnrB7KtkhIeyUOkKyw
Instead use actual animatorSet to do the animating.
- This also fixes the timings so that the pill transition happens at the same time of the icon alpha animation.
Made member variable for lockText and settingButton.

bug:346298256
Test:
before: See bug
after manually- video: https://drive.google.com/file/d/1B7PIgrGWMJTphc1b5CvCkyg-QYx3TTN3/view?usp=sharing
Flag: com.android.launcher3.enable_private_space

Change-Id: I049b84dbe1279a0becb090db8660975dc5c5961e
2024-07-17 10:35:53 -07:00
Kevin Lim b89cd5e91a Merge "[AllAppsStore] Dump class name in addition to package name for debugging" into main 2024-07-10 00:02:12 +00:00
Brandon Dayauon 4dd2907022 Adding logs to baseAllAppsAdapter to investigate private space icon alpha issue.
bug: 349766550
Test: N/A
Flag: com.android.launcher3.enable_private_space
Change-Id: I7ac8b538adc6cf8ad8ca801b703fd88d6287f18f
2024-07-08 12:28:11 -07:00
Kevin Lim aed2aa04ba [AllAppsStore] Dump class name in addition to package name for debugging
Bug: 333889822
Flag: EXEMPT Logging fix
Test: EXEMPT Logging fix
Change-Id: I9e1515c04bdc8381f96341e7211968fcc53f97cc
2024-07-03 18:03:30 +00:00
Brandon Dayauon d93b76b7ce Merge "Adding logs to Privateprofile animation." into main 2024-06-28 16:29:00 +00:00
Brandon Dayauon 46c542e5b7 Adding logs to Privateprofile animation.
Provide logs at the end state to see if alpha/visibility is showing or not to indicate any reasons the issue may happen
because of the animation.

bug: 341053089
Test: N/A
Flag: com.android.launcher3.enable_private_space
Change-Id: Ib94bc955e2d061d1799040ac6180d150b24118fe
2024-06-27 20:24:27 -07:00
Brandon Dayauon e770f10d2a Fix NPE when locking private space in taskbar allapps.
We can just remove the check since isSearchSupported has been launched.

bug: 345648701
Test manually video -
before: https://drive.google.com/file/d/1EwwRXrASusmqVixGWuKGnOQQyiDLE6Yy/view?usp=sharing
after: https://drive.google.com/file/d/1OCvtxzbhRJrBMMM2JH_cOurQ-_BaALSA/view?usp=sharing
Flag: com.android.launcher3.enable_private_space

Change-Id: I0ae19d342556aac4ee0b6e26b4cef8752c0beb38
2024-06-25 16:00:09 +00:00
randypfohl 176ce85d27 Abstracting StatefulActivity from StateManager
Flag: NONE - abstraction with no logic changes.

Test: Built and ran locally, for launcher3 and third party launchers

Bug: 224595066

Change-Id: I9da15bdd649d3a20e98c6552bb9e9abaec72f97f
2024-06-13 10:26:12 -07:00
Himanshu Gupta cf3a0ef2f0 Merge "Prompting the user to set Pixel/Quickstep as default Home app." into main 2024-06-12 21:13:19 +00:00
Himanshu Gupta 261a62219b Prompting the user to set Pixel/Quickstep as default Home app.
requestQuietMode API throws SecurityException in case its called
from a non-default Launcher app.
To mitigate this, we catch the exception and prompt the user
to set their default launcher to the current app.

Video(Pixel): https://photos.app.goo.gl/ni5X1c6vBbYW2JMJ9
Video(Pixel-aosp): https://photos.app.goo.gl/cYLJpTYW76Jnbonc9

Bug: 320446272
Test: Manual
Flag: NONE Bug fix tweak.
Change-Id: I6afb2ae85cabc038e1503e9c34eebd974c4f7a50
2024-06-11 19:11:21 +01:00
Brandon Dayauon 14fb9f27f4 Merge "Make private profile header scrollable" into main 2024-06-07 22:16:42 +00:00
Brandon Dayauon 05e963c245 Make private profile header scrollable
bug: 345007467
Test: manually video:
before: https://drive.google.com/file/d/1XzpD-R48WRKFBeDlHXU5xSGgc50ZON8o/view?usp=sharing
after: https://drive.google.com/file/d/1VBKZluzxvpP8ucs_uylk5esRlm9KzrZb/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I1db4bdf244b37b4c4cf55cb0d70d4011fee7de90
2024-06-04 17:23:43 -07:00
Brandon Dayauon 2c40b8366d Consolidate the header views updating into a single method
Call this updateView() in reset to ensure states are correct before animating.

bug: 341053089
Test: manually - video: https://drive.google.com/file/d/18ZSAEplL1Lk5ij3IHlwtRh1GQ6GhrXX1/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I2c825a7fd7d9a5faad8fbbb70d0f40294f715a42
2024-06-04 10:09:40 -07:00
Brandon Dayauon f839b1121d Merge "Create a bug fix flag for the FloatingMaskView." into main 2024-06-03 18:18:05 +00:00
Brandon Dayauon 6b65956a5c Merge "Make PrivateSpaceSettingsButton instead of having just the imageView." into main 2024-06-03 15:02:59 +00:00
Brandon Dayauon 6f1ca642ee Merge "Rename add* to update* and call setQuietMode() itself" into main 2024-06-01 00:09:52 +00:00
Brandon Dayauon 736527a127 Make PrivateSpaceSettingsButton instead of having just the imageView.
This way we can keep the click listener in this PrivateSpaceSettingsButton.java class.
- Moved itemInfo creation to PrivateSpaceSettingsButton and created a test class

bug: 341053089
Test: manually - presubmit video: https://drive.google.com/file/d/1_TCGrILvwmMpxbgIcbOcpB2AxeBJbyNf/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I79cd319274f4445dd00bc257be81728360d09684
2024-05-31 17:05:13 -07:00
Himanshu Gupta af724fcea5 Fading PS container on hide.
This change adds a fading effect to the PS
container when Space is locked with
"hide when locked" toggle enabled.

Video: https://photos.app.goo.gl/pqhsvhfBqkTcbHXa9
GPU Profile Video: https://photos.app.goo.gl/V9yLYDH4EtAZZNrt8
before: https://drive.google.com/file/d/1bThcu34w2kgiJhgeGSmeZY_lVnMgCdsQ/view?usp=sharing
after: https://drive.google.com/file/d/1ceI3A8UXyx7GYDfHGRkN8Wkzoi-01OVh/view?usp=sharing

Bug: 299294792
Test: Manual Flash
Flag: None Animation tweak.
Change-Id: I742036f43605ca9a64f0d0a22c86b3fd69223456
2024-05-30 17:06:39 -07:00
Brandon Dayauon 16cb3efa1f Rename add* to update* and call setQuietMode() itself
bug: 341053089
Test: manually - presubmit
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I7d88f18e08f45fc731f3122c55986a12e754d56a
2024-05-30 11:02:01 -07:00
Brandon Dayauon e2d42c617f Merge "Fix private space icons disappearing from search state." into main 2024-05-30 07:19:45 +00:00
Brandon Dayauon 987efd6ea4 Fix private space icons disappearing from search state.
This is because during onBind() that the icon alpha should be set to 0 ONLY in the case
when animation + scroll is happening.

The repro cuj is this:
user has private space unlocked -> goes to toast and clicks qs tile -> onBind() happens
and animationScrolling = true -> icon alpha is now 0. Instead we should check getAnimate() && scrolling()
&& isStateTransitioning()

bug: 340836439
Test: manually -
before: https://drive.google.com/file/d/1WLZRPsz-hm1d3fVRNGXs_Ps_AcdJhkPs/view?usp=sharing
after: https://drive.google.com/file/d/1LidDKhx2ijOXmX_tcPAmng5P56WNPyyx/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation NEXTFOOD
Change-Id: I10b8ee5d8449acdb3d2c64e0e311f7dde89a464a
2024-05-29 22:41:57 -07:00
Brandon Dayauon 3f5437e14e Remove animatorSet's duration
Setting this animationDuration slows down the individual animations.
This is fine as the individual animations already has the timings that will add up to spec.

bug: 343493101
Test: before: https://drive.google.com/file/d/1nuS1c143HUosaVdhde3GW8Ryz04gUW7x/view?usp=sharing
after: https://drive.google.com/file/d/1yNcYLqBFD0di-YISNMUpryzBhqNZdncm/view?usp=sharing
Flag: None Animation tweak.
Change-Id: I5f10388fdecd934801ca208a46cc6ba93094c56f
2024-05-29 11:51:19 -07:00
Brandon Dayauon e16a2725d2 Create a bug fix flag for the FloatingMaskView.
Need to create a bug-fix flag since feature flags can't reach nextfood in time for V. We do this by renaming
the current flag.

According to https://g3doc.corp.google.com/company/teams/android-core-experiments/trunk-stable/gantry-stages/bug-fix.md?cl=head

After a flag declaration has been merged, it's no longer possible to change its purpose. If the purpose of a flag changes over time, simply rename the flag; this will create a new workflow and invalidate the previous workflow.
In cases where renaming is not possible, please file a bug for the ACE oncall. Even when re-using the name of a flag for a new purpose, please note that all the progress in the pre-existing workflow will be lost; the new bug-fix workflow will start from scratch.

bug: 339850589
Test: Presubmit/locally adb shell device_config put launcher_search com.android.launcher3.private_space_add_floating_mask_view true
Flag: ACONFIG com.android.launcher3.private_space_add_floating_mask_view STAGING
Change-Id: Iffbc6a93c4ef6bbe121e0c8fb83250174f367b9d
2024-05-28 15:49:58 -07:00
Luca Zuccarini 2d3dae75be Clean up some old (pre-aconfig) flags.
These have been enabled for a long time and are safe to remove.

Fix: 270394392
Fix: 270394041
Flag: NONE removing an old flag
Test: everything still works as expected (no-op change)
Change-Id: Id5fc356a29a7e85324a8c3f922709251f371b2c5
2024-05-16 16:43:27 +00:00
Brandon Dayauon e369bd6502 Merge changes I7c303e66,Idc03b9d3 into main
* changes:
  Add floatingMaskView when animating to mimic bottom container.
  Add private_space_floating_mask_view flag.
2024-05-14 23:15:40 +00:00
Brandon Dayauon 1d3ddb877d Add floatingMaskView when animating to mimic bottom container.
- On expand, we add the floating mask view and translate it out at the end.
- On collapse, we translate off the mask view in the beginning once the floating mask view is added
so that we can translate it in before the actual collapsing part of the animation

bug:339850589
Test manually:
https://drive.google.com/file/d/1YNc3vq9Cb5BcbcPOHp8H3lhe6KmYBdLI/view?usp=sharing
Flag:ACONFIG com.android.launcher3.private_space_floating_mask_view STAGING

Change-Id: I7c303e6629d83408bd314886fe10113246e44dcb
2024-05-13 11:08:05 -07:00
Anna Zhuravleva 9f3bca37e6 Merge "Log animation jank" into main 2024-05-08 08:22:57 +00:00
Andy Wickham 48d3d47c1f Merge "Use ValueAnimator instead of property setter" into main 2024-05-08 01:25:13 +00:00
Brandon Dayauon c2ce6254c3 Use ValueAnimator instead of property setter
Referencing the view by ID animates correctly. Passed in views are supposedly not the same
and therefore, not animating the correct thing. (fixes on the device that can repro issue).

Bug:339179262
Bug:299294792
Test manually verified on device that can repro:https://drive.google.com/file/d/16L4wEroGEDsp_BIkmoARg9vR43upF6_8/view?usp=sharing
Flag: aconfig com.android.launcher3.enable_private_space nextfood

Change-Id: I20b06cc50928c35afa3dc1e8800b3a5bff0769be
2024-05-07 10:30:18 -07:00
Brandon Dayauon 9fa457e876 Merge "Update private space animation timings" into main 2024-05-06 18:15:05 +00:00
Holly Jiuyu Sun 6b85675657 Merge "[reset] Clean up ActivityAllAppsContainerView#reset." into main 2024-05-03 00:49:26 +00:00
Anushree Ganjam c1adbe3b4b Merge "Revert "When AllAppsSearchBarController's mInput edit text focus is false, we should hidekeyboard."" into main 2024-05-03 00:34:32 +00:00