Commit Graph
13408 Commits
Author SHA1 Message Date
Alex Chau a691a126f2 Merge changes from topic "allapps_bottomsheet_motion" into tm-dev am: d8f81e9bf4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16967984

Change-Id: I65849784b90c39780ba3ff95f57b1dcf9e86d0b9
2022-02-23 19:57:45 +00:00
Thales Lima 2f1ae6a1b5 Merge "Create new logic for grid migration" into tm-dev am: bfb275bf21
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16976104

Change-Id: I646e0c030aaa7c7a111ba1ad295332617bcf5af8
2022-02-23 19:44:47 +00:00
Alex Chau d8f81e9bf4 Merge changes from topic "allapps_bottomsheet_motion" into tm-dev
* changes:
  Tune AllApps bottom sheet VisD and motion
  Put taskbar all apps in separate overlay window and stash taskbar.
2022-02-23 19:11:51 +00:00
TreeHugger Robot 9f7ceb1c91 Merge "Fix jump in animation for hotseat while re-arranging icons" into tm-dev am: 49cb99a420
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16967985

Change-Id: I05ccfa5901e84dd103348ae16dad28cb1edb2408
2022-02-23 18:14:14 +00:00
Thales Lima bfb275bf21 Merge "Create new logic for grid migration" into tm-dev 2022-02-23 18:07:06 +00:00
Alex Chau b8c22e1155 Tune AllApps bottom sheet VisD and motion
- Make AllApps bottom sheet solid and appears from bottom
- Teleport AllApps bottom sheet as user drag to reduce drag range
  - Consider teleport interpolation for state transition sdetection
- Tuned workspace motions for AllApps bottom sheet (no translate, shrink)
- Add portrait vertical translate for tablet portrait including taskbar AllApps
- Updated bottom sheet handle and created common variables for other bottom sheets

Bug: 208599118
Test: manual on tablet AllApps, taskbar Allapps and handheld AllApps
Change-Id: I69dba5f155914cd012cc8ef3be1ef71fb2be5a40
2022-02-23 17:08:06 +00:00
Thales Lima 0a7ff8780f Create new logic for grid migration
Fixes 217564863
Test: manual, changing grids from Wallpaper & Style and checking against spec

Change-Id: I94cf77111b37810282527f1a212b6e4126d3eba1
2022-02-23 15:20:50 +00:00
TreeHugger Robot 49cb99a420 Merge "Fix jump in animation for hotseat while re-arranging icons" into tm-dev 2022-02-23 02:40:11 +00:00
Schneider Victor-tulias 2763365eb6 Fix icon loading null pointer.
Filtering out icon itemInfos with null component names when loading icons in bulk

Test: manual
Fixes: 220380324
Fixes: 220345439
Change-Id: I0e6f9ae0a363d17497207c92eadcac64ca42693f
(cherry picked from commit 5597e4825d)
2022-02-22 18:38:07 +00:00
Nicolo' Mazzucato 5765d42ada Fix jump in animation for hotseat while re-arranging icons
While re-arranging icons the hotseat remains in scale 1.0f, while the workspace reduces it's scale (as defined by SpringLoadedState.java). Previously, the code to aggregate animations was assuming hotseat and workspace always had the same scale.

MultiScaleProperty.get() was being used to set the starting value of the animation. Previously, it was returning the last aggregated value. However, this value was correct only for the workspace, but not for the hotseat. Returning the current view scale makes it always correct.

Bug: 220271046
Test: Dragged icons from hotseat to workspace, and verified animation didn't jump
Change-Id: Ic01776c1d8e3967624626ed7c44d194a06295790
2022-02-22 18:27:26 +01:00
kholoud mohamed e454c2922b [automerge] Fix crash when loading string cache 2p: 9b38947b32
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16966227

Change-Id: I1a52b09250c9ca65ba52b2c0a7c3971ec6d4cf16
2022-02-21 11:29:33 +00:00
kholoud mohamed 9b38947b32 Fix crash when loading string cache
Crash was caused by a null context in ModelDelegate

Fixes: 218305827
Test: manual
Change-Id: I1b046e24427dbdc6752ac100f488c428838ac31f
2022-02-21 11:29:24 +00:00
TreeHugger Robot 0a7af9869e Merge "Fix icon loading null pointer." 2022-02-19 05:11:40 +00:00
Schneider Victor-tulias 5597e4825d Fix icon loading null pointer.
Filtering out icon itemInfos with null component names when loading icons in bulk

Test: manual
Fixes: 220380324
Change-Id: I0e6f9ae0a363d17497207c92eadcac64ca42693f
2022-02-18 16:25:05 -08:00
TreeHugger Robot 5e8dc0e137 Merge changes I16515518,Idf7c880d
* changes:
  Remove popup container drag listener on close complete.
  Revert "Remove popup container drag listener on close complete."
2022-02-18 20:54:08 +00:00
Brian Isganitis 16467b3256 Remove popup container drag listener on close complete.
Bug: 217162588
Test: Verified removal once drag is finished. Verified working on secondary display launcher.
Change-Id: I16515518c6d488b74450456306abbfff646ac11b
2022-02-18 19:27:49 +00:00
Brian Isganitis f10ecccdf7 Revert "Remove popup container drag listener on close complete."
This reverts commit 1f7afc7740.

Reason for revert: Not all activity contexts have a drag controller, so this will cause a crash within those (e.g. SecondaryDisplayLauncher).

Change-Id: Idf7c880d8213951d06fecc3fb8cf6e8efd2037b0
2022-02-18 10:47:11 -08:00
Vinit Nayak 84124f7902 Merge "Remove Taskbar and Taskbar EDU flags." 2022-02-18 04:04:06 +00:00
TreeHugger Robot 49141ccf2e Merge "Revert "Clear all DragView in onSaveInstanceState"" 2022-02-17 20:45:46 +00:00
Tracy Zhou a2215455da Merge "Correct order of split action buttons" 2022-02-17 19:13:26 +00:00
Thales Lima 73087f4b2c Merge "Stop using bottom inset in preview" 2022-02-17 15:28:09 +00:00
Thales Lima 83b345338b Stop using bottom inset in preview
We are not using the bottom inset (navbar) in Launcher anymore, so we should not use it in preview as well.

Fixes 205284107
Test: manual

Change-Id: Iefd71b3cbe8e738c4559716af8c85015ba7c3c41
2022-02-17 13:35:41 +00:00
Tracy Zhou 0551313a9b Correct order of split action buttons
Fixes: 219988163
Fixes: 217965089
Test: https://screenshot.googleplex.com/8LNMBeEQhMVnDSm
Change-Id: I760c0b8085069181d9a1cdc582ac7d58a08f4724
2022-02-17 00:14:50 -08:00
Vinit Nayak ec4adc1d5a Remove Taskbar and Taskbar EDU flags.
Bug: 219035565
Change-Id: I643b5d006b5759723418901ffeb463fa04a82cbc
2022-02-16 17:42:21 -08:00
Schneider Victor-tulias 76d56ee5a1 Re-enable bulk icon loading
Bug: 195674813
Test: manual
Change-Id: I8cc02cb8648797e55a83bbb184ed2cd5088a1626
2022-02-16 12:23:34 -08:00
Schneider Victor-tulias ee9a54b470 Merge "Fix blank workspce icons on Launcher data refresh." 2022-02-16 19:31:33 +00:00
TreeHugger Robot 64162f1e05 Merge "Update TAPL object hierarchy in preparation for Taskbar TAPL tests" 2022-02-16 18:20:06 +00:00
TreeHugger Robot 19fff8cb74 Merge "Do not theme icons when the original view is not themed." 2022-02-16 17:13:10 +00:00
Brian Isganitis 860e675abe Merge "Remove popup container drag listener on close complete." 2022-02-16 03:33:49 +00:00
Schneider Victor-tulias d6279ae641 Update TAPL object hierarchy in preparation for Taskbar TAPL tests
See design at: go/taskbar-tapl-tests

Test: Ran tests remotely
Bug: 215218813
Change-Id: I1c2ceac8954973ea3ae5b2f797fdfb96ba7a6ec4
2022-02-15 13:33:26 -08:00
Brian Isganitis 8350fbdc39 Reverse order of long-press menu.
Test: Manual
Bug: 219777079
Change-Id: I161f10a5e7491aaa3926eba714ae2b46a10a2e62
2022-02-15 13:31:40 -08:00
Brian Isganitis 1f7afc7740 Remove popup container drag listener on close complete.
The drag listener is never removed causing a memory leak over time.

Bug: 217162588
Test: Verified removal once drag is finished and close complete is
called.

Change-Id: Iff7bac8724e76e5dec98edaffe2d8853516f6c87
2022-02-15 13:24:09 -08:00
Jon Miranda 0aa263c5a0 Do not theme icons when the original view is not themed.
Fixes bug where animations uses themed icons in All Apps, where the
icons are not themed.

We want the DragView themed since all valid drop locations will have it
appear themed.

Bug: 215650713
Test: open/close an app from All Apps
Change-Id: I9969ce4921831dd12858ed9b0fe64379e9e3b188
2022-02-15 13:16:22 -08:00
Brian Isganitis 7b046e7e27 Merge "Add predictions row to taskbar all apps." 2022-02-15 19:24:53 +00:00
TreeHugger Robot fccae60a24 Merge "Add Z scaling during unfold to launcher" 2022-02-15 17:49:11 +00:00
Nicolo' Mazzucato 12131a40fe Add Z scaling during unfold to launcher
The unfold progresses are mapped to 0.85 - 1 range and set as a scale for launcher.

In case of multiple scale animations for workspace and hotseat, they are combined using MultiScaleProperty (e.g. opening an app while unfolding/going to all apps while unfolding). Note that this is a pretty difficult scenario to be in. If that happens, we multiply all values and bound the result between the max and min values.

Bug: 217368525
Test: atest MultiScalePropertyTest and manually
Change-Id: I6131c39f36deade0b7280c72edda2d72045344e9
2022-02-15 17:02:36 +01:00
Jon Miranda baf1ef55ab Revert "Clear all DragView in onSaveInstanceState"
This reverts commit 14d6771aae
to fix bootline regression.

Bug: 210383463
Test: manual
Change-Id: I5a0dadee59bfd6b5a164fd2ca3ecdd1885cb4134
2022-02-14 20:26:40 -08:00
Benno Lin 978d646864 Merge "Implemnet methods to drag a icon to given Workspace cell" 2022-02-15 01:49:21 +00:00
Benno Lin 7738cac424 Implemnet methods to drag a icon to given Workspace cell
The CL implements public methods to drag an Icon from AllApps to a
given cell in the workspace.

Bug: 199120092
Test: Launcher3Tests:com.android.launcher3.ui.TaplTestsLauncher3#testDragAppIconToWorkspaceCell
Test: https://android-build.googleplex.com/builds/abtd/run/L89300000953052361
Test: https://android-build.googleplex.com/builds/abtd/run/L44500000953013792
Change-Id: Ife16d1f1b55b809763dd40f5afee6711049a4729
2022-02-15 01:48:45 +00:00
Jon Miranda cd191165c4 Merge "Init FloatingIconView properties before fetching drawable. & Make sure properties are reset when recycled." 2022-02-15 01:10:54 +00:00
Jon Miranda b2670d2051 Init FloatingIconView properties before fetching drawable.
& Make sure properties are reset when recycled.

This fixes the bug that causes BubbleTextView drawable not to get set.

Bug: 207389002
Test: locally disable loading AdaptiveIcons, ensure BubbleTextView
      drawable always gets drawn for closing animation

Change-Id: Ifdbf3e733e27918c57a5e9b23e5a11b65f8f338c
2022-02-14 14:43:32 -08:00
Brian Isganitis 099945b075 Add predictions row to taskbar all apps.
- We need to listen to DeviceProfile changes in case the number of
  columns changes in the grid. I made an interface/mixin separate from
  ActivityContext to avoid polutting the latter with too many things. I
  also applied this change to existing taskbar A-Z grid.
- Added all apps visited count to onboarding preferences for only
  showing "All Apps" label in place of divider 20 times. Label is also
  tracked on taskbar side and should be kept in sync.

Test: Manual
Fix: 216843395
Bug: 174174514
Change-Id: I97aa91397c334123626caf18251f19e17c7104fb
2022-02-14 11:24:16 -08:00
Alex Chau 8c3cb4e324 Merge "Fix restore not migrating to new grid" 2022-02-14 18:57:47 +00:00
Alex Chau bf63e9cf2b Merge "Add debug logs for testPromiseIcon_addedFromEligibleSession" 2022-02-14 11:38:57 +00:00
Alex Chau 29a96adaab Fix restore not migrating to new grid
- In reinitializeAfterRestore, use db path instead of grid name to check if migration is necessary, so migration will still happen if grid names are renamed. Also, only remove the target db path instead of all non source db paths, which are not necessary to be removed.
- In LauncherBackupAgent, remove old files before restoring to avoid old files from overriding restored files e.g. grid name in shared preferences
- Make sure InvariantDeviceProfile is intialize before we set pending to false, so unsupported grids can still be initialized and then be migratead
- Renamed 6x5 grid so it no longer collides with 4x4

Fix: 218500583
Test: Restore backup from supported and unsupported grids
Change-Id: Ic78e0bc7dc44ad86bd217c736b88708ad488ac0b
2022-02-11 18:15:06 +00:00
Alex Chau bf57c15750 Merge "Avoid AllApps bottom sheet from being and add collapse handle" 2022-02-11 11:07:25 +00:00
Jeremy Sim b84462a6b4 Merge "Fix DWB placement in grouped task view" 2022-02-11 06:22:40 +00:00
Jon Miranda 701774d021 Add debug logs for testPromiseIcon_addedFromEligibleSession
Bug: 202985412
Test: PromiseIconUiTest
Change-Id: I160b9229bebe07015575f8184ac2d53bcbf2bad0
2022-02-10 17:26:11 -08:00
Jeremy Sim c78ac6277c Fix DWB placement in grouped task view
In grouped task view, DWB banners will now rotate properly when phone is
in landscape or seascape orientation. Also fixes a couple of minor
existing issues with the bottom task not displaying correctly in the
first place.

Fixes: 208357326
Fixes: 216218406

Test: Tested locally on Pixel 6, using landscape, seascape, and
portrait. Double-checked with task proportions changed, RtL/LtR, and
split top/split left/split right initialization.

Change-Id: I945f9937d2d4d784c0c74a006c7d0680daf628c2
2022-02-11 00:13:13 +00:00
Daniel Chapin 65fc27d5cb Merge "Work folder name is only fetched from activity, not ActivityContext" 2022-02-10 22:23:17 +00:00