Commit Graph
14866 Commits
Author SHA1 Message Date
Luca Zuccarini f58fac5d65 Merge "Fix IME sync flicker with 3-button navigation." into tm-qpr-dev am: 3d69d9bd98 am: de9d08fc64
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20175703

Change-Id: I036cb81d3fd679959128baa6e6abdad76ba4f584
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 11:40:41 +00:00
Luca Zuccarini de9d08fc64 Merge "Fix IME sync flicker with 3-button navigation." into tm-qpr-dev am: 3d69d9bd98
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20175703

Change-Id: I5679849bbf272da9fa66060ac09773cabd55d8d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 10:52:56 +00:00
Luca Zuccarini 3d69d9bd98 Merge "Fix IME sync flicker with 3-button navigation." into tm-qpr-dev 2022-11-09 10:19:30 +00:00
TreeHugger Robot 195e9ef499 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev am: 8dd01f3ac2 am: b5c134d72c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20416308

Change-Id: Ie5d094942e3e476a8be47de609a47cf52049e621
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 02:19:58 +00:00
TreeHugger Robot b5c134d72c Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev am: 8dd01f3ac2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20416308

Change-Id: I1c271f89300a0483af71aac53dafebfe7c45429e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 01:32:38 +00:00
TreeHugger Robot 8dd01f3ac2 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev 2022-11-09 01:07:11 +00:00
Jon Miranda 5cedbe2cab Merge "Proposal to move Developer Options to top of Home settings if studio build." into tm-qpr-dev am: e76c4b1a43 am: 344fb4d230
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413621

Change-Id: Ia41c66c04bd79cc8249996e1958092c8a124a9cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 00:19:23 +00:00
Jon Miranda 344fb4d230 Merge "Proposal to move Developer Options to top of Home settings if studio build." into tm-qpr-dev am: e76c4b1a43
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413621

Change-Id: I099457c70b97fdc39bd6e1ec7f3bcec76baa0fcc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 00:16:11 +00:00
Jon Miranda e7011d2b87 Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."
This reverts commit d5a6b5f688.

Reason for revert: Breaks tests due to "SharedPreferences in credential encrypted storage are not available until after user is unlocked"

Bug: 258256906
Change-Id: I1de69249685f9d2e71183357cf3eda8d443c7d97
2022-11-08 21:56:52 +00:00
Jon Miranda 3153cd9b97 Proposal to move Developer Options to top of Home settings if studio build.
- Increases developer efficiency by avoiding the need to scroll

Bug: 258263867
Test: manual
Change-Id: I6cb46fdd12b51f8c45017f823dd4b2458e21fc72
2022-11-08 20:50:42 +00:00
Alex Chau 8aa9f9f25b Merge "Improve spaces for folders" into tm-qpr-dev am: 1feadf7d81 am: 60ae676568
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19866978

Change-Id: I4f196ef56f8ffaa70760464ac567fc8c7784e883
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-08 17:58:32 +00:00
Luca Zuccarini 81f5cee2cb Fix IME sync flicker with 3-button navigation.
With keyboard sync, the dismissal is handled by the animator. Calling
hideKeyboard() on top of that causes the two signals to conflict with
each other, resulting in the visible flicker and extra delayed hiding
animation.

Fixes: 251185052
Test: manual, see videos in the bug

Change-Id: Ic12ad304ef9e4b6a51279ce18d6c09ba93bd59be
2022-11-08 17:26:46 +00:00
Alex Chau 60ae676568 Merge "Improve spaces for folders" into tm-qpr-dev am: 1feadf7d81
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19866978

Change-Id: Idca5b77b8756de2865a332798831b4bbd38bd689
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-08 17:24:24 +00:00
Jon Miranda 12cdc89c7e Merge "Add TaskbarModeSwitchRule to test both transient/persistent taskbar." into tm-qpr-dev am: 881588bfb5 am: 416680d8f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20391679

Change-Id: Ibcc62df1f17de580c3c6f2b18749d5ef6e3be933
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-08 17:10:33 +00:00
Alex Chau 1feadf7d81 Merge "Improve spaces for folders" into tm-qpr-dev 2022-11-08 16:51:50 +00:00
Jon Miranda 416680d8f0 Merge "Add TaskbarModeSwitchRule to test both transient/persistent taskbar." into tm-qpr-dev am: 881588bfb5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20391679

Change-Id: I46efa448ae986d2fd723e2f98faa09a562cfe98f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-08 16:38:36 +00:00
Jon Miranda d5a6b5f688 Add TaskbarModeSwitchRule to test both transient/persistent taskbar.
- Lays the foundation for transient taskbar tests.
- Does not add flags that would add ACTION_OUTSIDE in tests.
  We can address testing this functionality in a separate CL

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I44acc5e589b959e6d4bc93fdc369e503c54e7d87
2022-11-07 14:18:37 -08:00
Thales Lima b35faed6e7 Improve spaces for folders
Bug: 214582832
Test: DeviceProfileTest
Change-Id: I7c5cae0792d51baf111d0aec46be302ac6ca9994
2022-11-07 18:23:48 +00:00
Sebastián Franco d4d78a5e3d Merge "Making code more readable by removing global variable used for optimizations" into tm-qpr-dev am: fda1f3c379 am: 33225643d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20307062

Change-Id: I51476719ad1331bde6a78a81f964c25f377be281
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 18:58:14 +00:00
Sebastián Franco d2fd764d8d Merge "Ensure that the reorder preview and what gets submited uses the same solution." into tm-qpr-dev am: c3cefebab4 am: 3fad40fe1c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20346867

Change-Id: Ic0a7a679baef03bd5dde65390bad52f2cb4786eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 18:58:06 +00:00
Sebastián Franco 33225643d4 Merge "Making code more readable by removing global variable used for optimizations" into tm-qpr-dev am: fda1f3c379
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20307062

Change-Id: If4d9f3861ef3c9a378ab47ab7c830fd34abef76d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 18:13:17 +00:00
Sebastián Franco 3fad40fe1c Merge "Ensure that the reorder preview and what gets submited uses the same solution." into tm-qpr-dev am: c3cefebab4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20346867

Change-Id: I95f05a2f126da884285ae7950ff9b0b2048d7b98
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 18:13:09 +00:00
Sebastián Franco fda1f3c379 Merge "Making code more readable by removing global variable used for optimizations" into tm-qpr-dev 2022-11-04 17:46:22 +00:00
Sebastián Franco c3cefebab4 Merge "Ensure that the reorder preview and what gets submited uses the same solution." into tm-qpr-dev 2022-11-04 17:45:28 +00:00
Jon Miranda 3d0a8c551d Merge "Update insets for transient taskbar" into tm-qpr-dev am: 71370c58eb am: 264e97feea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20307069

Change-Id: I14bcc2c87524b241f008586cd869ee78fab52332
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 16:40:38 +00:00
Jon Miranda 264e97feea Merge "Update insets for transient taskbar" into tm-qpr-dev am: 71370c58eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20307069

Change-Id: I46bdfbf96ca0b0be53f04c0c4aef8f07e1a56297
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 15:37:15 +00:00
Sunny Goyal c2d79ed34e Merge "Adding support for multiple overlay callbacks" into tm-qpr-dev am: 8d3241b359 am: d5bb6459f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20362704

Change-Id: Ic27caf598e09cd5fc8f5d13fc547398d8faf3d85
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 15:10:35 +00:00
Jon Miranda 71370c58eb Merge "Update insets for transient taskbar" into tm-qpr-dev 2022-11-04 15:09:12 +00:00
Sunny Goyal d5bb6459f0 Merge "Adding support for multiple overlay callbacks" into tm-qpr-dev am: 8d3241b359
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20362704

Change-Id: I5a6dc4d339b175062a158444a3afbdc645748a4f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 14:37:12 +00:00
Sunny Goyal 8d3241b359 Merge "Adding support for multiple overlay callbacks" into tm-qpr-dev 2022-11-04 14:13:12 +00:00
Holly Jiuyu Sun a485909d9e Merge "Update gBoard icon to Go/Search depending on suggestions." into tm-qpr-dev am: 341cd8589c am: 9694dbe9a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19993516

Change-Id: I85d746a750ac48db571d4a594994dc93d420901a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 04:58:08 +00:00
Holly Jiuyu Sun 9694dbe9a8 Merge "Update gBoard icon to Go/Search depending on suggestions." into tm-qpr-dev am: 341cd8589c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19993516

Change-Id: I8dba73afaddaa3a52a13dc260cc3b487276f894c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 04:24:57 +00:00
Holly Jiuyu Sun 341cd8589c Merge "Update gBoard icon to Go/Search depending on suggestions." into tm-qpr-dev 2022-11-04 03:58:18 +00:00
TreeHugger Robot ee9102248b Merge "Waiting for app install to finish before procedding with the test" into tm-qpr-dev am: 12aec8aa29 am: cff01986b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20378370

Change-Id: Ic71d0eba16d284ca68baf6d90598760f6c852993
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 03:28:32 +00:00
TreeHugger Robot cff01986b0 Merge "Waiting for app install to finish before procedding with the test" into tm-qpr-dev am: 12aec8aa29
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20378370

Change-Id: I7edf46fddca38fb0b9b0e41cfbbc7830469521d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 02:40:16 +00:00
TreeHugger Robot 12aec8aa29 Merge "Waiting for app install to finish before procedding with the test" into tm-qpr-dev 2022-11-04 02:04:10 +00:00
Holly Jiuyu Sun a884898c84 Merge "Bring up IME and focus on input when scroll to top." into tm-qpr-dev am: 15bdce40b0 am: 2ebf74cc41
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20113360

Change-Id: Id70a8e414b0841d232bea7c48bc492f3541a3d18
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 01:13:14 +00:00
Holly Jiuyu Sun 2ebf74cc41 Merge "Bring up IME and focus on input when scroll to top." into tm-qpr-dev am: 15bdce40b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20113360

Change-Id: I39f8107029a803733803f2c8a162438481cbeb43
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 01:11:20 +00:00
Jon Miranda 7e8195081e Update insets for transient taskbar
Bug: 252905206
Test: manual
Change-Id: I03bd493dbe63274c8e90cb5e415127a1dd93e9b8
2022-11-03 17:16:48 -07:00
Holly Jiuyu Sun 15bdce40b0 Merge "Bring up IME and focus on input when scroll to top." into tm-qpr-dev 2022-11-03 23:54:31 +00:00
Holly Sun b0fb5096ba Update gBoard icon to Go/Search depending on suggestions.
If there is a highlight item, show Go (->) icon. Otherwise, show Search (magnifying glass) icon.

Implement maybeUpdateEnterKeyIcon() in NexusLauncher because it's gBoard specific.

Test: manual. Verify icon changes according to states.
Bug: 183467628
Bug: 210661150
Change-Id: I5dbcb54a37f9d37ae31bf3eaef241ea8a3ede510
2022-11-03 15:59:02 -07:00
Sunny Goyal 82379187ea Adding support for multiple overlay callbacks
Bug: 193244407
Test: Presubmit
Change-Id: Ic345972056752238e7e46226533fd8f33d664213
2022-11-03 14:37:40 -07:00
Sebastian Franco 5d990eedfd Ensure that the reorder preview and what gets submited uses the same solution.
Design doc: https://docs.google.com/document/d/1RsId9OFGgkcImkkmDwWZBBvITWnGlxKVqniE3cimkqY/edit#heading=h.xzptrog8pyxf

As can be seen in the diagram in b/256770363 on every reorder the
first call in the process is MODE_SHOW_REORDER_HINT so if we make
sure that only then a solution is calculated and we reuse that
solution in the rest of the calls in the same reorder then we would
have more consistency and the animation will always be the same and
the logic state.

Fix: 256770363
Bug: 188081026
Test: atest ReorderWidgets
Change-Id: I93a1d09f5b8cbfbc461043ee3fc41b1cab294fed
2022-11-03 14:11:01 -07:00
Sunny Goyal 50097ef272 Waiting for app install to finish before procedding with the test
Bug: 256659409
Test: Presubmit
Change-Id: Ia0f4cdd072c4c439d09070b0395fcfd6909c2a8f
2022-11-03 13:33:41 -07:00
TreeHugger Robot 429f6e880f Merge "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile"" into tm-qpr-dev am: bcc14682e0 am: cd271794c8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20345841

Change-Id: I7aacbf9285271710a08a1356cc363391636106c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 14:05:09 +00:00
TreeHugger Robot cd271794c8 Merge "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile"" into tm-qpr-dev am: bcc14682e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20345841

Change-Id: I6f5ca6b81c51b91743384b8fc187788202fbec95
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 13:30:30 +00:00
TreeHugger Robot bcc14682e0 Merge "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile"" into tm-qpr-dev 2022-11-03 11:27:12 +00:00
Sebastián Franco c55ec5c580 Merge "Return the right radius to start reorder when dragging a Widget" into tm-qpr-dev am: ef24d5954c am: 251567d87b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20317221

Change-Id: I4b2aa1a6b453f79655edfa546be8041850100ab0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 22:21:47 +00:00
Holly Sun a793fc6e2c Bring up IME and focus on input when scroll to top.
Do this behind a feature flag AND only when "Always show keyboard" is selected or in prefix state.

Bug: 218846025
Test: keyboard shown when swiping up for QSB and AA+ (both main and work). Keyboard not shown when either the feature flag or Always show keyboard is disabled.
Change-Id: I3df2e0e44a8313eaf749cd6b91b7f9d0b9b80ec3
2022-11-02 15:19:23 -07:00
Sebastian Franco 4a92267d1d Making code more readable by removing global variable used for optimizations
Using the stack was more efficient because it prevented the creation
of new rectangles but it makes the code harder to read and prone to
bugs if the global state of the stack of rectangles gets corrupted
in any way.

When this optimization was written in 2008 it was necessary but now I
don't think it would have a big impact. The stack size is on average
of 30 and the rectangles are only created when doing the reorder which
runs about once per second if the user moves the finger too quickly.

Bug: 188081026
Test: atest ReorderWidgets
Change-Id: I35d8ee8d92f01035e72fe5763a7de47f4b6a73de
2022-11-02 22:10:14 +00:00