Commit Graph
137 Commits
Author SHA1 Message Date
Holly Jiuyu Sun 9d0cbfd689 Merge "Remove remaining "Item added to home screen" annoucement from talkback." into main 2025-01-08 10:15:49 -08:00
Stefan Andonian f1791fe5f0 WidgetResizeFrame doesn't disappear during Accessibility Widget Resize
Bug: 384446925
Test: Verified this works locally after reproducing it.
Flag: EXEMPT bug fix
Change-Id: If5db895358f05b24cb67f7b23d78aada6c79a80a
2025-01-02 14:33:21 -08:00
Holly Sun ae654ddaff Remove remaining "Item added to home screen" annoucement from talkback.
Based on https://b.corp.google.com/issues/383457529#comment5, we should remove all app annouced confirmation.

Bug: 386247991
Test: build
Flag: EXEMPT a11y bug fix
Change-Id: I0ba2e282a42c0785c8bdad1be23adf2bf90a44b3
2024-12-26 15:02:39 -08:00
Sihua Ma 765df11c2e Merge "Remove disruptive announcement after widget resize" into main 2024-12-23 15:16:29 -08:00
Sihua Ma 32f5d08555 Merge "Remove disruptive confirmation announcement when dropping icon" into main 2024-12-23 15:10:59 -08:00
Sihua Ma eddeb21b60 Remove disruptive announcement after widget resize
Fix: 383450007
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I9f48970d24fdb425c8e3da40d4a66195bd13dd30
2024-12-20 18:25:33 +00:00
Sihua Ma 41963ef6b2 Remove disruptive confirmation announcement when dropping icon
Bug: 383643519
Flag: EXEMPT bug fix
Test: Manual
Change-Id: I995a4a68f55f3de77cadf3eee20f72c0edb824f2
2024-12-20 00:08:31 +00:00
Willie Koomson 712264a855 Dismiss resize frame before adding widget with add button
This change updates LauncherAccessibilityDelegate so that any open
widget resize frame is closed before searching for space on the
workspace. While the resize frame is open, its cells are marked
unoccupied, so LauncherAccessibilityDelegate may try to place something
in that space.

Bug: 374228746
Test: follow repro steps in bug
Flag: EXEMPT bug fix
Change-Id: Ibcd0711fff53182d91e9781a73f00c979c15e189
2024-12-11 03:52:37 +00:00
Pinyao Ting caac0a978d Hide "Shortcut Menu" from a11y actions when shortcut menu is already opened
Bug: 378062790
Change-Id: Iab742e7f24625b1f626c30bbbefdcad68d61904e
Test: manual
Flag: EXEMPT bugfix
2024-12-04 23:14:12 +00:00
Holly Sun 879af5779c Do not let talkback read "Item added to home screen" after an app is added to home screen.
Bug: 379643701
Test: manual
Flag: EXEMPT talkback bug fix
Change-Id: I29082c2db33e0a5d20f07e7ecc4a71448337104e
2024-11-25 21:15:53 -08:00
Andrew Cole 6ace1c0d3a Test Week - AccessibleDragLstenerAdapterTest
Refactored AccessibleDragListnerAdapter to kotlin for null safety and removed a explicit call to Launcher. Added tests for all public methods
* Refactored 1 class
* Tested 1 class previously untested
* Tested 4 public methods

Bug: 353303621
Test: AccessibleDragListnerAdapterTest
Flag: TEST_ONLY

Change-Id: I7db70330f5e76b8f7298304314584e88e067c139
2024-07-18 12:34:17 -07:00
Andrew Cole 6ce5c66356 Test Week - FolderAccessibilityHelperTest
Adding unit tests for FolderAccessibilityHelper. In order to write these tests we have also included a refactor of DragAndDropAccessibilityDelegate to get mDragLayer and the accessibility delegate from ActivityContext instead of Launcher. This allows us to pull that from test context in ActivityContextWrapper during testing.

* Tests 1 class previously untested
* Tests 3 methods
* Includes 1 class refactor

Bug: 353303621
Test: FolderAccessibilityHelperTest
Flag: TEST_ONLY

Change-Id: I8d13113fc09d3ee902faecc426deb80bcbae0b0d
2024-07-17 09:48:30 -07:00
Stefan Andonian 86d3c8814b Use ItemInfo with correct position when adding to Workspace via Accessibility.
Bug: 332651703
Flag: NA
Test: Verified that the issue isn't reproducible with the fix. The issue
was 100% reproducible before.
Change-Id: I01207396e19b4f7d14d6a147e5e5fb98bae9ea99

Change-Id: I81aad9758ee33b8acc2d6a1242e54f2a47124374
2024-04-19 16:22:39 +00:00
Willie Koomson 2041fd04a4 Merge "Fix resize frame for widgets added with tap-to-add button" into main 2024-04-06 00:45:37 +00:00
Willie Koomson 7d2d6ced25 Fix resize frame for widgets added with tap-to-add button
This change updates the tap-to-add code to wait for the animations
between each step (close widget sheet, snap to Workspace page)
to finish before continuing with the next step of the flow.

Bug: 331425905
Bug: 331699050
Test: manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add TEAMFOOD
Change-Id: I774b86b429cd2e8a397e5605243056e6cea666b3
2024-04-05 22:03:37 +00:00
Jeremy Sim a596f589c4 Allow app pairs in folders
This CL substantially refactors folders to be able to take contents of type AppPairInfo. App pairs can now be moved in and out of folders, and launch from folders.

This CL contains only logic and model changes; animation and style changes (for dropping items into folders, color changes to app pair surfaces, etc.) will be in a following CL. Another CL (hopefully) will contain tests. I'm planning to submit them together, but this patch should also be able to stand alone with no issues (except janky transitions).

Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, more to follow in another CL.
Change-Id: I73732fcaefbdc61bf6e02a5be365962b8bbc3e41
2024-04-03 16:47:42 -07:00
Jeremy Sim 742630c2f8 Reparent folders and app pairs
Previously, app pairs and folders shared a common data model, FolderInfo. Now we need to separate them, so a new type, CollectionInfo, will serve as the parent of both types.

Bug: 315731527
Fixes: 326664798
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, unit tests to follow
Change-Id: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
2024-03-29 15:39:28 -07:00
Vinit Nayak 5afb093a58 Merge "Add CUJ Jank interactions for App Pair saving and launching" into main 2024-03-20 20:31:01 +00:00
Willie Koomson a55f214d71 Set initial bind options for widgets added with tap-to-add
Calls PendingAddWidgetInfo.getDefaultSizeOptions to set the bind options
for widgets added with tap-to-add.

Bug: 323886237
Test: manual, place Drive/Gmail widget and confirm correct initial size
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add DEVELOPMENT
Change-Id: Ib0143e3ff49b62d6394d6ca362d89b0ea9773e5f
2024-03-20 00:24:19 +00:00
Vinit Nayak 422a634a24 Add CUJ Jank interactions for App Pair saving and launching
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true

Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device

Change-Id: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
2024-03-18 16:27:47 -07:00
Liana Kazanova 7d5531757b Merge "Revert "Add CUJ Jank interactions for App Pair saving and launching"" into main 2024-03-18 18:39:20 +00:00
Charlie Anderson d62a9f1a6a Merge "Asynchronously call snapToPage so Talkback correctly scrolls to added widget" into main 2024-03-18 18:37:08 +00:00
Liana Kazanova d8d4fb4375 Revert "Add CUJ Jank interactions for App Pair saving and launching"
Revert submission 26567492-appPairsCUJ

Reason for revert: http://b/330185095

Reverted changes: /q/submissionid:26567492-appPairsCUJ

Change-Id: I73d29fe3618a55622e0daa22c9960e3c5783c275
2024-03-18 18:35:02 +00:00
Charlie Anderson fbf41783fc Asynchronously call snapToPage so Talkback correctly scrolls to added widget
Bug: 326269165
Test: locally tested via Talkback
Flag: N/A

Change-Id: I2be6e9758617e4eca18b3ea1ebed8189145c4108
2024-03-18 16:41:53 +00:00
Vinit Nayak 7ce42078da Add CUJ Jank interactions for App Pair saving and launching
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true

Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device

Change-Id: I5dce4b7e83fb17cc3a70565bfd5ce100a4cf72bb
2024-03-15 14:10:36 -07:00
Sunny Goyal 72a74669e7 Adding support for async view inflation
Bug: 318539160
Test: atest AsyncBindingTest; atest ItemInflaterTest
Flag: aconfig enable_workspace_inflation DEVELOPMENT
Change-Id: I77a373db7a5805f68f4b8cbfa9b586b5674252de
2024-02-22 10:58:48 -08:00
Sebastian Franco 01a134349f Removing the Hotseat from the dragNdrop accessibility targets if the dragObject is a widget
Fix: 319036474
Test: manual
Flag: NA
Change-Id: I7404c02f8ef3c0eee41694729b4d174bcea7c7d4
2024-02-09 10:40:15 -08:00
Jeremy Sim c8ab1c7081 Snap to saved app pair
This CL makes it so that LauncherAccessibilityDelegate properly calls snapToPage() when saving a new app pair.

Fixes: 322758994
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I9b571989761c36ce1c1de1e1eec6a4f559cb6428
2024-02-04 02:22:50 -08:00
Sunny Goyal eb5684ce1e Splitting bindItems method to also accept already inflated views
which will eventually allow us to inflate icons on the background thread

Bug: 318539160
Test: Presubmit
Flag: None
Change-Id: I61e4981c1c3201e92102153d9558a0885637da3a
2024-01-30 00:44:26 -08:00
Himanshu Gupta f591ce5f17 Restricting Accessibility flows for Private Profile.
Adding PS apps to the home screen is restricted.
This CL prevents the same from accessibility drags.

Bug: 289223923
Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_accessibility_drag DEVELOPEMENT
Test: Ran Launcher3 Tests.
Change-Id: I3e2b7b196b96a4d2ba34d8ece5fd6e0463f17253
2024-01-25 04:19:20 +00:00
Sunny Goyal e0c1649d87 Cleaning up some unused notifications functionality
Bug: 321154530
Test: Presubmit
Flag: N/A
Change-Id: I1ff2a4f19595659d89e7d72ee1b29036bbd54d8f
2024-01-19 00:21:02 -08:00
Holly Sun 40df2fc8d8 [a11y] Add FLAG_NOT_PINNABLE and modify supportAddToWorkSpace.
// play uninstalled app
Bug: 286998395
Bug: 287156208
Bug: 287157282
// contact
Bug: 287362865
Bug: 287370843
Bug: 287372663
// clock
Bug: 287166186
Bug: 287166771
Bug: 287167527
Test: manual
Flag: N/A

Change-Id: I859deba6218e232a232f009793044ca4be2cab19
2023-06-22 16:39:05 -07:00
Jeremy Sim 7cf0dd9e03 App Pairs (behind flag): Add new ItemInfo types and DB save functionality
This is the second of several patches implementing the App Pairs feature behind a flag.

This patch includes:
- AppPairsController, a new controller that will handle creation, launching, and deletion of app pairs
- ITEM_TYPE_APP_PAIR is a new type of FolderInfo (FolderInfo now can be either a folder or an app pair, and should probably be renamed to CollectionInfo or something more generic in future)
- Necessary plumbing for these new types
- Database code that handles saving a new app pair to the database with the correct schema

Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274189428
Test: Not included in this CL, but will follow
Change-Id: Ie3aefd4eb9171f471789f54876de742849d3013b
2023-04-21 14:23:54 -07:00
Jeremy Sim 8eed87ac89 Fix bug where Taskbar was not auto-hiding after splitscreen launch from icon menu
This patch fixes a bug where the transient Taskbar was not hiding properly after splitscreen was initiated. When the user is inside an app and launches splitscreen by longpressing on a Taskbar icon and selecting the split button, the transient Taskbar should hide right away. This is an equivalent action to dragging the Taskbar icon up to create a split, and should hide the Taskbar so that other UI elements (like system-level toasts and error messages) can be seen.

The bug occurred because updateAndAnimateTransientTaskbar() is not being called in this specific code path to stash the Taskbar.

Fixed by adding a new call to updateAndAnimateTransientTaskbar upon clicking the splitscreen menu button.

Fixes: 272292897
Test: Manual
Change-Id: I64a9acfc41ddcaba4d9f43eb216458de44b4c9a4
2023-03-21 14:35:36 -07:00
Sebastian Franco 877088e6c3 Change the access of cellX/Y of CellLayoutLayoutParams to private
Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
Merged-In: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-13 18:25:10 +00:00
Sihua Ma 7a382f139d Making talkback focus on the widget after the resize
Fix: 216386890
Test: Manual
Change-Id: I79b0280c0f24a81be44e1578755ed90cf3343f88
2022-11-14 13:12:44 -08:00
Sebastian Franco d468299c0f Moving the class LayoutParams to a file outside CellLayout
I'm moving the LayoutParams to another file to start the decoupling
of the Reorder outside of the CellLayout.

Also, I change the name from LayoutParams to LauncherLayoutParams to prevent confusion with ViewGroup.LayoutParams making it explicit that this are different LayoutParams.

Bug: 188081026
Test: atest ReorderWidget
Change-Id: I92251c5540ffcf5ece7b933e6f6c836eb825c997
2022-10-12 16:14:42 +00:00
Alex Chau 158caf466c Only setup SecondaryDropTarget in onDragStart
- In LauncherAccessibilityDelegate.getsupportedActions, it calls supportsAccessibilityDrop on each button regardless if DropTargetBar is visible or not. SecondaryDropTarget.supportsAccessibilityDrop attempts to setupUi which causes measure/layout of DropTargetBar (as well as DragLayer) each time LauncherAccessibilityDelegate.getsupportedActions is called
- To avoid this, only setupUi in onDragStart. In other cases don't call setUi.
- Also fixed a bug that when accessibility is on, upon dragging a suggested app, the secondary action suddenly changed to Uninstall

Fix: 233383721
Test: Enable accessibility, observe no excessive amount of onLayout is called on DropTargetBar
Change-Id: I4d1a00d320cceed81fa1312b5fc5f1081637bea8
2022-05-25 11:04:42 +00:00
Sunny Goyal f0ff70a2a5 Adding support for easily extending Launcher DragAndDrop support
Bug: 232165524
Test: Verified locally
Change-Id: I3b4f37bc9914de55330662edd678e6fdd0eafece
2022-05-11 21:34:08 +00:00
Shikha Malhotra fefafe5aa9 Putting back generics for Workspace
This got over-written in merging files

Bug: b/218186705
Test: Manually tested Launcher3 works.
Change-Id: I55287e110d067a338204924337091ead044b34ec
2022-04-14 15:35:33 +00:00
Shikha Malhotra f78da1bae3 Review comments followup
These are review comments followup from ag/17399997

Bug: b/218187058
Test: manually test thet Launcher3 features work correctly
Change-Id: I9865a37c1ed663370dc28e7678994f3d961e3cd1
2022-04-12 14:33:07 +00:00
Schneider Victor-tulias bdb0dd8cfb Refactor LauncherAccessibilityDelegate so it can be used outside of Launcher
Bug: 198438631
Test: used talkback on launcher
Change-Id: I991320184ad93816c4ba21fb8fcfe12202bfae25
2021-11-23 12:48:14 -08:00
sfufa@google.com 6a12ec34fb Support Accessibility workspace addition for WorkspaceItemInfo
Bug: 192678946
Test: Manual using TalkBack
Change-Id: I1d0d06ccac934eb80dba7670e93ec631c12e5074
2021-09-20 01:15:08 -07:00
Andras Kloczl 408a54f2e7 Add two extra empty pages on two panel launcher home
Add a new screen ID for the second extra empty page
and add that new screen as well when the existing
extra empty page is added so that users can put items
on both sides of Workspace.

Test: manual
Bug: 196376162
Change-Id: I0b4f2e818407a10d8a7c032788a7bd7a61267779
2021-09-05 22:03:07 +01:00
Alex Chau 1e4484669d Remove widget panel
- Remove all usage of LEFT_PANEL_ID and fixed left panel code
- For preview renderer, load screen 0 + screen 1 instead
- Added a split display specific default workspace layout, with a placeholder app to pass test before we implement page pairing(b/196376162)
- Known issue: If screenId 1 is deleted, right panel will disappear from Wallpaepr & Style because there is no screenId 1. Will be resovled after page pairing(b/196376162)

Bug: 175939730
Test: manual and TaplTestsLauncher3#testWorkSpace
Change-Id: Icac1c94165c14a49c17897c45355b6cdc4d87e91
2021-08-13 21:48:35 +01:00
Andras Kloczl e32e8641d6 Fix Workspace item move issues when using Talkback
- fix the crash when an item was moved onto the right panel
- fix the issue that prevented the user from moving an item from the left panel

Test: manual
Bug: 194903736
Change-Id: Ib41f5d6d08e8815a52631ef952d32dcf899455e2
2021-08-04 11:04:19 +02:00
Steven Ng 22b6039270 Exact widget sizes functionalities into an utility class
Test: resize widget, move widget, add widget.
Bug: 189975670
Change-Id: Ia0bc2297891e1cfa33697e985064db5d1dcdfc8b
2021-06-08 11:42:48 +01:00
Sunny Goyal 01b32466c3 Revert "Revert "Exposing AnimatorListeners in StateManager to receive both success and failure callback""
This reverts commit d7f11d5fb9.

Reason for revert: Fixed initial error
Bug: 185554764

Change-Id: I32cc49f9b3820166736ceb347f33577939aa6efa
2021-05-13 10:23:35 -07:00
Winson Chung d7f11d5fb9 Revert "Exposing AnimatorListeners in StateManager to receive both success and failure callback"
This reverts commit a75f576890.

Reason for revert: b/187887269
Bug: 187887269

Change-Id: I8a56ff7054e71cf30b113fdaa213397dae0c53cb
2021-05-12 21:25:22 +00:00
Sunny Goyal a75f576890 Exposing AnimatorListeners in StateManager to receive both success and failure callback
Updating various callers to use onSuccess or onEnd appropriately

Test: Manual
Bug: 185554764
Change-Id: I357dd1fdbe111e7a30d4c8dee520fbd7d9956b7d
2021-05-11 13:53:14 -07:00