From c900bda8da84ff721b9e05efd0fbda5009d807a3 Mon Sep 17 00:00:00 2001 From: Jagrut Desai Date: Wed, 22 Jan 2025 13:16:30 -0800 Subject: [PATCH] Fix Taskbar existing app launch in DW The issue: we were blocking the opening of existing app in when multi-instance flag was tunred on. The Solution: we don't actually need to do this since, the multiple taskbar icons of the same app are blocked pm TaskbarRecentsAppsController Test: Manual, Presubmit Bug: 391143101 Flag: EXEMPT bugfix Change-Id: Ic2aa7cca4fd18d9b8cf48a2778c6e666241a4f7f --- .../android/launcher3/taskbar/TaskbarActivityContext.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java b/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java index 9fe92029e4..f6d0d8d4ad 100644 --- a/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java +++ b/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java @@ -85,7 +85,6 @@ import androidx.core.view.WindowInsetsCompat; import com.android.launcher3.AbstractFloatingView; import com.android.launcher3.BubbleTextView; import com.android.launcher3.DeviceProfile; -import com.android.launcher3.Flags; import com.android.launcher3.LauncherPrefs; import com.android.launcher3.LauncherSettings.Favorites; import com.android.launcher3.R; @@ -1345,7 +1344,7 @@ public class TaskbarActivityContext extends BaseTaskbarContext { mControllers.uiController.onTaskbarIconLaunched(api); mControllers.taskbarStashController.updateAndAnimateTransientTaskbar(true); } - } else if (tag instanceof TaskItemInfo info && !Flags.enableMultiInstanceMenuTaskbar()) { + } else if (tag instanceof TaskItemInfo info) { RemoteTransition remoteTransition = canUnminimizeDesktopTask(info.getTaskId()) ? createUnminimizeRemoteTransition() : null; @@ -1354,7 +1353,8 @@ public class TaskbarActivityContext extends BaseTaskbarContext { taskView = recents.getTaskViewByTaskId(info.getTaskId()); } - if (areDesktopTasksVisible() && taskView != null) { + if (areDesktopTasksVisible() && taskView != null + && mControllers.uiController.isInOverviewUi()) { RunnableList runnableList = taskView.launchWithAnimation(); if (runnableList != null) { runnableList.add(() ->