From 8dae1be563d114fce1e36e73e64c6967fcde3548 Mon Sep 17 00:00:00 2001 From: Anushree Ganjam Date: Wed, 11 Dec 2024 16:42:09 -0800 Subject: [PATCH] Update the All apps label to "Apps list" Set the AccessibilityNodeInfo containerTitle to improve a11y for users in predictionRow. See expected behavior suggestion in https://b.corp.google.com/issues/379640673#comment1 Video Quickstep launcher: http://recall/-/cOtJfHR6buEyEHnRyCqzVE/eugH3ID7eenOuLwTszaLHk Pixel launcher: http://recall/-/cOtJfHR6buEyEHnRyCqzVE/fftzwMRCy6N3o7OcwiGMdk Bug: 379640673 Test: Manual Flag: EXEMPT a11y bugfix Change-Id: I23a8a142afb213c0801402a56bc134bc14f0f97d --- quickstep/res/layout/floating_header_content.xml | 2 +- .../launcher3/appprediction/PredictionRowView.java | 12 ++++++++++++ .../launcher3/uioverrides/states/AllAppsState.java | 2 +- res/values/strings.xml | 2 ++ 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/quickstep/res/layout/floating_header_content.xml b/quickstep/res/layout/floating_header_content.xml index b21c34b099..0021e224f5 100644 --- a/quickstep/res/layout/floating_header_content.xml +++ b/quickstep/res/layout/floating_header_content.xml @@ -3,8 +3,8 @@ updateVisibility(); } + @Override + public void onInitializeAccessibilityNodeInfo(AccessibilityNodeInfo info) { + super.onInitializeAccessibilityNodeInfo(info); + if (Build.VERSION.SDK_INT >= UPSIDE_DOWN_CAKE) { + info.setContainerTitle(mActivityContext.getString(R.string.title_app_suggestions)); + } + } + @Override protected void onAttachedToWindow() { super.onAttachedToWindow(); diff --git a/quickstep/src/com/android/launcher3/uioverrides/states/AllAppsState.java b/quickstep/src/com/android/launcher3/uioverrides/states/AllAppsState.java index d387794c20..dae63af097 100644 --- a/quickstep/src/com/android/launcher3/uioverrides/states/AllAppsState.java +++ b/quickstep/src/com/android/launcher3/uioverrides/states/AllAppsState.java @@ -102,7 +102,7 @@ public class AllAppsState extends LauncherState { @Override public int getTitle() { - return R.string.all_apps_label; + return R.string.all_apps_list_label; } @Override diff --git a/res/values/strings.xml b/res/values/strings.xml index cdfbefea64..e211c3c9b9 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -190,6 +190,8 @@ All apps + Apps list + Notifications