From 29016e8e460c7559dcb8226d51c090d0cde383d0 Mon Sep 17 00:00:00 2001 From: Tony Wickham Date: Tue, 23 Feb 2021 16:51:37 -0800 Subject: [PATCH] Make RecentsView INVISIBLE instead of GONE This ensures it gets laid out to compute things like page scrolls. Test: Repro steps to both bugs below - Force stop launcher, swipe up slightly, hold, and let go to return to the current task; ensure no jumps or jank - Force stop launcher, swipe up and hold to go to Overview, ensure no jump on motion pause Fixes: 180736503 Fixes: 175064755 Change-Id: I44581f87600b02a3c9ddefcb8c94bb3845cd9152 --- quickstep/src/com/android/quickstep/views/RecentsView.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/quickstep/src/com/android/quickstep/views/RecentsView.java b/quickstep/src/com/android/quickstep/views/RecentsView.java index deb1388e96..248fa46d79 100644 --- a/quickstep/src/com/android/quickstep/views/RecentsView.java +++ b/quickstep/src/com/android/quickstep/views/RecentsView.java @@ -537,7 +537,7 @@ public abstract class RecentsView extends PagedView @Override protected void onWindowVisibilityChanged(int visibility) { super.onWindowVisibilityChanged(visibility); - if (visibility == GONE && ENABLE_QUICKSTEP_LIVE_TILE.get()) { + if (visibility != VISIBLE && ENABLE_QUICKSTEP_LIVE_TILE.get()) { finishRecentsAnimation(true /* toRecents */, null); } updateTaskStackListenerState(); @@ -1748,7 +1748,7 @@ public abstract class RecentsView extends PagedView if (alpha > 0) { setVisibility(VISIBLE); } else if (!mFreezeViewVisibility) { - setVisibility(GONE); + setVisibility(INVISIBLE); } } @@ -1760,7 +1760,7 @@ public abstract class RecentsView extends PagedView if (mFreezeViewVisibility != freezeViewVisibility) { mFreezeViewVisibility = freezeViewVisibility; if (!mFreezeViewVisibility) { - setVisibility(mContentAlpha > 0 ? VISIBLE : GONE); + setVisibility(mContentAlpha > 0 ? VISIBLE : INVISIBLE); } } }